public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid star imports and add missing braces (#10521)

Browse Source 
Fixes the following SAT findings:

* AvoidStarImportCheck (125)
* NeedBracesCheck (39)

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2021-04-15 16:12:05 +02:00
committed by GitHub
parent e24d43aecb
commit 0c36650179
110 changed files with 793 additions and 217 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
bundles/org.openhab.binding.homematic/src/main/java/org/openhab/binding/homematic/internal/communicator/parser/CommonRpcParser.java
View File

@@ -181,8 +181,9 @@ public abstract class CommonRpcParser<M, R> implements RpcParser<M, R> {
dp.setUnit("dBm");
}
// Bypass: For at least one device the CCU does not send a unit together with the value
if (dp.getUnit() == null && dp.getName().startsWith(HomematicConstants.DATAPOINT_NAME_OPERATING_VOLTAGE))
if (dp.getUnit() == null && dp.getName().startsWith(HomematicConstants.DATAPOINT_NAME_OPERATING_VOLTAGE)) {
dp.setUnit("V");
}
HmValueType valueType = HmValueType.parse(type);
if (valueType == null || valueType == HmValueType.UNKNOWN) {

3
bundles/org.openhab.binding.homematic/src/main/java/org/openhab/binding/homematic/internal/handler/HomematicThingHandler.java
View File

@@ -417,8 +417,9 @@ public class HomematicThingHandler extends BaseThingHandler {
loadHomematicChannelValues(device.getChannel(0));
ThingStatus oldStatus = thing.getStatus();
if (oldStatus == ThingStatus.UNINITIALIZED)
if (oldStatus == ThingStatus.UNINITIALIZED) {
return;
}
ThingStatus newStatus = ThingStatus.ONLINE;
ThingStatusDetail newDetail = ThingStatusDetail.NONE;

3
bundles/org.openhab.binding.homematic/src/main/java/org/openhab/binding/homematic/internal/type/MetadataUtils.java
View File

@@ -332,8 +332,9 @@ public class MetadataUtils {
case "m3":
return ITEM_TYPE_NUMBER + ":Volume";
case "":
if (dpName.startsWith(DATAPOINT_NAME_OPERATING_VOLTAGE))
if (dpName.startsWith(DATAPOINT_NAME_OPERATING_VOLTAGE)) {
return ITEM_TYPE_NUMBER + ":ElectricPotential";
}
case "s":
case "min":
case "minutes":