public
/
openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[epsonprojector] Always set ready=true on disconnect and improve documentation (#10079) 

* Always set ready on disconnect and improve documentation
* improve documentation

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
This commit is contained in:
mlobstein 2021-02-06 20:32:34 -06:00 committed by GitHub
parent fa307e203e
commit 10b9b562ad
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bundles/org.openhab.binding.epsonprojector/README.md
View File

@ -1,7 +1,7 @@
# Epson Projector Binding # Epson Projector Binding
This binding is compatible with Epson projectors that support the ESC/VP21 protocol over the built-in ethernet port, serial port or USB to serial adapter. This binding is compatible with Epson projectors that support the ESC/VP21 protocol over the built-in network (ethernet or Wi-Fi) port, serial port or USB to serial adapter.
If your projector does not have a built-in ethernet port, you can connect to your projector's serial port via a TCP connection using a serial over IP device or by using`ser2net`. If your projector does not have built-in networking, you can connect to your projector's serial port via a TCP connection using a serial over IP device or by using`ser2net`.
## Supported Things ## Supported Things
@ -27,7 +27,7 @@ The `projector-serial` thing has the following configuration parameters:
The `projector-tcp` thing has the following configuration parameters: The `projector-tcp` thing has the following configuration parameters:
- _host_: IP address for the projector or serial over IP device - _host_: IP address for the projector or serial over IP device
- _port_: Port for the projector or serial over IP device; default 3629 for projectors with built-in ethernet connector - _port_: Port for the projector or serial over IP device; default 3629 for projectors with built-in ethernet connector or Wi-Fi
- _pollingInterval_: Polling interval in seconds to update channel states | 5-60 seconds; default 10 seconds - _pollingInterval_: Polling interval in seconds to update channel states | 5-60 seconds; default 10 seconds
Some notes: Some notes:

2
bundles/org.openhab.binding.epsonprojector/src/main/java/org/openhab/binding/epsonprojector/internal/EpsonProjectorDevice.java
View File

@ -206,11 +206,11 @@ public class EpsonProjectorDevice {
public void disconnect() throws EpsonProjectorException { public void disconnect() throws EpsonProjectorException {
connection.disconnect(); connection.disconnect();
connected = false; connected = false;
ready = true;
ScheduledFuture<?> timeoutJob = this.timeoutJob; ScheduledFuture<?> timeoutJob = this.timeoutJob;
if (timeoutJob != null) { if (timeoutJob != null) {
timeoutJob.cancel(true); timeoutJob.cancel(true);
this.timeoutJob = null; this.timeoutJob = null;
ready = true;
} }
} }