public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use Collection.isEmpty (#10525)

Browse Source 
Fixes 47 SAT UseCollectionIsEmpty findings.

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2021-04-15 21:00:47 +02:00
committed by GitHub
parent 7a22d65406
commit 1633c705a1
35 changed files with 67 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bundles/org.openhab.binding.jablotron/src/main/java/org/openhab/binding/jablotron/internal/handler/JablotronAlarmHandler.java
View File

@@ -187,7 +187,7 @@ public abstract class JablotronAlarmHandler extends BaseThingHandler {
}
List<JablotronHistoryDataEvent> events = sendGetEventHistory();
if (events != null && events.size() > 0) {
if (events != null && !events.isEmpty()) {
JablotronHistoryDataEvent event = events.get(0);
updateLastEvent(event);
}
@@ -221,7 +221,7 @@ public abstract class JablotronAlarmHandler extends BaseThingHandler {
protected void updateEventChannel(String channel) {
List<JablotronHistoryDataEvent> events = eventCache.getValue();
if (events != null && events.size() > 0) {
if (events != null && !events.isEmpty()) {
JablotronHistoryDataEvent event = events.get(0);
switch (channel) {
case CHANNEL_LAST_EVENT_TIME:

6
bundles/org.openhab.binding.jablotron/src/main/java/org/openhab/binding/jablotron/internal/handler/JablotronJa100FHandler.java
View File

@@ -12,9 +12,7 @@
*/
package org.openhab.binding.jablotron.internal.handler;
import static org.openhab.binding.jablotron.JablotronBindingConstants.BINDING_ID;
import static org.openhab.binding.jablotron.JablotronBindingConstants.CACHE_TIMEOUT_MS;
import static org.openhab.binding.jablotron.JablotronBindingConstants.CHANNEL_LAST_CHECK_TIME;
import static org.openhab.binding.jablotron.JablotronBindingConstants.*;
import java.util.List;
@@ -181,7 +179,7 @@ public class JablotronJa100FHandler extends JablotronAlarmHandler {
// update events
List<JablotronHistoryDataEvent> events = sendGetEventHistory();
if (events != null && events.size() > 0) {
if (events != null && !events.isEmpty()) {
JablotronHistoryDataEvent event = events.get(0);
updateLastEvent(event);
}

6
bundles/org.openhab.binding.jablotron/src/main/java/org/openhab/binding/jablotron/internal/handler/JablotronJa100Handler.java
View File

@@ -12,9 +12,7 @@
*/
package org.openhab.binding.jablotron.internal.handler;
import static org.openhab.binding.jablotron.JablotronBindingConstants.BINDING_ID;
import static org.openhab.binding.jablotron.JablotronBindingConstants.CACHE_TIMEOUT_MS;
import static org.openhab.binding.jablotron.JablotronBindingConstants.CHANNEL_LAST_CHECK_TIME;
import static org.openhab.binding.jablotron.JablotronBindingConstants.*;
import java.util.List;
@@ -199,7 +197,7 @@ public class JablotronJa100Handler extends JablotronAlarmHandler {
private void updateTemperatureChannel(Channel channel, JablotronServiceDetailSegment segment) {
List<JablotronServiceDetailSegmentInfo> infos = segment.getSegmentInfos();
if (infos.size() > 0) {
if (!infos.isEmpty()) {
logger.debug("Found value: {} and type: {}", infos.get(0).getValue(), infos.get(0).getType());
updateState(channel.getUID(), QuantityType.valueOf(infos.get(0).getValue(), SIUnits.CELSIUS));
} else {