public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use Collection.isEmpty (#10525)

Browse Source 
Fixes 47 SAT UseCollectionIsEmpty findings.

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2021-04-15 21:00:47 +02:00
committed by GitHub
parent 7a22d65406
commit 1633c705a1
35 changed files with 67 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
bundles/org.openhab.binding.wlanthermo/src/main/java/org/openhab/binding/wlanthermo/internal/api/esp32/WlanThermoEsp32CommandHandler.java
View File

@@ -91,7 +91,7 @@ public class WlanThermoEsp32CommandHandler {
}
} else if (channelUID.getId().startsWith(CHANNEL_PREFIX)) {
int channelId = Integer.parseInt(groupId.substring(CHANNEL_PREFIX.length())) - 1;
if (channelList != null && channelList.size() > 0 && channelId < channelList.size()) {
if (channelList != null && !channelList.isEmpty() && channelId < channelList.size()) {
Channel channel = channelList.get(channelId);
switch (channelUID.getIdWithoutGroup()) {
case CHANNEL_NAME:
@@ -176,7 +176,7 @@ public class WlanThermoEsp32CommandHandler {
if (channelUID.getId().startsWith(CHANNEL_PREFIX)) {
int channelId = Integer.parseInt(groupId.substring(CHANNEL_PREFIX.length())) - 1;
if (channelList.size() > 0 && channelId < channelList.size()) {
if (!channelList.isEmpty() && channelId < channelList.size()) {
Channel channel = channelList.get(channelId);
switch (channelUID.getIdWithoutGroup()) {
case CHANNEL_NAME:
@@ -283,7 +283,7 @@ public class WlanThermoEsp32CommandHandler {
if (channelUID.getId().startsWith(CHANNEL_PREFIX)) {
int channelId = Integer.parseInt(groupId.substring(CHANNEL_PREFIX.length())) - 1;
if (channelList.size() > 0 && channelId < channelList.size()) {
if (!channelList.isEmpty() && channelId < channelList.size()) {
Channel channel = channelList.get(channelId);
if (CHANNEL_ALARM_OPENHAB.equals(channelUID.getIdWithoutGroup())) {
if (channel.getTemp() != 999) {

6
bundles/org.openhab.binding.wlanthermo/src/main/java/org/openhab/binding/wlanthermo/internal/api/nano/WlanThermoNanoV1CommandHandler.java
View File

@@ -81,7 +81,7 @@ public class WlanThermoNanoV1CommandHandler {
}
} else if (channelUID.getId().startsWith(CHANNEL_PREFIX)) {
int channelId = Integer.parseInt(groupId.substring(CHANNEL_PREFIX.length())) - 1;
if (channelList.size() > 0 && channelId < channelList.size()) {
if (!channelList.isEmpty() && channelId < channelList.size()) {
Channel channel = channelList.get(channelId);
switch (channelUID.getIdWithoutGroup()) {
case CHANNEL_NAME:
@@ -165,7 +165,7 @@ public class WlanThermoNanoV1CommandHandler {
if (channelUID.getId().startsWith(CHANNEL_PREFIX)) {
int channelId = Integer.parseInt(groupId.substring(CHANNEL_PREFIX.length())) - 1;
if (channelList.size() > 0 && channelId < channelList.size()) {
if (!channelList.isEmpty() && channelId < channelList.size()) {
Channel channel = channelList.get(channelId);
switch (channelUID.getIdWithoutGroup()) {
case CHANNEL_NAME:
@@ -266,7 +266,7 @@ public class WlanThermoNanoV1CommandHandler {
if (channelUID.getId().startsWith(CHANNEL_PREFIX)) {
int channelId = Integer.parseInt(groupId.substring(CHANNEL_PREFIX.length())) - 1;
if (channelList.size() > 0 && channelId < channelList.size()) {
if (!channelList.isEmpty() && channelId < channelList.size()) {
Channel channel = channelList.get(channelId);
if (CHANNEL_ALARM_OPENHAB.equals(channelUID.getIdWithoutGroup())) {
if (channel.getTemp() != 999) {