public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[knx] Fix typos in code comments (#15839)

Browse Source 
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
This commit is contained in:
Holger Friedrich 2023-11-03 23:16:41 +01:00 committed by GitHub
parent fddacb4c80
commit 1ca0f643a0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/client/DeviceInspector.java
View File

@ -284,7 +284,7 @@ public class DeviceInspector {
/** /**
* @implNote {@link readDeviceDescription(address)} tries to read device description from the KNX device. * @implNote {@link readDeviceDescription(address)} tries to read device description from the KNX device.
* According to KNX specification, eihter device descriptor DD0 or DD2 must be implemented. * According to KNX specification, either device descriptor DD0 or DD2 must be implemented.
* Currently only data from DD0 is returned; DD2 is just logged in debug mode. * Currently only data from DD0 is returned; DD2 is just logged in debug mode.
* *
* @param address Individual address of KNX device * @param address Individual address of KNX device

2
bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/client/KNXClient.java
View File

@ -48,7 +48,7 @@ public interface KNXClient {
/** /**
* Get the {@link DeviceInfoClient} which allows further device inspection. * Get the {@link DeviceInfoClient} which allows further device inspection.
* *
* @return the device infor client * @return the device info client
* @throws IllegalStateException in case the client is not connected * @throws IllegalStateException in case the client is not connected
*/ */
DeviceInfoClient getDeviceInfoClient(); DeviceInfoClient getDeviceInfoClient();

6
bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/client/SerialClient.java
View File

@ -63,7 +63,7 @@ public class SerialClient extends AbstractKNXClient {
} }
/** /**
* try autodetection of cEMI devices via the PEI identification frame * try automatic detection of cEMI devices via the PEI identification frame
* *
* @implNote This is based on an vendor specific extension and may not work for other devices. * @implNote This is based on an vendor specific extension and may not work for other devices.
*/ */
@ -92,7 +92,7 @@ public class SerialClient extends AbstractKNXClient {
// content[1..2] physical address // content[1..2] physical address
// content[3..8] serial no // content[3..8] serial no
// //
// Weinzierl adds 2 extra bytes, 0x0004 for capablity cEMI, // Weinzierl adds 2 extra bytes, 0x0004 for capability cEMI,
// see "Weinzierl KNX BAOS Starter Kit, User Guide" // see "Weinzierl KNX BAOS Starter Kit, User Guide"
if (0 == content[9] && 4 == content[10]) { if (0 == content[9] && 4 == content[10]) {
logger.debug("Detected device with cEMI support"); logger.debug("Detected device with cEMI support");
@ -118,7 +118,7 @@ public class SerialClient extends AbstractKNXClient {
} }
logger.debug("Establishing connection to KNX bus through FT1.2 on serial port {}{}{}", serialPort, logger.debug("Establishing connection to KNX bus through FT1.2 on serial port {}{}{}", serialPort,
(useCemiL ? " using cEMI" : ""), ((useCemiL != useCemi) ? " (autodetected)" : "")); (useCemiL ? " using cEMI" : ""), ((useCemiL != useCemi) ? " (autodetected)" : ""));
// CEMI support by Calimero library, userful for newer serial devices like KNX RF sticks, kBerry, // CEMI support by Calimero library, useful for newer serial devices like KNX RF sticks, kBerry,
// etc.; default is still old EMI frame format // etc.; default is still old EMI frame format
if (useCemiL) { if (useCemiL) {
return KNXNetworkLinkFT12.newCemiLink(serialPort, new TPSettings()); return KNXNetworkLinkFT12.newCemiLink(serialPort, new TPSettings());

2
bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/handler/IPBridgeThingHandler.java
View File

@ -62,7 +62,7 @@ public class IPBridgeThingHandler extends KNXBridgeBaseThingHandler {
@Override @Override
public void initialize() { public void initialize() {
// initialisation would take too long and show a warning during binding startup // initialization would take too long and show a warning during binding startup
// KNX secure is adding serious delay // KNX secure is adding serious delay
updateStatus(ThingStatus.UNKNOWN); updateStatus(ThingStatus.UNKNOWN);
initJob = scheduler.submit(this::initializeLater); initJob = scheduler.submit(this::initializeLater);

2
bundles/org.openhab.binding.knx/src/main/java/org/openhab/binding/knx/internal/i18n/KNXTranslationProvider.java
View File

@ -51,7 +51,7 @@ public enum KNXTranslationProvider {
* *
* @param text text to be translated, may contain placeholders \{n\} for the n-th optional argument of this function * @param text text to be translated, may contain placeholders \{n\} for the n-th optional argument of this function
* @param arguments any optional arguments, will be inserted * @param arguments any optional arguments, will be inserted
* @return translated text with subsitutions if translationprovide is set and provides a translation, otherwise * @return translated text with substitutions if translationProvider is set and provides a translation, otherwise
* returns original text with substitutions * returns original text with substitutions
*/ */
public String get(final String text, @Nullable Object @Nullable... arguments) { public String get(final String text, @Nullable Object @Nullable... arguments) {

2
bundles/org.openhab.binding.knx/src/test/java/org/openhab/binding/knx/internal/i18n/KNXTranslationProviderTest.java
View File

@ -40,7 +40,7 @@ class KNXTranslationProviderTest {
@Test @Test
void testGetBeforeInit() { void testGetBeforeInit() {
// initial state, should not crash and preferrably return original strings (w. pattern substitution) // initial state, should not crash and preferably return original strings (w. pattern substitution)
assertEquals(UNKNOWN, KNXTranslationProvider.I18N.get(UNKNOWN)); assertEquals(UNKNOWN, KNXTranslationProvider.I18N.get(UNKNOWN));
assertEquals(UNKNOWN, KNXTranslationProvider.I18N.get(UNKNOWN, 5)); assertEquals(UNKNOWN, KNXTranslationProvider.I18N.get(UNKNOWN, 5));
assertEquals(UNKNOWN_NULL, KNXTranslationProvider.I18N.get(UNKNOWN_PATTERN, null, null)); assertEquals(UNKNOWN_NULL, KNXTranslationProvider.I18N.get(UNKNOWN_PATTERN, null, null));