From 2939e8b84b6d6ff212ffec6a004e6d682ecc4a8f Mon Sep 17 00:00:00 2001 From: Ethan Dye Date: Wed, 3 Mar 2021 15:04:38 -0700 Subject: [PATCH] [OmniLink] Use jomnilink for command numbers (#10273) Signed-off-by: Ethan Dye --- bundles/org.openhab.binding.omnilink/pom.xml | 2 +- .../internal/handler/AudioZoneHandler.java | 17 +- .../internal/handler/ButtonHandler.java | 3 +- .../internal/handler/ConsoleHandler.java | 7 +- .../handler/HumiditySensorHandler.java | 5 +- .../internal/handler/LockHandler.java | 5 +- .../internal/handler/LuminaAreaHandler.java | 14 +- .../internal/handler/OmniAreaHandler.java | 16 +- .../internal/handler/OmniLinkCmd.java | 199 ------------------ .../handler/OmnilinkBridgeHandler.java | 6 +- .../internal/handler/TempSensorHandler.java | 5 +- .../internal/handler/ThermostatHandler.java | 19 +- .../internal/handler/UnitHandler.java | 8 +- .../internal/handler/ZoneHandler.java | 5 +- .../handler/units/DimmableUnitHandler.java | 11 +- .../internal/handler/units/FlagHandler.java | 6 +- .../handler/units/UpbRoomHandler.java | 12 +- .../units/dimmable/UpbUnitHandler.java | 5 +- 18 files changed, 79 insertions(+), 266 deletions(-) delete mode 100644 bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/OmniLinkCmd.java diff --git a/bundles/org.openhab.binding.omnilink/pom.xml b/bundles/org.openhab.binding.omnilink/pom.xml index 07e400f6c..7b68c65c9 100644 --- a/bundles/org.openhab.binding.omnilink/pom.xml +++ b/bundles/org.openhab.binding.omnilink/pom.xml @@ -18,7 +18,7 @@ com.github.digitaldan jomnilink - 1.4.1 + 1.4.2 compile diff --git a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/AudioZoneHandler.java b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/AudioZoneHandler.java index c3e4f4d11..f80e28da5 100644 --- a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/AudioZoneHandler.java +++ b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/AudioZoneHandler.java @@ -37,6 +37,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import com.digitaldan.jomnilinkII.Message; +import com.digitaldan.jomnilinkII.MessageTypes.CommandMessage; import com.digitaldan.jomnilinkII.MessageTypes.ObjectStatus; import com.digitaldan.jomnilinkII.MessageTypes.properties.AudioZoneProperties; import com.digitaldan.jomnilinkII.MessageTypes.statuses.ExtendedAudioZoneStatus; @@ -97,7 +98,7 @@ public class AudioZoneHandler extends AbstractOmnilinkStatusHandler audioPlayer = bridgeHandler.getAudioPlayer(); if (audioPlayer.isPresent()) { AudioPlayer player = audioPlayer.get(); - sendOmnilinkCommand(OmniLinkCmd.CMD_AUDIO_ZONE_SET_SOURCE.getNumber(), + sendOmnilinkCommand(CommandMessage.CMD_AUDIO_ZONE_SET_SOURCE, PlayPauseType.PLAY.equals(command) ? player.getPlayCommand() : player.getPauseCommand(), thingID); } else { @@ -168,7 +169,7 @@ public class AudioZoneHandler extends AbstractOmnilinkStatusHandler audioPlayer = bridgeHandler.getAudioPlayer(); if (audioPlayer.isPresent()) { AudioPlayer player = audioPlayer.get(); - sendOmnilinkCommand(OmniLinkCmd.CMD_AUDIO_ZONE_SET_SOURCE.getNumber(), + sendOmnilinkCommand(CommandMessage.CMD_AUDIO_ZONE_SET_SOURCE, NextPreviousType.NEXT.equals(command) ? player.getNextCommand() : player.getPreviousCommand(), thingID); } else { diff --git a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ButtonHandler.java b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ButtonHandler.java index a288fa00a..64e47498b 100644 --- a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ButtonHandler.java +++ b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ButtonHandler.java @@ -31,6 +31,7 @@ import org.openhab.core.types.RefreshType; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import com.digitaldan.jomnilinkII.MessageTypes.CommandMessage; import com.digitaldan.jomnilinkII.MessageTypes.properties.AreaProperties; import com.digitaldan.jomnilinkII.MessageTypes.properties.ButtonProperties; @@ -97,7 +98,7 @@ public class ButtonHandler extends AbstractOmnilinkHandler { switch (channelUID.getId()) { case CHANNEL_BUTTON_PRESS: if (command instanceof OnOffType) { - sendOmnilinkCommand(OmniLinkCmd.CMD_BUTTON.getNumber(), 0, thingID); + sendOmnilinkCommand(CommandMessage.CMD_BUTTON, 0, thingID); updateChannels(); } else { logger.debug("Invalid command: {}, must be OnOffType", command); diff --git a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ConsoleHandler.java b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ConsoleHandler.java index 70340edb4..0afb46af4 100644 --- a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ConsoleHandler.java +++ b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ConsoleHandler.java @@ -27,6 +27,8 @@ import org.openhab.core.types.UnDefType; import org.slf4j.Logger; import org.slf4j.LoggerFactory; +import com.digitaldan.jomnilinkII.MessageTypes.CommandMessage; + /** * The {@link ConsoleHandler} defines some methods that are used to * interface with an OmniLink Console. This by extension also defines the @@ -67,7 +69,7 @@ public class ConsoleHandler extends AbstractOmnilinkHandler { switch (channelUID.getId()) { case CHANNEL_CONSOLE_ENABLE_DISABLE_BEEPER: if (command instanceof StringType) { - sendOmnilinkCommand(OmniLinkCmd.CMD_CONSOLE_ENABLE_DISABLE_BEEPER.getNumber(), + sendOmnilinkCommand(CommandMessage.CMD_CONSOLE_ENABLE_DISABLE_BEEPER, ((StringType) command).equals(StringType.valueOf("OFF")) ? 0 : 1, thingID); } else { logger.debug("Invalid command: {}, must be StringType", command); @@ -75,8 +77,7 @@ public class ConsoleHandler extends AbstractOmnilinkHandler { break; case CHANNEL_CONSOLE_BEEP: if (command instanceof DecimalType) { - sendOmnilinkCommand(OmniLinkCmd.CMD_CONSOLE_BEEP.getNumber(), ((DecimalType) command).intValue(), - thingID); + sendOmnilinkCommand(CommandMessage.CMD_CONSOLE_BEEP, ((DecimalType) command).intValue(), thingID); } else { logger.debug("Invalid command: {}, must be DecimalType", command); } diff --git a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/HumiditySensorHandler.java b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/HumiditySensorHandler.java index a0751d68b..002c4dcc8 100644 --- a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/HumiditySensorHandler.java +++ b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/HumiditySensorHandler.java @@ -36,6 +36,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import com.digitaldan.jomnilinkII.Message; +import com.digitaldan.jomnilinkII.MessageTypes.CommandMessage; import com.digitaldan.jomnilinkII.MessageTypes.ObjectStatus; import com.digitaldan.jomnilinkII.MessageTypes.properties.AreaProperties; import com.digitaldan.jomnilinkII.MessageTypes.properties.AuxSensorProperties; @@ -112,12 +113,12 @@ public class HumiditySensorHandler extends AbstractOmnilinkStatusHandler) command).floatValue()), thingID); break; case CHANNEL_AUX_HIGH_SETPOINT: - sendOmnilinkCommand(OmniLinkCmd.CMD_THERMO_SET_COOL_HIGH_POINT.getNumber(), + sendOmnilinkCommand(CommandMessage.CMD_THERMO_SET_COOL_POINT, TemperatureFormat.FAHRENHEIT.formatToOmni(((QuantityType) command).floatValue()), thingID); break; diff --git a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/LockHandler.java b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/LockHandler.java index 7c7ceed68..b2e554c52 100644 --- a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/LockHandler.java +++ b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/LockHandler.java @@ -32,6 +32,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import com.digitaldan.jomnilinkII.Message; +import com.digitaldan.jomnilinkII.MessageTypes.CommandMessage; import com.digitaldan.jomnilinkII.MessageTypes.ObjectStatus; import com.digitaldan.jomnilinkII.MessageTypes.properties.AccessControlReaderProperties; import com.digitaldan.jomnilinkII.MessageTypes.statuses.ExtendedAccessControlReaderLockStatus; @@ -92,8 +93,8 @@ public class LockHandler extends AbstractOmnilinkStatusHandler) command).floatValue()), thingID); break; case CHANNEL_AUX_HIGH_SETPOINT: - sendOmnilinkCommand(OmniLinkCmd.CMD_THERMO_SET_COOL_HIGH_POINT.getNumber(), + sendOmnilinkCommand(CommandMessage.CMD_THERMO_SET_COOL_POINT, temperatureFormat.get().formatToOmni(((QuantityType) command).floatValue()), thingID); break; diff --git a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ThermostatHandler.java b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ThermostatHandler.java index f5daccab3..a66259caf 100644 --- a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ThermostatHandler.java +++ b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ThermostatHandler.java @@ -42,6 +42,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import com.digitaldan.jomnilinkII.Message; +import com.digitaldan.jomnilinkII.MessageTypes.CommandMessage; import com.digitaldan.jomnilinkII.MessageTypes.ObjectStatus; import com.digitaldan.jomnilinkII.MessageTypes.properties.AreaProperties; import com.digitaldan.jomnilinkII.MessageTypes.properties.ThermostatProperties; @@ -144,34 +145,34 @@ public class ThermostatHandler extends AbstractOmnilinkStatusHandler) command).floatValue()), thingID); break; case CHANNEL_THERMO_COOL_SETPOINT: - sendOmnilinkCommand(OmniLinkCmd.CMD_THERMO_SET_COOL_HIGH_POINT.getNumber(), + sendOmnilinkCommand(CommandMessage.CMD_THERMO_SET_COOL_POINT, temperatureFormat.get().formatToOmni(((QuantityType) command).floatValue()), thingID); break; case CHANNEL_THERMO_HUMIDIFY_SETPOINT: - sendOmnilinkCommand(OmniLinkCmd.CMD_THERMO_SET_HUMDIFY_POINT.getNumber(), + sendOmnilinkCommand(CommandMessage.CMD_THERMO_SET_HUMDIFY_POINT, TemperatureFormat.FAHRENHEIT.formatToOmni(((QuantityType) command).floatValue()), thingID); break; case CHANNEL_THERMO_DEHUMIDIFY_SETPOINT: - sendOmnilinkCommand(OmniLinkCmd.CMD_THERMO_SET_DEHUMIDIFY_POINT.getNumber(), + sendOmnilinkCommand(CommandMessage.CMD_THERMO_SET_DEHUMIDIFY_POINT, TemperatureFormat.FAHRENHEIT.formatToOmni(((QuantityType) command).floatValue()), thingID); break; diff --git a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/UnitHandler.java b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/UnitHandler.java index 95951b748..992905118 100644 --- a/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/UnitHandler.java +++ b/bundles/org.openhab.binding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/UnitHandler.java @@ -35,6 +35,7 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; import com.digitaldan.jomnilinkII.Message; +import com.digitaldan.jomnilinkII.MessageTypes.CommandMessage; import com.digitaldan.jomnilinkII.MessageTypes.ObjectStatus; import com.digitaldan.jomnilinkII.MessageTypes.properties.AreaProperties; import com.digitaldan.jomnilinkII.MessageTypes.properties.UnitProperties; @@ -144,15 +145,14 @@ public class UnitHandler extends AbstractOmnilinkStatusHandler