public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[avmfritz] Minor improvements in code an documentation (#9464)

Browse Source 
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
This commit is contained in:
Christoph Weitkamp
2020-12-23 00:30:04 +01:00
committed by GitHub
parent e648fc6c8c
commit 46b02c5b6e
4 changed files with 11 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bundles/org.openhab.binding.avmfritz/src/main/java/org/openhab/binding/avmfritz/internal/AVMFritzTlsTrustManagerProvider.java
View File

@@ -22,7 +22,7 @@ import org.osgi.service.component.annotations.Component;
/**
* Provides a TrustManager to allow secure connections to any FRITZ!Box
*
* @author Chritoph Weitkamp - Initial Contribution
* @author Christoph Weitkamp - Initial Contribution
*/
@Component
@NonNullByDefault

6
bundles/org.openhab.binding.avmfritz/src/main/java/org/openhab/binding/avmfritz/internal/callmonitor/CallMonitor.java
View File

@@ -45,10 +45,10 @@ public class CallMonitor {
private final int MONITOR_PORT = 1012;
private @Nullable CallMonitorThread monitorThread;
private ScheduledFuture<?> reconnectJob;
private final ScheduledFuture<?> reconnectJob;
private String ip;
private BoxHandler handler;
private final String ip;
private final BoxHandler handler;
public CallMonitor(String ip, BoxHandler handler, ScheduledExecutorService scheduler) {
this.ip = ip;

14
bundles/org.openhab.binding.avmfritz/src/main/java/org/openhab/binding/avmfritz/internal/handler/BoxHandler.java
View File

@@ -12,13 +12,13 @@
*/
package org.openhab.binding.avmfritz.internal.handler;
import java.util.HashSet;
import static org.openhab.binding.avmfritz.internal.AVMFritzBindingConstants.*;
import java.util.Set;
import org.eclipse.jdt.annotation.NonNullByDefault;
import org.eclipse.jdt.annotation.Nullable;
import org.eclipse.jetty.client.HttpClient;
import org.openhab.binding.avmfritz.internal.AVMFritzBindingConstants;
import org.openhab.binding.avmfritz.internal.AVMFritzDynamicCommandDescriptionProvider;
import org.openhab.binding.avmfritz.internal.callmonitor.CallMonitor;
import org.openhab.binding.avmfritz.internal.config.AVMFritzBoxConfiguration;
@@ -38,14 +38,8 @@ import org.openhab.core.types.State;
@NonNullByDefault
public class BoxHandler extends AVMFritzBaseBridgeHandler {
protected static final Set<String> CALL_CHANNELS = new HashSet<>();
static {
// TODO: We are still on Java 8 and cannot use Set.of
CALL_CHANNELS.add(AVMFritzBindingConstants.CHANNEL_CALL_ACTIVE);
CALL_CHANNELS.add(AVMFritzBindingConstants.CHANNEL_CALL_INCOMING);
CALL_CHANNELS.add(AVMFritzBindingConstants.CHANNEL_CALL_OUTGOING);
CALL_CHANNELS.add(AVMFritzBindingConstants.CHANNEL_CALL_STATE);
}
private static final Set<String> CALL_CHANNELS = Set.of(CHANNEL_CALL_ACTIVE, CHANNEL_CALL_INCOMING,
CHANNEL_CALL_OUTGOING, CHANNEL_CALL_STATE);
private @Nullable CallMonitor callMonitor;