public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[fmiweather] Fix UNDEF observations in corner case situations. (#11025)

Browse Source 
* [fmiweather] Fix UNDEF observations in corner case situations.

In addition, tests added for static utility functions in
AbstractWeatherHandler.

Resolves #11024.

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
This commit is contained in:
Sami Salonen
2021-07-18 20:10:34 +03:00
committed by GitHub
parent 7cdb41a459
commit 4cf8b1a5ab
2 changed files with 148 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
bundles/org.openhab.binding.fmiweather/src/main/java/org/openhab/binding/fmiweather/internal/AbstractWeatherHandler.java
View File

@@ -165,18 +165,13 @@ public abstract class AbstractWeatherHandler extends BaseThingHandler {
if (data.values.length < 2) {
throw new IllegalStateException("Excepted at least two data items");
}
if (data.values[0] == null) {
return -1;
}
for (int i = 1; i < data.values.length; i++) {
if (data.values[i] == null) {
return i - 1;
for (int i = data.values.length - 1; i >= 0; i--) {
if (data.values[i] != null) {
return i;
}
}
if (data.values[data.values.length - 1] == null) {
return -1;
}
return data.values.length - 1;
// if we have reached here, it means that array was full of nulls
return -1;
}
protected static long floorToEvenMinutes(long epochSeconds, int roundMinutes) {