Fix SAT warnings (#14202)

* Fix SAT warnings

- checkstyle.ModifierOrderCheck
- checkstyle.OneStatementPerLineCheck
- checkstyle.NeedBracesCheck
- PMD.UseStandardCharsets
- PMD.UseCollectionIsEmpty
- PMD.UnusedLocalVariable
- PMD.SimplifyBooleanReturns where reasonable, suppress where
readability is better without change
- PMD.SimplifyBooleanExpressions

* Include StandardCharsets

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
This commit is contained in:
Holger Friedrich
2023-01-13 08:11:06 +01:00
committed by GitHub
parent 6aa0dcbc70
commit 4e44de3894
86 changed files with 148 additions and 157 deletions

View File

@@ -49,13 +49,13 @@ public class KM200SwitchProgramServiceHandler {
protected final Integer MIN_TIME = 0;
protected final Integer MAX_TIME = 1430;
protected final static String TYPE_MONDAY = "Mo";
protected final static String TYPE_TUESDAY = "Tu";
protected final static String TYPE_WEDNESDAY = "We";
protected final static String TYPE_THURSDAY = "Th";
protected final static String TYPE_FRIDAY = "Fr";
protected final static String TYPE_SATURDAY = "Sa";
protected final static String TYPE_SUNDAY = "Su";
protected static final String TYPE_MONDAY = "Mo";
protected static final String TYPE_TUESDAY = "Tu";
protected static final String TYPE_WEDNESDAY = "We";
protected static final String TYPE_THURSDAY = "Th";
protected static final String TYPE_FRIDAY = "Fr";
protected static final String TYPE_SATURDAY = "Sa";
protected static final String TYPE_SUNDAY = "Su";
private String activeDay = TYPE_MONDAY;
private Integer activeCycle = 1;