Fix SAT warnings (#14202)

* Fix SAT warnings

- checkstyle.ModifierOrderCheck
- checkstyle.OneStatementPerLineCheck
- checkstyle.NeedBracesCheck
- PMD.UseStandardCharsets
- PMD.UseCollectionIsEmpty
- PMD.UnusedLocalVariable
- PMD.SimplifyBooleanReturns where reasonable, suppress where
readability is better without change
- PMD.SimplifyBooleanExpressions

* Include StandardCharsets

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
This commit is contained in:
Holger Friedrich
2023-01-13 08:11:06 +01:00
committed by GitHub
parent 6aa0dcbc70
commit 4e44de3894
86 changed files with 148 additions and 157 deletions

View File

@@ -1410,11 +1410,7 @@ public enum HeatpumpChannel {
int code = visiblity.getCode();
if (visibilityValues.length < code || visibilityValues[code] == 1) {
return true;
}
return false;
return (visibilityValues.length < code || visibilityValues[code] == 1);
}
public static HeatpumpChannel fromString(String heatpumpCommand) throws InvalidChannelException {