Fix SAT warnings (#14202)
* Fix SAT warnings - checkstyle.ModifierOrderCheck - checkstyle.OneStatementPerLineCheck - checkstyle.NeedBracesCheck - PMD.UseStandardCharsets - PMD.UseCollectionIsEmpty - PMD.UnusedLocalVariable - PMD.SimplifyBooleanReturns where reasonable, suppress where readability is better without change - PMD.SimplifyBooleanExpressions * Include StandardCharsets Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
This commit is contained in:
@@ -53,5 +53,5 @@ public class TACmiBindingConstants {
|
||||
"schema-state-ro");
|
||||
|
||||
// Channel specific configuration items
|
||||
public final static String CHANNEL_CONFIG_OUTPUT = "output";
|
||||
public static final String CHANNEL_CONFIG_OUTPUT = "output";
|
||||
}
|
||||
|
||||
@@ -86,6 +86,7 @@ public final class DigitalMessage extends Message {
|
||||
* @param portNumber - the portNumber in Range 1-32
|
||||
* @return
|
||||
*/
|
||||
@SuppressWarnings("PMD.SimplifyBooleanReturns")
|
||||
@Override
|
||||
public boolean hasPortnumber(int portNumber) {
|
||||
if (podNumber == 0 && portNumber <= 16) {
|
||||
|
||||
Reference in New Issue
Block a user