public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[danfossairunit] Try to make tests more stable (#9473)

Browse Source 
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
This commit is contained in:
Fabian Wolter 2020-12-22 20:31:04 +01:00 committed by GitHub
parent 4f7ac4ea30
commit 54ca612630
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
bundles/org.openhab.binding.danfossairunit/src/test/java/org/openhab/binding/danfossairunit/internal/ValueCacheTest.java
View File

@ -17,12 +17,13 @@ import static org.junit.jupiter.api.Assertions.*;
import org.eclipse.jdt.annotation.NonNullByDefault; import org.eclipse.jdt.annotation.NonNullByDefault;
import org.junit.jupiter.api.Test; import org.junit.jupiter.api.Test;
import org.openhab.core.library.types.OnOffType; import org.openhab.core.library.types.OnOffType;
import org.openhab.core.test.java.JavaTest;
/** /**
* @author Robert Bach - Initial contribution * @author Robert Bach - Initial contribution
*/ */
@NonNullByDefault @NonNullByDefault
public class ValueCacheTest { public class ValueCacheTest extends JavaTest {
@Test @Test
public void updateValueNotInCache() { public void updateValueNotInCache() {
@ -45,20 +46,17 @@ public class ValueCacheTest {
} }
@Test @Test
public void updateValueInCacheUnchangedButCacheDurationExpired() throws InterruptedException { public void updateValueInCacheUnchangedButCacheDurationExpired() {
ValueCache valueCache = new ValueCache(1); ValueCache valueCache = new ValueCache(1);
assertTrue(valueCache.updateValue("channel", OnOffType.ON)); assertTrue(valueCache.updateValue("channel", OnOffType.ON));
Thread.sleep(2); waitForAssert(() -> assertTrue(valueCache.updateValue("channel", OnOffType.ON)));
assertTrue(valueCache.updateValue("channel", OnOffType.ON));
} }
@Test @Test
public void updateValueMultipleCacheUpdatesButNotReportedAsToUpdate() throws InterruptedException { public void updateValueMultipleCacheUpdatesButNotReportedAsToUpdate() {
ValueCache valueCache = new ValueCache(60); ValueCache valueCache = new ValueCache(100);
assertTrue(valueCache.updateValue("channel", OnOffType.ON));
Thread.sleep(30);
assertFalse(valueCache.updateValue("channel", OnOffType.ON));
Thread.sleep(35);
assertTrue(valueCache.updateValue("channel", OnOffType.ON)); assertTrue(valueCache.updateValue("channel", OnOffType.ON));
waitForAssert(() -> assertFalse(valueCache.updateValue("channel", OnOffType.ON)));
waitForAssert(() -> assertTrue(valueCache.updateValue("channel", OnOffType.ON)));
} }
} }