From 705f6e84eedfc96b56c9ec4727b7df5b4ebadbab Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christian=20Jonak-M=C3=B6chel?= <christian@jonak.org>
Date: Sat, 22 Apr 2023 21:52:16 +0200
Subject: [PATCH] [robonect] improve jobType config (#14868)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Add allowed pattern to description
* Increase allowed duration to 12h - thats what the web gui allows

Signed-off-by: Christian Jonak-Möchel <christian@jonak.org>
---
 .../main/resources/OH-INF/config/config.xml   | 19 ++++++++++++++++---
 .../resources/OH-INF/i18n/robonect.properties |  6 ++++++
 2 files changed, 22 insertions(+), 3 deletions(-)

diff --git a/bundles/org.openhab.binding.robonect/src/main/resources/OH-INF/config/config.xml b/bundles/org.openhab.binding.robonect/src/main/resources/OH-INF/config/config.xml
index 9905cf2c6..06620f9da 100644
--- a/bundles/org.openhab.binding.robonect/src/main/resources/OH-INF/config/config.xml
+++ b/bundles/org.openhab.binding.robonect/src/main/resources/OH-INF/config/config.xml
@@ -6,19 +6,32 @@
 	https://openhab.org/schemas/config-description-1.0.0.xsd">
 
 	<config-description uri="channel-type:robonect:jobType">
-		<parameter name="remoteStart" type="text" pattern="^STANDARD|REMOTE_1|REMOTE_2$">
+		<parameter name="remoteStart" type="text">
 			<label>Remote Start</label>
 			<description>The location to start the mowing job from.</description>
+			<options>
+				<option value="STANDARD">Standard</option>
+				<option value="REMOTE_1">Remote 1</option>
+				<option value="REMOTE_2">Remote 2</option>
+			</options>
+
 		</parameter>
-		<parameter name="duration" type="integer" min="0" max="60" unit="m">
+		<parameter name="duration" type="integer" min="0" max="720" unit="m">
 			<context>time</context>
 			<label>Job Duration</label>
 			<description>The duration of the job.</description>
 			<default>0</default>
+
 		</parameter>
-		<parameter name="afterMode" type="text" pattern="^AUTO|HOME|EOD$">
+		<parameter name="afterMode" type="text">
 			<label>After Job Mode</label>
 			<description>The Mode to put the mower into after the job is done.</description>
+			<options>
+				<option value="AUTO">Auto</option>
+				<option value="HOME">Home</option>
+				<option value="EOD">End of day</option>
+			</options>
+
 		</parameter>
 	</config-description>
 
diff --git a/bundles/org.openhab.binding.robonect/src/main/resources/OH-INF/i18n/robonect.properties b/bundles/org.openhab.binding.robonect/src/main/resources/OH-INF/i18n/robonect.properties
index 533ba3abd..0c482600c 100644
--- a/bundles/org.openhab.binding.robonect/src/main/resources/OH-INF/i18n/robonect.properties
+++ b/bundles/org.openhab.binding.robonect/src/main/resources/OH-INF/i18n/robonect.properties
@@ -89,7 +89,13 @@ channel-type.robonect.versionType.label = Robonect Version
 
 channel-type.config.robonect.jobType.afterMode.label = After Job Mode
 channel-type.config.robonect.jobType.afterMode.description = The Mode to put the mower into after the job is done.
+channel-type.config.robonect.jobType.afterMode.option.AUTO = Auto
+channel-type.config.robonect.jobType.afterMode.option.HOME = Home
+channel-type.config.robonect.jobType.afterMode.option.EOD = End of day
 channel-type.config.robonect.jobType.duration.label = Job Duration
 channel-type.config.robonect.jobType.duration.description = The duration of the job.
 channel-type.config.robonect.jobType.remoteStart.label = Remote Start
 channel-type.config.robonect.jobType.remoteStart.description = The location to start the mowing job from.
+channel-type.config.robonect.jobType.remoteStart.option.STANDARD = Standard
+channel-type.config.robonect.jobType.remoteStart.option.REMOTE_1 = Remote 1
+channel-type.config.robonect.jobType.remoteStart.option.REMOTE_2 = Remote 2