public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redundant modifiers from interfaces (#14843)

Browse Source 
Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2023-04-18 13:07:04 +02:00
committed by GitHub
parent 24adc5aa12
commit 83cbe746d0
174 changed files with 806 additions and 774 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
bundles/org.openhab.binding.deutschebahn/src/main/java/org/openhab/binding/deutschebahn/internal/AttributeSelection.java
View File

@@ -31,17 +31,17 @@ public interface AttributeSelection {
* Returns the value for this attribute.
*/
@Nullable
public abstract Object getValue(TimetableStop stop);
Object getValue(TimetableStop stop);
/**
* Returns the {@link State} that should be set for the channels'value for this attribute.
*/
@Nullable
public abstract State getState(TimetableStop stop);
State getState(TimetableStop stop);
/**
* Returns a list of values as string list.
* Returns empty list if value is not present, singleton list if attribute is not single-valued.
*/
public abstract List<String> getStringValues(TimetableStop t);
List<String> getStringValues(TimetableStop t);
}

10
bundles/org.openhab.binding.deutschebahn/src/main/java/org/openhab/binding/deutschebahn/internal/filter/FilterTokenVisitor.java
View File

@@ -27,25 +27,25 @@ public interface FilterTokenVisitor<R> {
/**
* Handles {@link ChannelNameEquals}.
*/
public abstract R handle(ChannelNameEquals equals) throws FilterParserException;
R handle(ChannelNameEquals equals) throws FilterParserException;
/**
* Handles {@link OrOperator}.
*/
public abstract R handle(OrOperator operator) throws FilterParserException;
R handle(OrOperator operator) throws FilterParserException;
/**
* Handles {@link AndOperator}.
*/
public abstract R handle(AndOperator operator) throws FilterParserException;
R handle(AndOperator operator) throws FilterParserException;
/**
* Handles {@link BracketOpenToken}.
*/
public abstract R handle(BracketOpenToken token) throws FilterParserException;
R handle(BracketOpenToken token) throws FilterParserException;
/**
* Handles {@link BracketCloseToken}.
*/
public abstract R handle(BracketCloseToken token) throws FilterParserException;
R handle(BracketCloseToken token) throws FilterParserException;
}

6
bundles/org.openhab.binding.deutschebahn/src/main/java/org/openhab/binding/deutschebahn/internal/timetable/TimetablesV1Api.java
View File

@@ -51,7 +51,7 @@ public interface TimetablesV1Api {
*
* @return The {@link Timetable} containing the planned arrivals and departues.
*/
public abstract Timetable getPlan(String evaNo, Date time) throws IOException;
Timetable getPlan(String evaNo, Date time) throws IOException;
/**
* Requests all known changes in the timetable for the given station.
@@ -75,7 +75,7 @@ public interface TimetablesV1Api {
*
* @return The {@link Timetable} containing all known changes for the given station.
*/
public abstract Timetable getFullChanges(String evaNo) throws IOException;
Timetable getFullChanges(String evaNo) throws IOException;
/**
* Requests the timetable with the planned data for the given station and time.
@@ -97,5 +97,5 @@ public interface TimetablesV1Api {
*
* @return The {@link Timetable} containing recent changes (from last two minutes) for the given station.
*/
public abstract Timetable getRecentChanges(String evaNo) throws IOException;
Timetable getRecentChanges(String evaNo) throws IOException;
}

4
bundles/org.openhab.binding.deutschebahn/src/main/java/org/openhab/binding/deutschebahn/internal/timetable/TimetablesV1ApiFactory.java
View File

@@ -28,6 +28,6 @@ public interface TimetablesV1ApiFactory {
/**
* Creates a new instance of the {@link TimetablesV1Api}.
*/
public abstract TimetablesV1Api create(final String clientId, final String clientSecret,
final HttpCallable httpCallable) throws JAXBException;
TimetablesV1Api create(final String clientId, final String clientSecret, final HttpCallable httpCallable)
throws JAXBException;
}

12
bundles/org.openhab.binding.deutschebahn/src/test/java/org/openhab/binding/deutschebahn/internal/timetable/TimetablesV1ImplTestHelper.java
View File

@@ -27,16 +27,16 @@ import org.eclipse.jdt.annotation.NonNullByDefault;
@NonNullByDefault
public interface TimetablesV1ImplTestHelper {
public static final String EVA_LEHRTE = "8000226";
public static final String EVA_HANNOVER_HBF = "8000152";
public static final String CLIENT_ID = "bdwrpmxuo6157jrekftlbcc6ju9awo";
public static final String CLIENT_SECRET = "354c8161cd7fb0936c840240280c131e";
static final String EVA_LEHRTE = "8000226";
static final String EVA_HANNOVER_HBF = "8000152";
static final String CLIENT_ID = "bdwrpmxuo6157jrekftlbcc6ju9awo";
static final String CLIENT_SECRET = "354c8161cd7fb0936c840240280c131e";
/**
* Creates a {@link TimetablesApiTestModule} that uses http response data from file system.
* Uses default-testdata from directory /timetablesData
*/
public default TimetablesApiTestModule createApiWithTestdata() throws Exception {
default TimetablesApiTestModule createApiWithTestdata() throws Exception {
return this.createApiWithTestdata("/timetablesData");
}
@@ -45,7 +45,7 @@ public interface TimetablesV1ImplTestHelper {
*
* @param dataDirectory Directory within test-resources containing the stub-data.
*/
public default TimetablesApiTestModule createApiWithTestdata(String dataDirectory) throws Exception {
default TimetablesApiTestModule createApiWithTestdata(String dataDirectory) throws Exception {
final URL timetablesData = getClass().getResource(dataDirectory);
assertNotNull(timetablesData);
final File testDataDir = new File(timetablesData.toURI());