public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove redundant modifiers from interfaces (#14843)

Browse Source 
Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2023-04-18 13:07:04 +02:00
committed by GitHub
parent 24adc5aa12
commit 83cbe746d0
174 changed files with 806 additions and 774 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
bundles/org.openhab.binding.pioneeravr/src/main/java/org/openhab/binding/pioneeravr/internal/protocol/avr/AvrCommand.java
View File

@@ -22,7 +22,7 @@ public interface AvrCommand {
/**
* Represent a CommandType of command requests
*/
public interface CommandType {
interface CommandType {
/**
* Return the command of this command type.
*
@@ -52,19 +52,19 @@ public interface AvrCommand {
*
* @return
*/
public String getCommand();
String getCommand();
/**
* Return the number of the zone this command will be sent to.
*
* @return
*/
public int getZone();
int getZone();
/**
* Return the the command type of this command.
*
* @return
*/
public CommandType getCommandType();
CommandType getCommandType();
}

36
bundles/org.openhab.binding.pioneeravr/src/main/java/org/openhab/binding/pioneeravr/internal/protocol/avr/AvrConnection.java
View File

@@ -29,32 +29,32 @@ public interface AvrConnection {
*
* @param listener
*/
public void addUpdateListener(AvrUpdateListener listener);
void addUpdateListener(AvrUpdateListener listener);
/**
* Add a disconnection listener. It is notified when the AVR is disconnected.
*
* @param listener
*/
public void addDisconnectionListener(AvrDisconnectionListener listener);
void addDisconnectionListener(AvrDisconnectionListener listener);
/**
* Connect to the receiver. Return true if the connection has succeeded or if already connected.
*
**/
public boolean connect();
boolean connect();
/**
* Return true if this manager is connected to the AVR.
*
* @return
*/
public boolean isConnected();
boolean isConnected();
/**
* Closes the connection.
**/
public void close();
void close();
/**
* Send a power state query to the AVR
@@ -62,7 +62,7 @@ public interface AvrConnection {
* @param zone
* @return
*/
public boolean sendPowerQuery(int zone);
boolean sendPowerQuery(int zone);
/**
* Send a volume level query to the AVR
@@ -70,7 +70,7 @@ public interface AvrConnection {
* @param zone
* @return
*/
public boolean sendVolumeQuery(int zone);
boolean sendVolumeQuery(int zone);
/**
* Send a mute state query to the AVR
@@ -78,7 +78,7 @@ public interface AvrConnection {
* @param zone
* @return
*/
public boolean sendMuteQuery(int zone);
boolean sendMuteQuery(int zone);
/**
* Send a source input state query to the AVR
@@ -86,7 +86,7 @@ public interface AvrConnection {
* @param zone
* @return
*/
public boolean sendInputSourceQuery(int zone);
boolean sendInputSourceQuery(int zone);
/**
* Send a listening mode state query to the AVR
@@ -94,14 +94,14 @@ public interface AvrConnection {
* @param zone
* @return
*/
public boolean sendListeningModeQuery(int zone);
boolean sendListeningModeQuery(int zone);
/**
* Send an MCACC Memory query to the AVR
*
* @return
*/
public boolean sendMCACCMemoryQuery();
boolean sendMCACCMemoryQuery();
/**
* Send a power command ot the AVR based on the openHAB command
@@ -110,7 +110,7 @@ public interface AvrConnection {
* @param zone
* @return
*/
public boolean sendPowerCommand(Command command, int zone) throws CommandTypeNotSupportedException;
boolean sendPowerCommand(Command command, int zone) throws CommandTypeNotSupportedException;
/**
* Send a volume command to the AVR based on the openHAB command
@@ -119,7 +119,7 @@ public interface AvrConnection {
* @param zone
* @return
*/
public boolean sendVolumeCommand(Command command, int zone) throws CommandTypeNotSupportedException;
boolean sendVolumeCommand(Command command, int zone) throws CommandTypeNotSupportedException;
/**
* Send a source input selection command to the AVR based on the openHAB command
@@ -128,7 +128,7 @@ public interface AvrConnection {
* @param zone
* @return
*/
public boolean sendInputSourceCommand(Command command, int zone) throws CommandTypeNotSupportedException;
boolean sendInputSourceCommand(Command command, int zone) throws CommandTypeNotSupportedException;
/**
* Send a listening mode selection command to the AVR based on the openHAB command
@@ -137,7 +137,7 @@ public interface AvrConnection {
* @param zone
* @return
*/
public boolean sendListeningModeCommand(Command command, int zone) throws CommandTypeNotSupportedException;
boolean sendListeningModeCommand(Command command, int zone) throws CommandTypeNotSupportedException;
/**
* Send a mute command to the AVR based on the openHAB command
@@ -146,7 +146,7 @@ public interface AvrConnection {
* @param zone
* @return
*/
public boolean sendMuteCommand(Command command, int zone) throws CommandTypeNotSupportedException;
boolean sendMuteCommand(Command command, int zone) throws CommandTypeNotSupportedException;
/**
* Send an MCACC Memory selection command to the AVR based on the openHAB command
@@ -155,12 +155,12 @@ public interface AvrConnection {
* @param zone
* @return
*/
public boolean sendMCACCMemoryCommand(Command command) throws CommandTypeNotSupportedException;
boolean sendMCACCMemoryCommand(Command command) throws CommandTypeNotSupportedException;
/**
* Return the connection name
*
* @return
*/
public String getConnectionName();
String getConnectionName();
}

10
bundles/org.openhab.binding.pioneeravr/src/main/java/org/openhab/binding/pioneeravr/internal/protocol/avr/AvrResponse.java
View File

@@ -25,7 +25,7 @@ public interface AvrResponse {
/**
* Represent the type of a response.
*/
public interface AvrResponseType {
interface AvrResponseType {
/**
* Return the prefix of the command of this type.
@@ -73,26 +73,26 @@ public interface AvrResponse {
*
* @return
*/
public ResponseType getResponseType();
ResponseType getResponseType();
/**
* Return the parameter of this response or null if the resposne has no parameter.
*
* @return
*/
public String getParameterValue();
String getParameterValue();
/**
* Return true if this response has a parameter.
*
* @return
*/
public boolean hasParameter();
boolean hasParameter();
/**
* Return the zone number which is concerned by this response.
*
* @return
*/
public Integer getZone();
Integer getZone();
}

2
bundles/org.openhab.binding.pioneeravr/src/main/java/org/openhab/binding/pioneeravr/internal/protocol/event/AvrDisconnectionListener.java
View File

@@ -24,5 +24,5 @@ public interface AvrDisconnectionListener {
*
* @param event
*/
public void onDisconnection(AvrDisconnectionEvent event);
void onDisconnection(AvrDisconnectionEvent event);
}

2
bundles/org.openhab.binding.pioneeravr/src/main/java/org/openhab/binding/pioneeravr/internal/protocol/event/AvrUpdateListener.java
View File

@@ -27,5 +27,5 @@ public interface AvrUpdateListener extends EventListener {
/**
* Procedure for receive status update from Pioneer receiver.
*/
public void statusUpdateReceived(AvrStatusUpdateEvent event);
void statusUpdateReceived(AvrStatusUpdateEvent event);
}

4
bundles/org.openhab.binding.pioneeravr/src/main/java/org/openhab/binding/pioneeravr/internal/protocol/states/MuteStateValues.java
View File

@@ -18,6 +18,6 @@ package org.openhab.binding.pioneeravr.internal.protocol.states;
*/
public interface MuteStateValues {
public static final String ON_VALUE = "0";
public static final String OFF_VALUE = "1";
static final String ON_VALUE = "0";
static final String OFF_VALUE = "1";
}

6
bundles/org.openhab.binding.pioneeravr/src/main/java/org/openhab/binding/pioneeravr/internal/protocol/states/PowerStateValues.java
View File

@@ -18,7 +18,7 @@ package org.openhab.binding.pioneeravr.internal.protocol.states;
*/
public interface PowerStateValues {
public static final String ON_VALUE = "0";
public static final String OFF_VALUE = "1";
public static final String NETWORK_STANDBY_VALUE = "2";
static final String ON_VALUE = "0";
static final String OFF_VALUE = "1";
static final String NETWORK_STANDBY_VALUE = "2";
}