public
/
openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[lcn] add workaround for dynamic text firmware bug (#9232) 

Some LCN-GTxD don't display the text if it fits exactly in one chunk (12 bytes). Observed with GT10D 8.0.

Closes #9208

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
This commit is contained in:
Fabian Wolter 2020-12-05 06:22:47 +01:00 committed by GitHub
parent f9866b2c77
commit 86bd264cb9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
bundles/org.openhab.binding.lcn/src/main/java/org/openhab/binding/lcn/internal/LcnModuleActions.java
View File

@ -125,6 +125,11 @@ public class LcnModuleActions implements ThingActions {
text = new String(); text = new String();
} }
// some LCN-GTxD don't display the text if it fits exactly in one chunk. Observed with GT10D 8.0.
if (text.getBytes(LcnDefs.LCN_ENCODING).length % DYN_TEXT_CHUNK_LENGTH == 0) {
text += " ";
}
// convert String to bytes to split the data every 12 bytes, because a unicode character can take more than // convert String to bytes to split the data every 12 bytes, because a unicode character can take more than
// one byte // one byte
ByteBuffer bb = ByteBuffer.wrap(text.getBytes(LcnDefs.LCN_ENCODING)); ByteBuffer bb = ByteBuffer.wrap(text.getBytes(LcnDefs.LCN_ENCODING));

5
bundles/org.openhab.binding.lcn/src/test/java/org/openhab/binding/lcn/internal/ModuleActionsTest.java
View File

@ -63,7 +63,10 @@ public class ModuleActionsTest {
public void testSendDynamicText1ChunkRow1() throws LcnException { public void testSendDynamicText1ChunkRow1() throws LcnException {
a.sendDynamicText(1, "abcdfghijklm"); a.sendDynamicText(1, "abcdfghijklm");
verify(handler).sendPck(stringToByteBuffer("GTDT11abcdfghijklm")); verify(handler, times(2)).sendPck(byteBufferCaptor.capture());
assertThat(byteBufferCaptor.getAllValues(), contains(stringToByteBuffer("GTDT11abcdfghijklm"),
stringToByteBuffer("GTDT12 \0\0\0\0\0\0\0\0\0\0\0")));
} }
@Test @Test