public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Rework ThingActions (#8755)

Browse Source 
* Remove duplication by making use of default Java generated exceptions
* Make ThingActions labels/descriptions more consistent

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2020-10-15 10:53:53 +02:00
committed by GitHub
parent aef1d10f40
commit 978e122e00
40 changed files with 305 additions and 785 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
bundles/org.openhab.binding.satel/src/main/java/org/openhab/binding/satel/internal/action/SatelEventLogActions.java
View File

@@ -71,11 +71,7 @@ public class SatelEventLogActions implements ThingActions {
return result;
}
public static Map<String, Object> readEvent(@Nullable ThingActions actions, @Nullable Number index) {
if (actions instanceof SatelEventLogActions) {
return ((SatelEventLogActions) actions).readEvent(index);
} else {
throw new IllegalArgumentException("Actions is not an instance of SatelEventLogActions");
}
public static Map<String, Object> readEvent(ThingActions actions, @Nullable Number index) {
return ((SatelEventLogActions) actions).readEvent(index);
}
}

2
bundles/org.openhab.binding.satel/src/main/resources/OH-INF/i18n/satel.properties
View File

@@ -3,7 +3,7 @@ config-status.hostEmpty = Host name or IP of ETHM-1 must be provided.
config-status.portEmpty = Serial port of INT-RS must be provided.
# actions
actionReadEventLabel = Read event
actionReadEventLabel = read an event
actionReadEventDesc = Reads a single record from the event log.
actionInputIndexLabel = Event index
actionInputIndexDesc = Index of the event to read