Java 17 features (N-S) (#15565)

- add missing @override
- Java style array syntax
- remove redundant modifiers
- always move String constants to left side in comparisons
- simplify lambda expressions and return statements
- use replace instead of replaceAll w/o regex
- instanceof matching and multiline strings

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>

bundles/org.openhab.binding.robonect/src/main/java/org/openhab/binding/robonect/internal/handler/RobonectHandler.java

@@ -107,8 +107,8 @@ public class RobonectHandler extends BaseThingHandler {
     private void sendCommand(ChannelUID channelUID, Command command) {
         switch (channelUID.getId()) {
             case CHANNEL_MOWER_NAME:
-                if (command instanceof StringType) {
-                    updateName((StringType) command);
+                if (command instanceof StringType stringCommand) {
+                    updateName(stringCommand);
                 } else {
                     logger.debug("Got name update of type {} but StringType is expected.",
                             command.getClass().getName());
@@ -125,8 +125,8 @@ public class RobonectHandler extends BaseThingHandler {
                 break;
 
             case CHANNEL_MOWER_START:
-                if (command instanceof OnOffType) {
-                    handleStartStop((OnOffType) command);
+                if (command instanceof OnOffType onOffCommand) {
+                    handleStartStop(onOffCommand);
                 } else {
                     logger.debug("Got stopped update of type {} but OnOffType is expected.",
                             command.getClass().getName());

bundles/org.openhab.binding.robonect/src/test/java/org/openhab/binding/robonect/internal/model/ModelParserTest.java

@@ -183,14 +183,40 @@ public class ModelParserTest {
 
     @Test
     public void shouldParseVersionInfoV1betaToNA() {
-        String versionResponse = "{\n" + "mower: {\n" + "hardware: {\n" + "serial: 170602001,\n"
-                + "production: \"2017-02-07 15:12:00\"\n" + "},\n" + "msw: {\n" + "title: \"420\",\n"
-                + "version: \"7.10.00\",\n" + "compiled: \"2016-11-29 08:44:06\"\n" + "},\n" + "sub: {\n"
-                + "version: \"6.01.00\"\n" + "}\n" + "},\n" + "serial: \"05D80037-39355548-43163930\",\n"
-                + "bootloader: {\n" + "version: \"V0.4\",\n" + "compiled: \"2016-10-22 01:12:00\",\n"
-                + "comment: \"\"\n" + "},\n" + "wlan: {\n" + "at-version: \"V1.4.0\",\n" + "sdk-version: \"V2.1.0\"\n"
-                + "},\n" + "application: {\n" + "version: \"V1.0\",\n" + "compiled: \"2018-03-12 21:01:00\",\n"
-                + "comment: \"Release V1.0 Beta2\"\n" + "},\n" + "successful: true\n" + "}";
+        String versionResponse = """
+                {
+                mower: {
+                hardware: {
+                serial: 170602001,
+                production: "2017-02-07 15:12:00"
+                },
+                msw: {
+                title: "420",
+                version: "7.10.00",
+                compiled: "2016-11-29 08:44:06"
+                },
+                sub: {
+                version: "6.01.00"
+                }
+                },
+                serial: "05D80037-39355548-43163930",
+                bootloader: {
+                version: "V0.4",
+                compiled: "2016-10-22 01:12:00",
+                comment: ""
+                },
+                wlan: {
+                at-version: "V1.4.0",
+                sdk-version: "V2.1.0"
+                },
+                application: {
+                version: "V1.0",
+                compiled: "2018-03-12 21:01:00",
+                comment: "Release V1.0 Beta2"
+                },
+                successful: true
+                }\
+                """;
         VersionInfo versionInfo = subject.parse(versionResponse, VersionInfo.class);
         assertTrue(versionInfo.isSuccessful());
         assertEquals("n/a", versionInfo.getRobonect().getSerial());