diff --git a/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/discovery/ThingDiscoveryService.java b/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/discovery/ThingDiscoveryService.java index 3e3bd8dba..6c92cb518 100644 --- a/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/discovery/ThingDiscoveryService.java +++ b/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/discovery/ThingDiscoveryService.java @@ -237,6 +237,14 @@ public class ThingDiscoveryService extends AbstractDiscoveryService implements D return; } ThingTypeUID thingTypeUID; + + Map properties = new HashMap<>(); + properties.put(CONFIG_ID, sensorID); + properties.put(UNIQUE_ID, sensor.uniqueid); + properties.put(Thing.PROPERTY_FIRMWARE_VERSION, sensor.swversion); + properties.put(Thing.PROPERTY_VENDOR, sensor.manufacturername); + properties.put(Thing.PROPERTY_MODEL_ID, sensor.modelid); + if (sensor.type.contains("Daylight")) { // deCONZ specific: Software simulated daylight sensor thingTypeUID = THING_TYPE_DAYLIGHT_SENSOR; } else if (sensor.type.contains("Power")) { // ZHAPower, CLIPPower @@ -281,8 +289,8 @@ public class ThingDiscoveryService extends AbstractDiscoveryService implements D ThingUID uid = new ThingUID(thingTypeUID, bridgeUID, sensor.uniqueid.replaceAll("[^a-z0-9\\[\\]]", "")); DiscoveryResult discoveryResult = DiscoveryResultBuilder.create(uid).withBridge(bridgeUID) - .withLabel(sensor.name + " (" + sensor.manufacturername + ")").withProperty(CONFIG_ID, sensorID) - .withProperty(UNIQUE_ID, sensor.uniqueid).withRepresentationProperty(UNIQUE_ID).build(); + .withLabel(sensor.name + " (" + sensor.manufacturername + ")").withProperties(properties) + .withRepresentationProperty(UNIQUE_ID).build(); thingDiscovered(discoveryResult); } diff --git a/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/handler/SensorBaseThingHandler.java b/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/handler/SensorBaseThingHandler.java index b5891dbfe..14400945c 100644 --- a/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/handler/SensorBaseThingHandler.java +++ b/bundles/org.openhab.binding.deconz/src/main/java/org/openhab/binding/deconz/internal/handler/SensorBaseThingHandler.java @@ -127,9 +127,10 @@ public abstract class SensorBaseThingHandler extends DeconzBaseThingHandler { } Map editProperties = editProperties(); - editProperties.put(Thing.PROPERTY_FIRMWARE_VERSION, sensorMessage.swversion); - editProperties.put(Thing.PROPERTY_MODEL_ID, sensorMessage.modelid); editProperties.put(UNIQUE_ID, sensorMessage.uniqueid); + editProperties.put(Thing.PROPERTY_FIRMWARE_VERSION, sensorMessage.swversion); + editProperties.put(Thing.PROPERTY_VENDOR, sensorMessage.manufacturername); + editProperties.put(Thing.PROPERTY_MODEL_ID, sensorMessage.modelid); ignoreConfigurationUpdate = true; updateProperties(editProperties); diff --git a/bundles/org.openhab.binding.deconz/src/main/resources/OH-INF/thing/sensor-thing-types.xml b/bundles/org.openhab.binding.deconz/src/main/resources/OH-INF/thing/sensor-thing-types.xml index bd00412d9..a991e3657 100644 --- a/bundles/org.openhab.binding.deconz/src/main/resources/OH-INF/thing/sensor-thing-types.xml +++ b/bundles/org.openhab.binding.deconz/src/main/resources/OH-INF/thing/sensor-thing-types.xml @@ -11,7 +11,7 @@ A Presence sensor - + @@ -20,13 +20,6 @@ - - Switch - - Presence detected - - - DateTime @@ -469,7 +462,7 @@ A battery sensor - + @@ -478,13 +471,6 @@ - - Number - - The battery state. - - -