public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[infrastructure] move infered nullness warnings to error and update EEA (#8949)

Browse Source 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
This commit is contained in:
J-N-K
2020-11-12 21:07:11 +01:00
committed by GitHub
parent 0856a0b3f2
commit ba4c96d99d
155 changed files with 644 additions and 632 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
bundles/org.openhab.binding.luftdateninfo/src/main/java/org/openhab/binding/luftdateninfo/internal/handler/HTTPHandler.java
View File

@@ -14,6 +14,7 @@ package org.openhab.binding.luftdateninfo.internal.handler;
import java.time.LocalDateTime;
import java.util.List;
import java.util.Objects;
import java.util.concurrent.TimeUnit;
import org.eclipse.jdt.annotation.NonNullByDefault;
@@ -82,7 +83,7 @@ public class HTTPHandler {
} else {
failure = result.getFailure().getMessage();
}
callback.onError(failure);
callback.onError(Objects.requireNonNullElse(failure, "Unknown error"));
} else {
callback.onResponse(getContentAsString());
}

4
bundles/org.openhab.binding.luftdateninfo/src/test/java/org/openhab/binding/luftdateninfo/internal/HTTPHandlerEvalTest.java
View File

@@ -15,6 +15,7 @@ package org.openhab.binding.luftdateninfo.internal;
import static org.junit.jupiter.api.Assertions.*;
import java.util.List;
import java.util.Objects;
import org.eclipse.jdt.annotation.NonNullByDefault;
import org.eclipse.jdt.annotation.Nullable;
@@ -41,14 +42,17 @@ public class HTTPHandlerEvalTest {
public void setUp() {
String conditionsStr = FileReader.readFileInString("src/test/resources/condition-result-no-pressure.json");
assertNotNull(conditionsStr);
Objects.requireNonNull(conditionsStr);
conditions = http.getLatestValues(conditionsStr);
String particulateStr = FileReader.readFileInString("src/test/resources/pm-result.json");
assertNotNull(particulateStr);
Objects.requireNonNull(particulateStr);
particulate = http.getLatestValues(particulateStr);
String noiseStr = FileReader.readFileInString("src/test/resources/noise-result.json");
assertNotNull(noiseStr);
Objects.requireNonNull(noiseStr);
noise = http.getLatestValues(noiseStr);
}

5
bundles/org.openhab.binding.luftdateninfo/src/test/java/org/openhab/binding/luftdateninfo/internal/HTTPHandlerValueTest.java
View File

@@ -15,6 +15,7 @@ package org.openhab.binding.luftdateninfo.internal;
import static org.junit.jupiter.api.Assertions.*;
import java.util.List;
import java.util.Objects;
import org.eclipse.jdt.annotation.NonNullByDefault;
import org.junit.jupiter.api.Test;
@@ -39,8 +40,10 @@ public class HTTPHandlerValueTest {
public void testValueDecoding() {
String resource1 = FileReader.readFileInString("src/test/resources/condition-result-no-pressure.json");
assertNotNull(resource1);
Objects.requireNonNull(resource1);
List<SensorDataValue> l = http.getLatestValues(resource1);
assertNotNull(l);
Objects.requireNonNull(l);
l.forEach(sd -> {
testSensorValue(sd);
});
@@ -48,8 +51,10 @@ public class HTTPHandlerValueTest {
String resource2 = FileReader
.readFileInString("src/test/resources/condition-result-no-pressure-flipped-values.json");
assertNotNull(resource2);
Objects.requireNonNull(resource2);
l = http.getLatestValues(resource2);
assertNotNull(l);
Objects.requireNonNull(l);
l.forEach(sd -> {
testSensorValue(sd);
});