public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[infrastructure] move infered nullness warnings to error and update EEA (#8949)

Browse Source 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
This commit is contained in:
J-N-K
2020-11-12 21:07:11 +01:00
committed by GitHub
parent 0856a0b3f2
commit ba4c96d99d
155 changed files with 644 additions and 632 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
bundles/org.openhab.binding.onebusaway/src/main/java/org/openhab/binding/onebusaway/internal/handler/StopHandler.java
View File

@@ -119,17 +119,16 @@ public class StopHandler extends BaseBridgeHandler {
if (listener == null) {
throw new IllegalArgumentException("It makes no sense to register a null listener!");
}
boolean added = routeDataListeners.add(listener);
if (added) {
String routeId = listener.getRouteId();
List<ObaStopArrivalResponse.ArrivalAndDeparture> copiedRouteData;
synchronized (routeData) {
copiedRouteData = new ArrayList<>(routeData.get(routeId));
}
Collections.sort(copiedRouteData);
listener.onNewRouteData(routeDataLastUpdateMs, copiedRouteData);
routeDataListeners.add(listener);
String routeId = listener.getRouteId();
List<ObaStopArrivalResponse.ArrivalAndDeparture> copiedRouteData;
synchronized (routeData) {
copiedRouteData = new ArrayList<>(routeData.getOrDefault(routeId, List.of()));
}
return added;
Collections.sort(copiedRouteData);
listener.onNewRouteData(routeDataLastUpdateMs, copiedRouteData);
return true;
}
/**
@@ -212,7 +211,8 @@ public class StopHandler extends BaseBridgeHandler {
routeData.put(d.routeId, Arrays.asList(d));
}
for (String key : routeData.keySet()) {
List<ObaStopArrivalResponse.ArrivalAndDeparture> copy = new ArrayList<>(routeData.get(key));
List<ObaStopArrivalResponse.ArrivalAndDeparture> copy = new ArrayList<>(
routeData.getOrDefault(key, List.of()));
Collections.sort(copy);
copiedRouteData.put(key, copy);
}