public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[intesis] Fixed error channels not being updated (#8863)

Browse Source 
Signed-off-by: Hans-Jörg Merk <github@hmerk.de>
This commit is contained in:
Hans-Jörg Merk 2020-10-26 12:53:57 +01:00 committed by GitHub
parent c7b86c09d9
commit ba5488f040
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 26 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
bundles/org.openhab.binding.intesis/README.md
View File

@ -68,14 +68,17 @@ Thing intesis:intesisBox:acOffice "AC Unit Adapter" @ "AC" [ipAddress="192.168.
**Items** **Items**
```intesishome.items ```intesishome.items
Switch ac "Power" { channel="intesis:intesisHome:acOffice:power" } Switch ac "Power" { channel="intesis:intesisHome:acOffice:power" }
String acMode "Mode" { channel="intesis:intesisHome:acOffice:mode" } String acMode "Mode" { channel="intesis:intesisHome:acOffice:mode" }
String acFanSpeed "Fan Speed" <fan> { channel="intesis:intesisHome:acOffice:fanSpeed" } String acFanSpeed "Fan Speed" <fan> { channel="intesis:intesisHome:acOffice:fanSpeed" }
String acVanesUpDown "Vanes Up/Ddown Position" { channel="intesis:intesisHome:acOffice:vanesUpDown" } String acVanesUpDown "Vanes Up/Ddown Position" { channel="intesis:intesisHome:acOffice:vanesUpDown" }
String acVanesLeftRight "Vanes Left/Right Position" { channel="intesis:intesisHome:acOffice:vanesLeftRight" } String acVanesLeftRight "Vanes Left/Right Position" { channel="intesis:intesisHome:acOffice:vanesLeftRight" }
Number:Temperature acSetPoint "Target Temperature" <heating> { channel="intesis:intesisHome:acOffice:targetTemperature" } Number:Temperature acSetPoint "Target Temperature" <heating> { channel="intesis:intesisHome:acOffice:targetTemperature" }
Number:Temperature acAmbientTemp "Ambient Temperature" <temperature> { channel="intesis:intesisHome:acOffice:ambientTemperature" } Number:Temperature acAmbientTemp "Ambient Temperature" <temperature> { channel="intesis:intesisHome:acOffice:ambientTemperature" }
Number:Temperature acOutdoorTemp "Outdoor Temperature" <temperature> { channel="intesis:intesisHome:acOffice:outdoorTemperature" } Number:Temperature acOutdoorTemp "Outdoor Temperature" <temperature> { channel="intesis:intesisHome:acOffice:outdoorTemperature" }
String acErrorStatus "Errorstatus" { channel="intesis:intesisBox:acOffice:errorStatus" }
String acErrorCode "Errorcode" { channel="intesis:intesisBox:acOffice:errorCode" }
String acWifiSignal "Wifi Signal Quality" <qualityofservice> { channel="intesis:intesisBox:acOffice:wifiSignal" }
``` ```
**Sitemap** **Sitemap**
@ -85,13 +88,17 @@ sitemap intesishome label="My AC control" {
Frame label="Climate" { Frame label="Climate" {
Switch item=ac Switch item=ac
Switch item=acMode icon="heating" mappings=[AUTO="Auto", HEAT="Heat", DRY="Dry", FAN="Fan", COOL="Cool"] Switch item=acMode icon="heating" mappings=[AUTO="Auto", HEAT="Heat", DRY="Dry", FAN="Fan", COOL="Cool"]
Switch item=acFanSpeed icon="qualityofservice" mappings=[AUTO="Auto", 1="Low", 2="Med", 3="MedHigh", 4="High"] Switch item=acFanSpeed icon="qualityofservice" mappings=[AUTO="Auto", 1="Low", 2="Med", 3="MedHigh", 4="High"]
Switch item=acVanesUpDown icon="movecontrol" mappings=[AUTO="Stop", 1="1", 2="2", 3="3", 4="4", 5="5", SWING="Swing"] Switch item=acVanesUpDown icon="movecontrol" mappings=[AUTO="Stop", 1="1", 2="2", 3="3", 4="4", 5="5", SWING="Swing"]
Switch item=acVanesLeftRight icon="movecontrol" mappings=[AUTO="Stop", 1="1", 2="2", 3="3", 4="4", 5="5", SWING="Swing"] Switch item=acVanesLeftRight icon="movecontrol" mappings=[AUTO="Stop", 1="1", 2="2", 3="3", 4="4", 5="5", SWING="Swing"]
Setpoint item=acSetPoint icon="temperature" minValue=16 maxValue=28 step=1 Setpoint item=acSetPoint icon="temperature" minValue=16 maxValue=28 step=1
Text item=acAmbientTemp icon="temperature" Text item=acAmbientTemp icon="temperature"
Text item=acOutdoorTemp icon="temperature" Text item=acOutdoorTemp icon="temperature"
Text item=acErrorStatus
Text item=acErrorCode
Text item=acWifiSignal icon="qualityofservice"
} }
} }
``` ```

6
bundles/org.openhab.binding.intesis/src/main/java/org/openhab/binding/intesis/internal/handler/IntesisBoxHandler.java
View File

@ -263,12 +263,10 @@ public class IntesisBoxHandler extends BaseThingHandler implements IntesisBoxCha
updateState(CHANNEL_TYPE_VANESLR, new StringType(value)); updateState(CHANNEL_TYPE_VANESLR, new StringType(value));
break; break;
case "ERRCODE": case "ERRCODE":
properties.put("errorCode", value); updateState(CHANNEL_TYPE_ERRORCODE, new StringType(value));
updateProperties(properties);
break; break;
case "ERRSTATUS": case "ERRSTATUS":
properties.put("errorStatus", value); updateState(CHANNEL_TYPE_ERRORSTATUS, new StringType(value));
updateProperties(properties);
if ("ERR".equals(value)) { if ("ERR".equals(value)) {
updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR, updateStatus(ThingStatus.OFFLINE, ThingStatusDetail.COMMUNICATION_ERROR,
"device reported an error"); "device reported an error");

2
bundles/org.openhab.binding.intesis/src/main/resources/OH-INF/thing/thing-types.xml
View File

@ -59,12 +59,14 @@
<item-type>String</item-type> <item-type>String</item-type>
<label>@text/channel-type.intesis.errorCode.label</label> <label>@text/channel-type.intesis.errorCode.label</label>
<description>@text/channel-type.intesis.errorCode.description</description> <description>@text/channel-type.intesis.errorCode.description</description>
<state readOnly="true"></state>
</channel-type> </channel-type>
<channel-type id="errorStatus"> <channel-type id="errorStatus">
<item-type>String</item-type> <item-type>String</item-type>
<label>@text/channel-type.intesis.errorStatus.label</label> <label>@text/channel-type.intesis.errorStatus.label</label>
<description>@text/channel-type.intesis.errorStatus.description</description> <description>@text/channel-type.intesis.errorStatus.description</description>
<state readOnly="true"></state>
</channel-type> </channel-type>
</thing:thing-descriptions> </thing:thing-descriptions>