public
/
openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[fineoffsetweatherstation] Fix java.lang.IllegalMonitorStateException (#14326) 

This fix ensures, that the `ReentrantLock::unlock` method is only called, when the Thread is owning the lock.

resolves: #14322

Signed-off-by: Andreas Berger <andreas@berger-freelancer.com>
This commit is contained in:
Andreas Berger 2023-02-04 18:03:14 +01:00 committed by GitHub
parent fc57f02fca
commit bd6fe9008a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
bundles/org.openhab.binding.fineoffsetweatherstation/src/main/java/org/openhab/binding/fineoffsetweatherstation/internal/service/GatewayQueryService.java
View File

@ -73,14 +73,20 @@ public abstract class GatewayQueryService implements AutoCloseable {
protected byte @Nullable [] executeCommand(String command, byte[] request, protected byte @Nullable [] executeCommand(String command, byte[] request,
Function<byte[], Boolean> validateResponse) { Function<byte[], Boolean> validateResponse) {
try {
if (!REQUEST_LOCK.tryLock(30, TimeUnit.SECONDS)) {
logger.debug("executeCommand({}): timed out while getting the lock", command);
return null;
}
} catch (InterruptedException e) {
logger.debug("executeCommand({}): was interrupted while getting the lock", command);
return null;
}
byte[] buffer = new byte[2028]; byte[] buffer = new byte[2028];
int bytesRead; int bytesRead;
try { try {
if (!REQUEST_LOCK.tryLock(30, TimeUnit.SECONDS)) {
logger.trace("executeCommand({}): time out while getting lock", command);
return null;
}
Socket socket = getConnection(); Socket socket = getConnection();
if (socket == null) { if (socket == null) {
return null; return null;