public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Renamed channel manual_fan_speed to manual_fan_step for consistency. (#11147)

Browse Source 
Fixes #10621

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
This commit is contained in:
jlaur
2021-08-24 18:59:35 +02:00
committed by GitHub
parent 5cb228570d
commit be17654767
4 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
bundles/org.openhab.binding.danfossairunit/src/main/java/org/openhab/binding/danfossairunit/internal/Channel.java
View File

@@ -28,8 +28,11 @@ public enum Channel {
CHANNEL_CURRENT_TIME("current_time", ChannelGroup.MAIN, DanfossAirUnit::getCurrentTime),
CHANNEL_MODE("mode", ChannelGroup.MAIN, DanfossAirUnit::getMode, DanfossAirUnit::setMode),
CHANNEL_MANUAL_FAN_SPEED("manual_fan_speed", ChannelGroup.MAIN, DanfossAirUnit::getManualFanSpeed,
DanfossAirUnit::setManualFanSpeed),
// Backwards compatibility as channel was renamed from manual_fan_speed to manual_fan_step.
CHANNEL_MANUAL_FAN_SPEED("manual_fan_speed", ChannelGroup.MAIN, DanfossAirUnit::getManualFanStep,
DanfossAirUnit::setManualFanStep),
CHANNEL_MANUAL_FAN_STEP("manual_fan_step", ChannelGroup.MAIN, DanfossAirUnit::getManualFanStep,
DanfossAirUnit::setManualFanStep),
CHANNEL_EXTRACT_FAN_SPEED("extract_fan_speed", ChannelGroup.MAIN, DanfossAirUnit::getExtractFanSpeed),
CHANNEL_SUPPLY_FAN_SPEED("supply_fan_speed", ChannelGroup.MAIN, DanfossAirUnit::getSupplyFanSpeed),
CHANNEL_EXTRACT_FAN_STEP("extract_fan_step", ChannelGroup.MAIN, DanfossAirUnit::getExtractFanStep),

4
bundles/org.openhab.binding.danfossairunit/src/main/java/org/openhab/binding/danfossairunit/internal/DanfossAirUnit.java
View File

@@ -161,7 +161,7 @@ public class DanfossAirUnit {
return new StringType(Mode.values()[getByte(REGISTER_1_READ, MODE)].name());
}
public PercentType getManualFanSpeed() throws IOException {
public PercentType getManualFanStep() throws IOException {
return new PercentType(BigDecimal.valueOf(getByte(REGISTER_1_READ, MANUAL_FAN_SPEED_STEP) * 10));
}
@@ -242,7 +242,7 @@ public class DanfossAirUnit {
return new DateTimeType(timestamp);
}
public PercentType setManualFanSpeed(Command cmd) throws IOException {
public PercentType setManualFanStep(Command cmd) throws IOException {
return setPercentTypeRegister(cmd, MANUAL_FAN_SPEED_STEP);
}

14
bundles/org.openhab.binding.danfossairunit/src/main/resources/OH-INF/thing/thing-types.xml
View File

@@ -48,6 +48,7 @@
<channels>
<channel id="current_time" typeId="currentTime"/>
<channel id="mode" typeId="mode"/>
<channel id="manual_fan_step" typeId="manualFanStep"/>
<channel id="manual_fan_speed" typeId="manualFanSpeed"/>
<channel id="supply_fan_speed" typeId="supplyFanSpeed"/>
<channel id="extract_fan_speed" typeId="extractFanSpeed"/>
@@ -85,7 +86,7 @@
<label>Humidity</label>
<channels>
<channel id="humidity" typeId="humidity">
<description>Current relative humidity measured by the unit</description>
<description>Current relative humidity measured by the air unit</description>
</channel>
</channels>
</channel-group-type>
@@ -147,10 +148,17 @@
</options>
</state>
</channel-type>
<channel-type id="manualFanSpeed">
<channel-type id="manualFanStep">
<item-type>Dimmer</item-type>
<label>Manual Fan Step</label>
<description>Controls 10-step setting of the fan when operation mode is manual</description>
<category>Fan</category>
<state step="10" min="0" max="100"/>
</channel-type>
<channel-type id="manualFanSpeed" advanced="true">
<item-type>Dimmer</item-type>
<label>Manual Fan Speed</label>
<description>Controls 10-step setting of the fan when operation mode is manual</description>
<description>Deprecated, please use Manual Fan Step instead. This channel will be removed in a later version.</description>
<category>Fan</category>
<state step="10" min="0" max="100"/>
</channel-type>