From cb13ec6f1a424d1ce0cd86458443e2577dd16f77 Mon Sep 17 00:00:00 2001 From: Andrew Fiddian-Green Date: Fri, 12 Nov 2021 00:23:25 +0000 Subject: [PATCH] [hdpowerview] Secondary shade position was inverted (#11552) * [hdpowerview] get secondary shade position value was inverted Signed-off-by: Andrew Fiddian-Green * [hdpowerview] remove testing Jar from PR Signed-off-by: Andrew Fiddian-Green --- .../openhab/binding/hdpowerview/internal/api/ShadePosition.java | 2 +- .../org/openhab/binding/hdpowerview/HDPowerViewJUnitTests.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/api/ShadePosition.java b/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/api/ShadePosition.java index a61d04c37..c7e5f0477 100644 --- a/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/api/ShadePosition.java +++ b/bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/api/ShadePosition.java @@ -236,7 +236,7 @@ public class ShadePosition { * Uses a coordinate system that is NOT inverted in relation to OpenHAB */ if (posKind2.intValue() != 3) { - return new PercentType(100 - (int) Math.round(position2.doubleValue() / MAX_SHADE * 100)); + return new PercentType((int) Math.round(position2.doubleValue() / MAX_SHADE * 100)); } default: return UnDefType.UNDEF; diff --git a/bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/HDPowerViewJUnitTests.java b/bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/HDPowerViewJUnitTests.java index 46240065f..14eb6c0aa 100644 --- a/bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/HDPowerViewJUnitTests.java +++ b/bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/HDPowerViewJUnitTests.java @@ -351,7 +351,7 @@ public class HDPowerViewJUnitTests { pos = shadePos.getState(SECONDARY_ACTUATOR, ZERO_IS_OPEN); assertEquals(PercentType.class, pos.getClass()); - assertEquals(65, ((PercentType) pos).intValue()); + assertEquals(35, ((PercentType) pos).intValue()); pos = shadePos.getState(PRIMARY_ACTUATOR, VANE_COORDS); assertEquals(UnDefType.class, pos.getClass());