public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[MQTT.Homeassistant] process errors in MQTT message handlers during components discovery (#11315)

Browse Source 
Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com>
This commit is contained in:
antroids
2021-10-24 11:51:48 +02:00
committed by GitHub
parent 196e4e2210
commit ce61044329
11 changed files with 199 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
bundles/org.openhab.binding.mqtt.homeassistant/src/test/java/org/openhab/binding/mqtt/homeassistant/internal/handler/HomeAssistantThingHandlerTests.java
View File

@@ -22,6 +22,7 @@ import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import java.nio.charset.StandardCharsets;
import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors;
@@ -152,4 +153,34 @@ public class HomeAssistantThingHandlerTests extends AbstractHomeAssistantTests {
// Expect channel group types removed, 1 for each component
verify(channelTypeProvider, times(2)).removeChannelGroupType(any());
}
@Test
public void testProcessMessageFromUnsupportedComponent() {
thingHandler.initialize();
thingHandler.discoverComponents.processMessage("homeassistant/unsupportedType/id_zigbee2mqtt/config",
"{}".getBytes(StandardCharsets.UTF_8));
// Ignore unsupported component
thingHandler.delayedProcessing.forceProcessNow();
assertThat(haThing.getChannels().size(), CoreMatchers.is(0));
}
@Test
public void testProcessMessageWithEmptyConfig() {
thingHandler.initialize();
thingHandler.discoverComponents.processMessage("homeassistant/sensor/id_zigbee2mqtt/config",
"".getBytes(StandardCharsets.UTF_8));
// Ignore component with empty config
thingHandler.delayedProcessing.forceProcessNow();
assertThat(haThing.getChannels().size(), CoreMatchers.is(0));
}
@Test
public void testProcessMessageWithBadFormatConfig() {
thingHandler.initialize();
thingHandler.discoverComponents.processMessage("homeassistant/sensor/id_zigbee2mqtt/config",
"{bad format}}".getBytes(StandardCharsets.UTF_8));
// Ignore component with bad format config
thingHandler.delayedProcessing.forceProcessNow();
assertThat(haThing.getChannels().size(), CoreMatchers.is(0));
}
}