From d1634fbc181a93d6d0fb79aa774341d08a898390 Mon Sep 17 00:00:00 2001
From: Holger Friedrich <holgerfriedrich@users.noreply.github.com>
Date: Tue, 3 Jan 2023 08:47:51 +0100
Subject: [PATCH] [ism8] Fix SAT warnings (#14141)

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
---
 .../java/org/openhab/binding/ism8/server/DataPointBool.java | 2 +-
 .../org/openhab/binding/ism8/server/DataPointLongValue.java | 2 +-
 .../org/openhab/binding/ism8/server/DataPointValue.java     | 6 +++---
 .../java/org/openhab/binding/ism8/server/KnxNetFrame.java   | 4 ++--
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointBool.java b/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointBool.java
index 9cb197a0f..5e25cf9ef 100644
--- a/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointBool.java
+++ b/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointBool.java
@@ -55,7 +55,7 @@ public class DataPointBool extends DataPointBase<@Nullable Boolean> {
     @Override
     protected byte[] convertWriteValue(Object value) {
         String valueText = value.toString().toLowerCase();
-        if (valueText.equalsIgnoreCase("true") || valueText.equalsIgnoreCase("1")) {
+        if ("true".equalsIgnoreCase(valueText) || "1".equalsIgnoreCase(valueText)) {
             this.setValue(true);
             return new byte[] { 0x01 };
         }
diff --git a/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointLongValue.java b/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointLongValue.java
index 08ecf9e69..7a677efef 100644
--- a/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointLongValue.java
+++ b/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointLongValue.java
@@ -33,7 +33,7 @@ public class DataPointLongValue extends DataPointBase<@Nullable Double> {
     public DataPointLongValue(int id, String knxDataType, String description) {
         super(id, knxDataType, description);
 
-        if (knxDataType.equals("13.002")) {
+        if ("13.002".equals(knxDataType)) {
             this.setUnit("m³/h");
             this.factor = 0.0001f;
             this.outputFormat = "%.1f";
diff --git a/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointValue.java b/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointValue.java
index 03cc7f84b..d279df78a 100644
--- a/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointValue.java
+++ b/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/DataPointValue.java
@@ -33,15 +33,15 @@ public class DataPointValue extends DataPointBase<@Nullable Double> {
     public DataPointValue(int id, String knxDataType, String description) {
         super(id, knxDataType, description);
         this.factor = 0.0f;
-        if (knxDataType.equals("9.001")) {
+        if ("9.001".equals(knxDataType)) {
             this.setUnit("°C");
             this.factor = 0.01f;
             this.outputFormat = "%.1f";
-        } else if (knxDataType.equals("9.002")) {
+        } else if ("9.002".equals(knxDataType)) {
             this.setUnit("°K");
             this.factor = 0.01f;
             this.outputFormat = "%.1f";
-        } else if (knxDataType.equals("9.006")) {
+        } else if ("9.006".equals(knxDataType)) {
             this.setUnit("Bar");
             this.factor = 0.0000001f;
             this.outputFormat = "%.2f";
diff --git a/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/KnxNetFrame.java b/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/KnxNetFrame.java
index 5cb7ca6aa..7c362aec6 100644
--- a/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/KnxNetFrame.java
+++ b/bundles/org.openhab.binding.ism8/src/main/java/org/openhab/binding/ism8/server/KnxNetFrame.java
@@ -27,8 +27,8 @@ import org.slf4j.LoggerFactory;
  */
 @NonNullByDefault
 public class KnxNetFrame {
-    public static byte[] KNX_HEADER = new byte[6];
-    public static byte[] CONNECTION_HEADER = new byte[4];
+    public static final byte[] KNX_HEADER = new byte[6];
+    public static final byte[] CONNECTION_HEADER = new byte[4];
 
     private static final Logger LOGGER = LoggerFactory.getLogger(KnxNetFrame.class);
     private ArrayList<SetDatapointValueMessage> valueMessages = new ArrayList<SetDatapointValueMessage>();