From d83c32cd2437836fabf1345bc44322202d7fc8aa Mon Sep 17 00:00:00 2001 From: Cody Cutrer Date: Mon, 10 Oct 2022 05:30:13 -0600 Subject: [PATCH] [homekit] allow configuring maxValue on VOCDensity (#13508) * [homekit] allow configuring maxValue on VOCDensity the default of 1000 is quite low in reality. tested and confirmed working with iOS 16 * [homekit] allow step value to be configured for VOCDensity Signed-off-by: Cody Cutrer --- bundles/org.openhab.io.homekit/README.md | 2 +- .../internal/accessories/HomekitCharacteristicFactory.java | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/bundles/org.openhab.io.homekit/README.md b/bundles/org.openhab.io.homekit/README.md index e0b11932c..d952d023d 100644 --- a/bundles/org.openhab.io.homekit/README.md +++ b/bundles/org.openhab.io.homekit/README.md @@ -550,7 +550,7 @@ Support for this is planned for the future release of openHAB HomeKit binding. | | | SulphurDioxideDensity | Number | SO2 density in micrograms/m3, max 1000 | | | | PM25Density | Number | PM2.5 micrometer particulate density in micrograms/m3, max 1000 | | | | PM10Density | Number | PM10 micrometer particulate density in micrograms/m3, max 1000 | -| | | VOCDensity | Number | VOC Density in micrograms/m3, max 1000 | +| | | VOCDensity | Number | VOC Density in micrograms/m3, default max 1000, supported configuration: minValue, maxValue, step. | | | | Name | String | Name of the sensor | | | | ActiveStatus | Switch, Contact | Working status | | | | FaultStatus | Switch, Contact | Fault status | diff --git a/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/accessories/HomekitCharacteristicFactory.java b/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/accessories/HomekitCharacteristicFactory.java index 611b7f33e..9180cc7cc 100644 --- a/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/accessories/HomekitCharacteristicFactory.java +++ b/bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/accessories/HomekitCharacteristicFactory.java @@ -811,6 +811,11 @@ public class HomekitCharacteristicFactory { private static VOCDensityCharacteristic createVOCDensityCharacteristic(final HomekitTaggedItem taggedItem, HomekitAccessoryUpdater updater) { return new VOCDensityCharacteristic( + taggedItem.getConfigurationAsDouble(HomekitTaggedItem.MIN_VALUE, + VOCDensityCharacteristic.DEFAULT_MIN_VALUE), + taggedItem.getConfigurationAsDouble(HomekitTaggedItem.MAX_VALUE, + VOCDensityCharacteristic.DEFAULT_MAX_VALUE), + taggedItem.getConfigurationAsDouble(HomekitTaggedItem.STEP, VOCDensityCharacteristic.DEFAULT_STEP), getDoubleSupplier(taggedItem, taggedItem.getConfigurationAsDouble(HomekitTaggedItem.MIN_VALUE, VOCDensityCharacteristic.DEFAULT_MIN_VALUE)),