From dd951cee02a1e5922d00c659e9fea0693bb90be6 Mon Sep 17 00:00:00 2001 From: Matthew Skinner Date: Tue, 21 Dec 2021 04:59:06 +1100 Subject: [PATCH] Fix Global OFF not turning lights/segments off. (#11806) Signed-off-by: Matthew Skinner --- .../org/openhab/binding/wled/internal/api/WledApiV084.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bundles/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/api/WledApiV084.java b/bundles/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/api/WledApiV084.java index 4d3245af4..270940544 100644 --- a/bundles/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/api/WledApiV084.java +++ b/bundles/org.openhab.binding.wled/src/main/java/org/openhab/binding/wled/internal/api/WledApiV084.java @@ -284,8 +284,8 @@ public class WledApiV084 implements WledApi { handler.update(CHANNEL_THIRD_WHITE, WLedHelper .parseWhitePercent(state.stateResponse.seg[handler.config.segmentIndex].col[2].toString())); } - - if (!state.stateResponse.seg[handler.config.segmentIndex].on) { + // Global OFF or Segment OFF needs to be treated as OFF + if (!state.stateResponse.seg[handler.config.segmentIndex].on || !state.stateResponse.on) { handler.update(CHANNEL_MASTER_CONTROLS, OnOffType.OFF); handler.update(CHANNEL_SEGMENT_BRIGHTNESS, OnOffType.OFF); } else {