From e3a659e8d382c77aedd5e035ec286a91ce3b5337 Mon Sep 17 00:00:00 2001 From: J-N-K Date: Mon, 7 Dec 2020 21:05:11 +0100 Subject: [PATCH] [amazonechocontrol] improve logging (#9241) Signed-off-by: Jan N. Klug --- .../amazonechocontrol/internal/Connection.java | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/bundles/org.openhab.binding.amazonechocontrol/src/main/java/org/openhab/binding/amazonechocontrol/internal/Connection.java b/bundles/org.openhab.binding.amazonechocontrol/src/main/java/org/openhab/binding/amazonechocontrol/internal/Connection.java index e7287194e..587a89fec 100644 --- a/bundles/org.openhab.binding.amazonechocontrol/src/main/java/org/openhab/binding/amazonechocontrol/internal/Connection.java +++ b/bundles/org.openhab.binding.amazonechocontrol/src/main/java/org/openhab/binding/amazonechocontrol/internal/Connection.java @@ -50,6 +50,8 @@ import java.util.concurrent.locks.Lock; import java.util.concurrent.locks.ReentrantLock; import java.util.regex.Matcher; import java.util.regex.Pattern; +import java.util.stream.Collectors; +import java.util.stream.StreamSupport; import java.util.zip.GZIPInputStream; import javax.net.ssl.HttpsURLConnection; @@ -1191,25 +1193,21 @@ public class Connection { String requestBody = json.toString(); try { String resultBody = makeRequestAndReturnString("PUT", url, requestBody, true, null); - logger.debug("{}", resultBody); + logger.trace("Request '{}' resulted in '{}", requestBody, resultBody); JsonObject result = parseJson(resultBody, JsonObject.class); if (result != null) { JsonElement errors = result.get("errors"); if (errors != null && errors.isJsonArray()) { JsonArray errorList = errors.getAsJsonArray(); if (errorList.size() > 0) { - logger.info("Smart home device command failed."); - logger.info("Request:"); - logger.info("{}", requestBody); - logger.info("Answer:"); - for (JsonElement error : errorList) { - logger.info("{}", error.toString()); - } + logger.warn("Smart home device command failed. The request '{}' resulted in error(s): {}", + requestBody, StreamSupport.stream(errorList.spliterator(), false) + .map(JsonElement::toString).collect(Collectors.joining(" / "))); } } } } catch (URISyntaxException e) { - logger.info("Wrong url {}", url, e); + logger.warn("URL '{}' has invalid format for request '{}': {}", url, requestBody, e.getMessage()); } }