public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix or suppress SAT CompareObjectsWithEquals findings (#10631)

Browse Source 
* Fix or suppress SAT CompareObjectsWithEquals findings

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2021-05-05 21:06:04 +02:00
committed by GitHub
parent 582ef280e5
commit f5f922eaf4
14 changed files with 34 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
bundles/org.openhab.binding.atlona/src/main/java/org/openhab/binding/atlona/internal/StatefulHandlerCallback.java
View File

@@ -13,6 +13,7 @@
package org.openhab.binding.atlona.internal;
import java.util.Map;
import java.util.Objects;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;
@@ -93,13 +94,8 @@ public class StatefulHandlerCallback implements AtlonaHandlerCallback {
final State oldState = this.state.get(channelId);
// If both null OR the same value (enums), nothing changed
if (oldState == state) {
return;
}
// If they are equal - nothing changed
if (oldState != null && oldState.equals(state)) {
if (Objects.equals(oldState, state)) {
return;
}