public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[caddx] Fix wrongly handled discovery, off by 1 errors (#9030)

Browse Source 
* Corrected caddx discovery bug
* Maintenance

- Changed refresh logic for the things
- Code cleanup
- Corrected off by one errors
- Added initial tests for the message parsing
* Corrected ParameterizedTest
* Changed new Date().getTime to System.currentTimeMillis()

Signed-off-by: Georgios Moutsos <georgios.moutsos@gmail.com>
This commit is contained in:
Georgios Moutsos
2020-11-19 04:10:09 +02:00
committed by GitHub
parent 6e3c640043
commit fa21dff364
13 changed files with 191 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
bundles/org.openhab.binding.caddx/README.md
View File

@@ -67,6 +67,7 @@ The following table shows the available configuration parameters for each thing.
| bridge | `serialPort` - Serial port for the bridge - Required |
| | `protocol` - Protocol used for the communication (Binary, Ascii) - Required - Default = Binary |
| | `baud` - Baud rate of the bridge - Required - Default = 9600 |
| | `maxZoneNumber` - Maximum zone number to be added during discovery - Required - Default = 16 |
| partition | `partitionNumber` - Partition number (1-8) - Required |
| zone | `zoneNumber` - Zone number (1-192) - Required |
| keypad | `keypadAddress` - Keypad address (192-255) - Required |
@@ -219,7 +220,7 @@ Caddx Alarm things support a variety of channels as seen below in the following
The following is an example of a things file (caddx.things):
```
Bridge caddx:bridge:thebridge "Bridge" [ protocol="Binary", serialPort="/dev/ttyUSB0", baudrate=38400 ] {
Bridge caddx:bridge:thebridge "Bridge" [ protocol="Binary", serialPort="/dev/ttyUSB0", baud=38400, maxZoneNumber=18 ] {
Thing partition partition1 "Groundfloor alarm" [ partitionNumber=1 ]
Thing zone zone1 "Livingroom motion sensor" [ zoneNumber=1 ]
Thing zone zone2 "Bedroom motion sensor" [ zoneNumber=2 ]