public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add support for group item type to window covering (#10936)

Browse Source 
Add support for setting TARGET_POSITION of Window Covering accessories from groups with a baseItem type

Closes #10812

Signed-off-by: Colin Keehan <github@colin.xyz>
This commit is contained in:
Colin 2021-07-17 01:51:44 -05:00 committed by GitHub
parent b96bab46d7
commit ff617aceae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/accessories/AbstractHomekitPositionAccessoryImpl.java
View File

@ -24,6 +24,7 @@ import java.util.concurrent.CompletableFuture;
import org.eclipse.jdt.annotation.NonNullByDefault; import org.eclipse.jdt.annotation.NonNullByDefault;
import org.eclipse.jdt.annotation.Nullable; import org.eclipse.jdt.annotation.Nullable;
import org.openhab.core.items.GroupItem;
import org.openhab.core.items.Item; import org.openhab.core.items.Item;
import org.openhab.core.library.items.DimmerItem; import org.openhab.core.library.items.DimmerItem;
import org.openhab.core.library.items.NumberItem; import org.openhab.core.library.items.NumberItem;
@ -84,12 +85,19 @@ abstract class AbstractHomekitPositionAccessoryImpl extends AbstractHomekitAcces
getCharacteristic(TARGET_POSITION).ifPresentOrElse(taggedItem -> { getCharacteristic(TARGET_POSITION).ifPresentOrElse(taggedItem -> {
final Item item = taggedItem.getItem(); final Item item = taggedItem.getItem();
final int targetPosition = convertPosition(value, openPosition); final int targetPosition = convertPosition(value, openPosition);
if (item instanceof RollershutterItem) { if (item instanceof RollershutterItem) {
((RollershutterItem) item).send(new PercentType(targetPosition)); ((RollershutterItem) item).send(new PercentType(targetPosition));
} else if (item instanceof DimmerItem) { } else if (item instanceof DimmerItem) {
((DimmerItem) item).send(new PercentType(targetPosition)); ((DimmerItem) item).send(new PercentType(targetPosition));
} else if (item instanceof NumberItem) { } else if (item instanceof NumberItem) {
((NumberItem) item).send(new DecimalType(targetPosition)); ((NumberItem) item).send(new DecimalType(targetPosition));
} else if (item instanceof GroupItem && ((GroupItem) item).getBaseItem() instanceof RollershutterItem) {
((GroupItem) item).send(new PercentType(targetPosition));
} else if (item instanceof GroupItem && ((GroupItem) item).getBaseItem() instanceof DimmerItem) {
((GroupItem) item).send(new PercentType(targetPosition));
} else if (item instanceof GroupItem && ((GroupItem) item).getBaseItem() instanceof NumberItem) {
((GroupItem) item).send(new DecimalType(targetPosition));
} else { } else {
logger.warn( logger.warn(
"Unsupported item type for characteristic {} at accessory {}. Expected Rollershutter, Dimmer or Number item, got {}", "Unsupported item type for characteristic {} at accessory {}. Expected Rollershutter, Dimmer or Number item, got {}",