* [dsmr] Improved error handling to better handle corrupt messages.
- Fix incorrect additional key in bridge discovery service.
- When corrupted P1 telegram is received don't set directly to offline, but let the watchdog do this if to many times this happens.
This makes it a bit more lenient for receiving a bad telegram once in a while. Because some connections are not that stable.
- Simplified error handling, and listeners to one enum/interface to make it more cleaner.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Subchannels were created by appending the key. However this was done inside a loop and if multiple updates were needed they would be appended to the channel name, instead of taking the channel name each time.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* Fix fix for channel id detection, Added missing channels to emucs electra
- M-bus channels are dynamic and present in the obis id.
The binding had most channel types fixed because most of the time these channels are the same.
However the device identifier is the same for multiple devices.
But the binding only registered only one and while the channel id was derived from this obis data.
For detected meters this resulted in the channel id to be the same if there are multiple devices.
This change looks at the channel id to assign it to the found device.
This is a bit tricky because the general device has no channel and has channels that have different id's.
So the binding needs to cover that case.
This change also adds some optional channels to the emucs electra meter.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Add support for Austrian meters
Improved the work done in pr #11193
Also-by: Thomas <thomas@knaller.info>
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Added Null handling annotations.
* Switch properties files encoding from ISO-8859-1 to UTF-8
Crowdin will generate translations in this encoding, so this prevents a lot of diffs which makes it easier to review future Crowdin PRs.
Related to openhab/openhab-core#2298
Signed-off-by: Wouter Born <github@maindrain.net>
This simplifies the DSMRHandlerFactory code so it no longer needs to register and keep track of a discovery service for each bridge.
Also contains a few other improvements:
* more constructor injection
* add a few missing @NonNullByDefault on test classes
Signed-off-by: Wouter Born <github@maindrain.net>
Related to #8607.
In some cases removed information that is actually generic information and should not be in binding readme.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Fix handling problem reading gasmeter
The gasmeter seem to return an invalid date value in some cases.
Possible problems with the meter. This however caused the whole meter readings to be ignored, while it should only ignore the single problem value.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Make eclipse happy again.
Don't ask...
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Removed sat warnings
Removed usage of apache library and added NonNullByDefault to test classes..
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Kai Kreuzer
openhab-bot
Wouter BornandGitHub
Hilbrand BouwkampandGitHub
Jacob LaursenandGitHub
openhab-botandGitHub
J-N-KandGitHub
Дилян ПалаузовandGitHub
Jerome LuckenbachandGitHub
MarcelandGitHub
jenkins
jenkins
J-N-KandGitHub