* Removed internal vendor Map and minor additional improvements
* Incorporated comments from review
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* #72 changed use units of measure for the twinguard humidity and purity values
all other QuantityTypes in bindingcode are fine
* #77 changed title of binding to Bosch Smart Home
Replaced the SHC occurrences with Smart Home,
to avoid technical names.
* #62 Try to restart long polling when it fails before taking the thing offline
* #62 Run subscribe request on a new thread instead of using the thread of the previous long polling http request
This might be the reason why the subscribe request does never finish or finishes with a timeout
* #74 Run the whole long polling response handling in a new thread to not get timeout from HTTP client
* #74 Schedule initial access when long polling fails unexpected
We need to try to reconnect again and again (with 15 seconds between the requests) as the controller may have been restarted (update, manual restart,...). This is already done by the initial access, so I reuse that mechanism.
* Use direct formatting of logger.trace instead of String.format
* #76 Use i18n texts instead of raw translations for status messages about failed long polling
* #76 Use logger.debug instead of logger.warn for long poll error as it is handled now
* #78 defined api-version
each HTTP request will use now the defined "avp-version=2.1" for request to the smart home controller
* logging bundle version
removed the old static version string
access OSGi bundle version information instead
* #75 improved initial access
- added isOnline check and isAccessPossible now failed in case HTTPStatus is an error
- same HTTPStatus check done to all blocking send() request calls
- using i18n strings for all bridge updateStatus calls
- skipped the 'controller' and use only 'Bosch Smart Home' in descriptions
- added more @Nullable annotations
* added newline
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
* Retry command submission when tahome gateway is busy.
* Changed log level, cosmetic changes
* Store list of scheduled retries; cancelled when handler is disposed.
* Made retryFutures thread-safe
Signed-off-by: Georg Siebke <github@georgsiebke.de>
The ceiling10 Yeelight lamp has 2 dimmer for brightness:
"bright" for the main light and bg_bright for the ambient light.
Both are of type dimmer and accept percentage values between 1 and 100.
This fix changes the datatype of the bg_bright property from Number
to Dimmer in the device mapping database file ceiling4, which is also
the one that is used for the ceiling10 lamp.
Accepted without sign-off under minor change exemption.
"format" parameter value for HTML seems that should be "html", not "HTML"
"HTML" seems to have no affect when using sendPriorityMessage, but "html" works.
Accepted without sign-off under minor change exemption.
As per https://creativecommons.tankerkoenig.de (in the "Terms"-section) we should not make more than 1 request per 5 minutes, this changes the limit accordingly and allows doing so.
Signed-off-by: Flole <flole@flole.de>
* Improved error handling for Powermax binding
Catch all exceptions, and take all Powermax things offline in the event
of a communication failure. Also adds a 5-minute watchdog for
connections in Standard (non-Powerlink) mode.
* More Powermax error handling improvements
1. Mark the bridge and all things as offline when communication is lost
2. Bubble all I/O exceptions up to the bridge status
3. Set all channels to UnDefType.NULL when bridge goes offline
4. Ignore CRC errors on messages of type 0xF1
5. Don't try and download partition settings for panels that don't support partitions
6. Fix logging levels to avoid unnecessary non-DEBUG messages
Signed-off-by: Ron Isaacson <isaacson.ron@gmail.com>
* Internationalization + actions for messages
- Internationalization of UI relevant texts
- Better support for the error/warning/info/status messages received
from the device
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Review inputs + improvements
- inputs from @ssalonen
- additional action to retrieve all messages collectively
- added rule example for handling the collective message action
- added semantic tags in items example
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* mvn spotless:apply
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Update bundles/org.openhab.binding.modbus.helioseasycontrols/README.md
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Update bundles/org.openhab.binding.modbus.helioseasycontrols/README.md
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Update bundles/org.openhab.binding.modbus.helioseasycontrols/src/main/java/org/openhab/binding/modbus/helioseasycontrols/internal/HeliosEasyControlsHandler.java
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Update bundles/org.openhab.binding.modbus.helioseasycontrols/src/main/resources/OH-INF/i18n/helioseasycontrols_de.properties
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Update bundles/org.openhab.binding.modbus.helioseasycontrols/src/main/resources/OH-INF/thing/thing-types.xml
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Review inputs from @fwolter
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Inputs from @fwolter
- changed return type for actions with a single return value
- corrected findings from static code analysis
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Removed configurationPid from TranslationProvider
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Changes requested by @fwolter
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Changed log level to debug when catching InterruptedException
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* Added commands for second central heating circuit
* Added command for temperature sensor
* Added controlsetpoint2 and ch2_enable channels
Signed-off-by: Arjen Korevaar <a.korevaar@mephix.com>
* Binding redesigned 20200923 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter], regarded OH3.
[WIP]
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200923 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter] regarded oH3
[WIP]
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200923 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter] regarded oH3
[WIP]
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200923 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter] regarded oH3
[WIP]
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200924 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter] regarded oH3
[WIP]
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200924 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
Changes made in
org.openhab.binding.internal.kostal.inverter.secondgeneration.SecondGenerationHandler.java
found by Travis tests.
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201007 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
Done changes in:
Channels.xml
PIKO1020.xml
README.md
SecondGeneration.xml
SecondGenerationChannelConfiguration.java
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201008 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201012 by Örjan Backsell, regarded to @fwolter
requested changes
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201028 by Örjan Backsell, regarded to @cpmeister
requested changes.
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201105 by Örjan Backsell
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20200923 by Örjan Backsell
'
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
'
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201111 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201117 by Örjan Backsell
'
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter]
[WIP]
'
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201119 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201125 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201130 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201130, 1630 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201202 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201204 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Redesigned 20201204 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20201010 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20210112 by Örjan Backsell
'
Signed-off-by: basse04 orjan.backsell@gmail.com
Also-by: Christian Schneider <>
Also-by: René Stakemeier <>
Also-by: Christoph Weitkamp <>
This is the upgraded version of Kostal Inverter extended with
functionality for the Inverter type of Second generation PIKO 10-20
[kostalinverter]
'
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20210114 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20210119 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding (KostalInverterFactory.java)redesigned 20210119 by Örjan
Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20210125 by Örjan Backsell
* Binding redesigned 20200923 by Örjan Backsell
(KostalInverterFactory.java)
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Binding redesigned 20210125 by Örjan Backsell
Signed-off-by: basse04 <orjan.backsell@gmail.com>
* Added option to reverse rollershutter commands - UP -> DOWN and DOWN -> UP - might happen if rollershuter module's output is wired differently.
* Fixed PR comments.
Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
* Add IR code commands to dropdown and documentation
* Add link to community for advanced UI creation
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* [novafinedust] Test for optimizations on access to the serial port
- retry logic if port does not yet exist on startup
- do not write sleep command on shutdown if port has issues
- no not register data listener on port but wait for data instead to be
compatible with RFC2217 serial over network implementation
- ignore all buffered data from device during initialization to get the
device into a defined state
* Adress review comments
- moved most "normal" logging to TRACE level
- used lambda function
* Improve error messages as requested in the review
Signed-off-by: Stefan Triller <github@stefantriller.de>
* [enocean] Added support for Heat Recovery Ventilation devices (#9465)
* Implemented EEP family D2_50
* Added new thing type (heatRecoveryVentilation) and channels for heat recovery ventilation units
Fixes#9465
* [enocean] Added support for Heat Recovery Ventilation devices (#9465)
* code refactoring (JAVA11 improvements)
Fixes#9465
* [enocean] Added support for Heat Recovery Ventilation devices (#9465)
* Removed unnecessary EEP classes
* Made final fields static
* Added @NonNullByDefault to EEP Class
Fixes#9465
* [enocean] Added support for Heat Recovery Ventilation devices (#9465)
* Removed @NonNullByDefault to not mess up PR with non related changes
Fixes#9465
Signed-off-by: Daniel Weber <uni@fruggy.de>
* Fix brightness
* Revert to old beahaviour if segments are used
* Fix formatting
* Remove unused Var
Signed-off-by: Sebastian Garske <sebgarske@gmail.com>
* add support for custom mapping
* add screenshot
* remove unnecessary variable
* make parameter nullable to avoid not required list instances
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* This PR merges the 2.5 code base with new features, a bunch of bug fixes
and improved documentation. Parts of the code has been re-factored and
vaious issues are fixed/optimized along the way.
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Minor fixed, support for Shelly Color Bulb, Shelly Motion
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Review changes applied
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review change applied
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review changes
Signed-off-by: Markus Michels <markus7017@gmail.com>
* Review changes
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review changes
Signed-off-by: Markus Michels <markus7017@gmail.com>
* README updated
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review change
Signed-off-by: Markus Michels <markus7017@gmail.com>
* review change
Signed-off-by: Markus Michels <markus7017@gmail.com>
Fixes#6762
* Fix Unit tests
The method was used to create the pattern for a regex and for building
the channel id. I ave separated them now. At least the tests are green ;)
Signed-off-by: Stefan Triller <github@stefantriller.de>
* [irobot] Roomba: Add more properties.
On request by @falkena, also some i7 specifics
* [irobot] Roomba: Add map_upload channel.
Controls uploading Clean Map(tm) to the cloud.
* [irobot] discovery: Get rid of empty while() loop
Rewrite the loop so that it doesn't have empty body any more, this gets rid of
one more static analyzer warning. Added dumping the whole IDENT packet on TRACE
level, aids implementing support for newer devices.
Signed-off-by: Pavel Fedin <pavel_fedin@mail.ru>
* [modbus] Cascaded transforms with ∩
* [modbus] README to mention cascaded transformations
* [modbus] Take cascaded transformation into use
* [modbus] README to show preference towards new syntax
* [modbus] examples to use new syntax
* [modbus] fix test
* [modbus] remove apache commons lang dependency
- see also PR #10002
- I removed equals and hashCode implementation all-together, I could not see they played any role in practice.
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
* [pidcontroller] Reset state of command Item after command has been processed
* Fix read-only state of item parameters
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
* [miio] validate response id matching command id
This PR prevents out of sync issues in case devices are too slow to
respond or the timeout is set too short.
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] spotless adding space
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* [miio] update based on review
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Support for Denon "Home" speaker as bridge added
* Fixed a runtime issue if no serial number is provided by the player, by using the PID as a fallback if no serial number is available
Signed-off-by: Wire82 <johannes.einig@me.com>
* Added support for color temperature capabilities and set value in Kelvin
* Use system default channel type
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* Use for each loop in getChildThing()
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
* Further refine getChildThing() using stream map
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
* Fix spotless errors
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
* fix some tivo binding bugs
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* update search example rule
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* [sonos] Add bass/treble/loudness controls
Related to #9874
Disable these controls when the output level is fixed
* Review suggestion: use OnOffType.from
* Add bass/treble/loudness channels to Arc and Arc SL models
* Review comment: remove usage of keySet
Factorize code
Define constants
* Use Map.of to simplify the code
* Review comments considered
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* add ontime
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* Update bundles/org.openhab.binding.deconz/README.md
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
* [sonos] Add support for Sonos Arc/Arc SL + new controls for sub/surround speakers
Related to #9874
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Use OnOffType.from
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Configured XML parsers to resist XXE attacks
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* added fix for avmfritz
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* added fix for sonos
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* added fix for vitotronic and bosesoundtouch
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* changed avmfritz to singleton pattern
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* addressed roku binding
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* address all uses of DocumentBuilderFactory
Signed-off-by: Kai Kreuzer <kai@openhab.org>
* fixed other occurrences in roku binding
Signed-off-by: Kai Kreuzer <kai@openhab.org>
Related to #8607.
In some cases removed information that is actually generic information and should not be in binding readme.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
Fixes#7024
The problem was caused by the asynchttpclient dependency that seemed to require another version of the Netty dependency than what is added by the openhab.tp-netty feature.
This caused some of the classes in the ssl package to not be found during initialization.
I fixed it by upgrading the asynchttpclient dependency to a version that use the same version of Netty that is bundled(4.1.42.Final).
Signed-off-by: Jörgen Nilsson <mail.jnilsson@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Co-authored-by: Dan Cunningham <dan@digitaldan.com>
Co-authored-by: Craig Hamilton <craigh@quailholdings.com>
Co-authored-by: Brian O'Connell <boc@us.ibm.com>
Co-authored-by: Dan Cunningham <dan@digitaldan.com>
Co-authored-by: Craig Hamilton <craigh@quailholdings.com>
Co-authored-by: Brian O'Connell <boc@us.ibm.com>
* [pidcontroller] Catch empty commandTopic
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [pidcontroller] Fix handling action
keys in action context from trigger are passed with prefix of trigger name.
This change removes the prefix to get the actual name and checks if it matches an item.
Else it tries the original name.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [pidcontroller] review comment
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* Add support for ESP32 devices
* Add Unit Tests
Ensure Gson objects are NonNull
Generify Handlers
Generify Utils
Signed-off-by: Christian Schlipp <christian@schlipp.de>
* Updates links to target the openhab-addons 'main' branch instead of the 'master' branch
* Updates some NOTICE files to indicate content is maintained by openHAB instead of Eclipse SmartHome
Signed-off-by: Wouter Born <github@maindrain.net>
The channel is added dynamically with a channel-type `abshumidity`, but the channel-type definition was names `absolutehumidity`
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* Improve debugging in message classes
Each PowermaxBaseMessage subclass had its own toString() which added
useful debug info but duplicated a lot of the logic in the message
handler. I've moved the debug info inline and removed the duplication,
and also added decoding for more values to the debug output.
* Fix for 0xFF byte values, which convert to int -1
Signed-off-by: Ron Isaacson <isaacson.ron@gmail.com>
* Use set instead list to avoid duplicate listeners
* Remove from listeners when bridge is not ONLINE
* Unsubscribe from bridge handler events when thing handler is disposed
Signed-off-by: Olivier Marceau <hollysaiqs@marceau.ovh>
The KP115 plug is a WiFi smart plug with energy monitoring support.
It uses the same API as existing TP-Link smart home devices. This change adds support in the binding for the KP115.
Signed-off-by: Evan Anderson <evan@eaanderson.com>
1. Fixes#8786 invalid uid on discovered hub
2. Resolve issue on startup in OH3 discovery result without address
Signed-off-by: James Melville <jamesmelville@gmail.com>
The internal package was placed before the binding specific package, and it should be the other way around.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* Replace deprecated constructors
* Removed no longer existing settings from the documentation. They were already marked as deprecated since several versions.
* Refactored communication with the HM gateway
- simplified coding for the communication with the gateway
- buffer size for communication is now configurable to avoid problems
with too small buffers
- Previous solution for #6963 was not sufficient. Should be finally done
with these changes
* Retrieving the duty cycle is sufficient to check connection
- ping requests could therefore be safely removed problems with the automatic reconnection were solved.
* Changed to explicit list of Exception
Fixes#8808
Signed-off-by: Martin Herbst <develop@mherbst.de>
* [pidcontroller] Remove limits, make Ki dependent from the loop time
Also fix naming of thread and shutdown executor.
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
* [dsmr] Fix handling problem reading gasmeter
The gasmeter seem to return an invalid date value in some cases.
Possible problems with the meter. This however caused the whole meter readings to be ignored, while it should only ignore the single problem value.
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Make eclipse happy again.
Don't ask...
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [dsmr] Removed sat warnings
Removed usage of apache library and added NonNullByDefault to test classes..
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
* [innogysmarthome] Bug-fix - NPE solved which could occur when devices without a corresponding device state were returned by the API. That happened with the virtual device "NotificationSender" which is unimportant for the binding.
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] JavaDoc fixed
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimizations (warnings fixed)
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code refactoring (InnogyClient class split to make it smaller)
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization ; Potential bug with the reachable attribute solved (it was set multiple times within a loop)
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Tests added
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Tests added
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code changed to not overwrite the reachable state provided by the API (when no corresponding message is available)
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Copyright notice updated
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
* [innogysmarthome] Code and performance optimization
Signed-off-by: Sven Strohschein <sven.strohschein@gmail.com>
Co-authored-by: Sven Strohschein <sven.strohschein@gmail.com>
* add support qrcode based pairing
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* add screenshots
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* fix typo
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* update config only if differnt to prevent endless update loop
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* clean up
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* add support qrcode based pairing
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* add screenshots
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* fix typo
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* update config only if differnt to prevent endless update loop
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* clean up
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* incorporate review feedback
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* fix Nullable based on feedback
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* correct the java hap version
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* Update bundles/org.openhab.io.homekit/pom.xml
* adapt groupid
Signed-off-by: Eugen Freiter <freiter@gmx.de>
* incorporate review feedback
Signed-off-by: Eugen Freiter <freiter@gmx.de>
Co-authored-by: Eugen Freiter <freiter@gmx.de>
Co-authored-by: J-N-K <J-N-K@users.noreply.github.com>
* [openwebnet] Log messages cleanup
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] Fixed normalizeWhere
* added builder for Bus Where addresses
* added messages to OwnIdTest
* depend on own4j 0.3.3-SNAPSHOT
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] Discovery & reconnect for ZigBee USB gateways
* added mgmt of disconnect/reconnect of ZigBee USB Gateway from serial (#9170)
* added ZigBee USB Gateway auto discovery (#9171)
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] fixed up/down automation for old fw (#9651)
* now using openwebnet4j 0.3.3 (nrjavaserial 5.2.1)
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] Fixes lowering dimmers from 20 to 10% does not change device level #9317
- bump openwebnet4j to 0.3.4
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [openwebnet] changes after PR review
Signed-off-by: Massimo Valla <mvcode00@gmail.com>
* [tr064] Normalize numbers in phone book entries.
Phone book numbers and numbers to be looked up might be formatted
differently (real world example: '+49 (12345) 67890' vs. '01234567890'
(where the former is phonebook formatting and the latter is the format
transmitted by the avmfritz binding). Make sure such formatting
differences do not cause lookup mismatches.
Signed-off-by: Danny Baumann <dannybaumann@web.de>
* add unit
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* documentation an XML
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* address review comments
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* improvements
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* improvements
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* added new channels and extra fixes
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* wip
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* added multiple channels
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* fixes after PR comments
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* added support for AUTO fan mode
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* Fixes units
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* Fix PR
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* PR fixes
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* PR fixes
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
* Fixed copyright 2020->2021
Signed-off-by: Benjamin Lafois <benjamin.lafois@gmail.com>
- Rename parameter 1 of "getActions" from "xmpp" to "xmppclient".
- Remove "getEvent()" as "receivedEvent" automatically contains the String since OH3.
In case of simulated Nikobus push button event refresh impacted modules too so binding fetches the updated state from affected modules.
Signed-off-by: Boris Krivonog <boris.krivonog@inova.si>
The original example references to the old telegram action, which is no longer supported. The updated example uses the (new) telegram binding.
Signed-off-by: Sören Berger <soeren.berger@u1337.de>
* [lgwebos] Remove outdated statement from README.md
Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
* Adding a sentence on why these TV settings are relevant.
Signed-off-by: Sebastian Prehn <sebastian.prehn@gmx.de>
* [remoteopenhab] Catch exception when parsing item state
* Review comment: set channel state to UNDEF in case item state parsing failed
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* Added ConfigOptionProvider to provide file names ending with '.js' in Profile configuration
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
* open connection on refresh even if no modules exist
Signed-off-by: Wouter Denayer <wouter@denayer.com>
* ran mvn spotless:apply
Signed-off-by: Wouter Denayer <wouter@denayer.com>
* removed unnecessary file
Signed-off-by: Wouter Denayer <wouter@denayer.com>
* returning when the connection is offline since following code won't work
either.
Signed-off-by: Wouter Denayer <wouter@denayer.com>
Co-authored-by: Wouter Denayer <wouter@denayer.com>
* [icalendar] Fixed issues with moved events and wrong displayed events
* [icalendar] Changed test to use local time in test-calendar of #9647Fixes#9647.
Handling for RFC 5545's RECURRENCE-ID field inside of
events and rounded begin (and based on it end) down in subsecond
precision.
The calendar does not define a timezone. On a machine that uses a
different timezone than Europe/Berlin the test failed. As the behavior
itself is specified, the test was changed to use local time for its
dates.
Signed-off-by: Michael Wodniok <michi@noorganization.org>
* [amazonechocontrol] add channel-types to schema
* [amazonechocontrol] use mergedApplianceIds to query state
Signed-off-by: Miguel <miguelwork92@gmail.com>
* Baseline original code from AndyXMB
* Initial updates for OH3
* fix null warnings and add sub-channel handling
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
* Expanded descriptions and note on textual config
Some paragraphs are expanded and some more info on the fritzbox subdevices are given. Channels are grouped by subdevice. Textual description with .items files is briefly described at the end but a clear warning on possible drawbacks is given and it is also clearly stated that it is discouraged.
Signed-of-by: Lionello Marrelli <marrelli_lio@yahoo.it>
* Improve debugging in message classes
Each PowermaxBaseMessage subclass had its own toString() which added
useful debug info but duplicated a lot of the logic in the message
handler. I've moved the debug info inline and removed the duplication,
and also added decoding for more values to the debug output.
* Fix for 0xFF byte values, which convert to int -1
* Change to inline debug messages
Signed-off-by: Ron Isaacson <isaacson.ron@gmail.com>
* Update README.md
examples updated
broken link for CAP DWD Profile fixed
some debugging information added
mapping files renamed to fit naming convention for files containing German language
additional mapping for weather warning added
examples also updated
mapping files extended with mapping for UNDEF state
* fix connection attempts when thing disposed
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* refactor session handling
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* rename
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* refactoring
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
* Corrected some item types in the documentation.
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Correction as per @ssalonen's review.
Signed-off-by: Bernhard Bauer <bern77@gmail.com>
* Corrected sendIRCode handler
Signed-off-by: Michael Loercher <MichaelLoercher@web.de>
* Update YIOremoteDockHandler.java
Updating IR receiver switch handler so it's running now
Solved issue during triggering channel while it was disposed
Signed-off-by: Michael Loercher <MichaelLoercher@web.de>
* Update YIOremoteDockHandler.java
Signed-off-by: Michael Loercher <MichaelLoercher@web.de>
No "Other" option in Google-Cloud-TTS OAuth2 Client Type options. Choose "TV and Limited Input" instead. Rest of readme works as expected.
Signed-off-by: Zimmermann Zsolt <cina@cina.hu>
* [linky] Handle case when data from yesterday is still NaN
Fix#9386
* Refresh every 2 hours until data from yesterday are available
* Log yesterday even for month and year requests
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [fronius] Add support for Fronius Smart Meter
* [fronius] Use DTO, implement UoM
* [fronius] fix README.md
* [fronius] Add mandatory label for channel-type and fix property update
* [fronius] Store meterRealtimeBodyData instead of meterRealtimeResponse
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
* improve data handling and suspend
* fix command position
* add ACK to subResponse
* fix data position
* fix reactivation, trim too long responses
* ensure correct setting of activation channel
* Remove @SuppressWarnings(null), which is not needed anymore
* Remove updateState on dispose
Signed-off-by: Hans Böhm <h.boehm@gmx.at>
[nikohomecontrol] Small README update.
While searching why I can't get my electricity working, I think I spotted this typo.
Signed-off-by: Dries Vandenneucker <dries.vandenneucker@yahoo.com>
* [modbus] add support for rtu encoded over tcp
* [modbus] move classes to openhab/jamod
* [modbus] spotless
* [modbus] revert EndpointPoolConfiguration
* [modbus] remove virtual serial
* [modbus] resolve dependencies
* [modbus.studer] add support for RTU over TCP bridge
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
* This is the initial contribution of the Generac MobileLink binding. This allows the Generac line of generators using their MobileLink cloud service to be monitored as things in openHAB.
* bump to 3.1
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
In trying the example I got an error from the serial binding. But by adding a `,` the serial binding was able to handle the example.
Signed-off-by: Michael R. Maletich <maleticm@gmail.com>
* [miio] suggest correct devicenames in readmehelper
* add newline at file end to make git happy
* [miio] update logic for mapping in readmeComments
* Allow readme maker to fix mappings based on the current options.
* [miio] make readmeOptionMapping static
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
* Clarify the process of adding/discovering the server
* Update bundles/org.openhab.binding.squeezebox/README.md
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Co-authored-by: Connor Petty <mistercpp2000@gmail.com>
Older HM dimmers are using a maximum values of 1.0. But also for these
devices the values must be corrected.
Signed-off-by: Martin Herbst <develop@mherbst.de>
* [icalendar] Optimize searching events and adding a bit debug output
Fixes#9498 by limiting series events when retrieving possible events via
filter.
Adding a bit more debug output to allow debugging the correct scheduling of
events.
Signed-off-by: Michael Wodniok <michi@noorganization.org>
* Fix typos in example code
* One Call API: add channe dew-point for daily forecast
* One Call API: remove channel visibility in daily forecast as not included
in data
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
* [hue] Make sure the serial number will be in lowercase
Necessary for the auto-ignore discovery feature with the representation property.
Fix#9364
* Check that the serial number is not null
* Check that the serial number is not blank
* Build a discovery result even without a serial number
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
* [hueemulation] Correct format of UDN and serialNumber fields
* Avoid changing device ids on upgrade
* Revert light and group ids back to a number rather than hexadeximal
* Fix failing tests
Signed-off-by: Mike Major <mike_j_major@hotmail.com>
* Add aggregated channels for daily forecast.
Also updates to use Optionals instead of @Nullables, and add unit tests
* Revert unsing explicit unit definition
Signed-off-by: Anders Alfredsson <andersb86@gmail.com>
* [icalendar] Provide example for Netcloud usage
Users of the icalender OH 1 binding might wonder how to get the url for the
ical file for their calenders. It took me a couple of hours to find this, so
I think it might be useful to have it as an example in the documentation.
Signed-off-by: Stefan Triller <github@stefantriller.de>
Christoph Weitkamp
pali
Christian Oeing
goopilot
Markus Storm
Georg Siebke
Andrew Fiddian-Green
GiviMAD
Michael Rumpf
niebochod
Martin Herbst
Florian Mueller
Stefan Triller
Flole998
Ron Isaacson
J-N-K
eugen
mlobstein
cedricboon
Hilbrand Bouwkamp
Bernhard Bauer
lolodomo
Arjen Korevaar
basse04
Boris Krivonog
Marcel
Mathias
Bob Raker
Daniel Weber
Sebastian Garske
Markus Michels
stefan-hoehn
Sonic-Amiga
Jürgen Weber
Sami Salonen
Fabian Wolter
neutmute
Matthew Skinner
Paul Vogel
Johannes Einig
Gaël L'hopital
Ethan Dye
rimago
morph166955
Martin van Wingerden
Mike Major
Wouter Born
Connor Petty
Kai Kreuzer
jimtng
xi1I
Jay Sprenkle
Daniel Pape
Jochen Klein
Matt
nowaterman
kalleboll
gordongeissler
CSchlipp
Björn Brings
Christian Oeing
Christian Bandowski
mwe
druciak
fundef1
hutdev
Stian Kjoglum
Ondrej Pecta
olivierkeke
Evan Anderson
James Melville
Stefan300381
Jeff Lauterbach
Sven Strohschein
M Valla
maniac103
Felix Hirschberg
Taxifahrer
Benjamin Lafois
s0-er-eN
Stefan
banzaay
Sören Berger
Sebastian Prehn
Michael Wodniok
Jerome Luckenbach
Wouter Denayer
ItIsFelix
Mark Hilbush
Thomas Weißschuh
Nils Bauer
Pawel Pieczul
Merlin Westphal
Lionello Marrelli
Andrew Schofield
Jens Schanz
digitlength
Marek Hulán
miloit
Chris Carman
vbier
Zimmermann Zsolt
Matthias Schulte
pravussum
boehan
Bob A
Dries Vandenneucker
Dan Cunningham
Michael R. Maletich
jwveldhuis
tophee
Korbinian Probst
Stefan Giehl
Markus Gafner
schmidmuc
Holger Friedrich
robnielsen
Anders Alfredsson
jenkins