Fix/suppress PMD CompareObjectsWithEquals findings (#11476)
Newer PMD versions discover more CompareObjectsWithEquals findings. Related to https://github.com/openhab/static-code-analysis/pull/423 Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
@@ -319,6 +319,7 @@ public class SocketChannelSession implements SocketSession {
|
||||
* Stops the reader. Will wait 5 seconds for the runnable to stop (should stop within 1 second based on the poll
|
||||
* timeout below)
|
||||
*/
|
||||
@SuppressWarnings("PMD.CompareObjectsWithEquals")
|
||||
public void stopRunning() {
|
||||
if (isRunning.getAndSet(false)) {
|
||||
// only wait if stopRunning didn't get called as part of processing a message
|
||||
|
||||
@@ -1088,7 +1088,7 @@ class AtlonaPro3PortocolHandler {
|
||||
|
||||
@Override
|
||||
public void responseReceived(String response) {
|
||||
if (response == null || response == "") {
|
||||
if (response == null || response.isEmpty()) {
|
||||
return;
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user