public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix/suppress PMD CompareObjectsWithEquals findings (#11476)

Browse Source 
Newer PMD versions discover more CompareObjectsWithEquals findings.

Related to https://github.com/openhab/static-code-analysis/pull/423

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2021-11-02 10:43:53 +01:00
committed by GitHub
parent b67b9fcb25
commit 589400e223
82 changed files with 175 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
bundles/org.openhab.binding.bluetooth.roaming/src/main/java/org/openhab/binding/bluetooth/roaming/internal/RoamingBluetoothDevice.java
View File

@@ -104,6 +104,7 @@ public class RoamingBluetoothDevice extends DelegateBluetoothDevice {
return getAdapter(currentDelegateRef.get());
}
@SuppressWarnings("PMD.CompareObjectsWithEquals")
private class Listener implements BluetoothDeviceListener {
private BluetoothDevice device;

2
bundles/org.openhab.binding.bluetooth.roaming/src/main/java/org/openhab/binding/bluetooth/roaming/internal/RoamingBridgeHandler.java
View File

@@ -143,6 +143,7 @@ public class RoamingBridgeHandler extends BaseBridgeHandler implements RoamingBl
}
@Override
@SuppressWarnings("PMD.CompareObjectsWithEquals")
public void addBluetoothAdapter(BluetoothAdapter adapter) {
if (adapter == this) {
return;
@@ -164,6 +165,7 @@ public class RoamingBridgeHandler extends BaseBridgeHandler implements RoamingBl
}
@Override
@SuppressWarnings("PMD.CompareObjectsWithEquals")
public void removeBluetoothAdapter(BluetoothAdapter adapter) {
if (adapter == this) {
return;