public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix/suppress PMD CompareObjectsWithEquals findings (#11476)

Browse Source 
Newer PMD versions discover more CompareObjectsWithEquals findings.

Related to https://github.com/openhab/static-code-analysis/pull/423

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2021-11-02 10:43:53 +01:00
committed by GitHub
parent b67b9fcb25
commit 589400e223
82 changed files with 175 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
bundles/org.openhab.binding.jeelink/src/main/java/org/openhab/binding/jeelink/internal/JeeLinkHandler.java
View File

@@ -170,7 +170,7 @@ public class JeeLinkHandler extends BaseBridgeHandler implements BridgeHandler,
// this is the first handler for this reading class => also setup converter
readingClassHandlerMap.put(h.getReadingClass(), handlers);
if (SensorDefinition.ALL_TYPE == h.getSensorType()) {
if (SensorDefinition.ALL_TYPE.equals(h.getSensorType())) {
converters.addAll(SensorDefinition.getDiscoveryConverters());
} else {
JeeLinkReadingConverter<?> c = SensorDefinition.getConverter(h.getSensorType());
@@ -200,7 +200,7 @@ public class JeeLinkHandler extends BaseBridgeHandler implements BridgeHandler,
// this was the last handler for this reading class => also remove converter
readingClassHandlerMap.remove(h.getReadingClass());
if (SensorDefinition.ALL_TYPE == h.getSensorType()) {
if (SensorDefinition.ALL_TYPE.equals(h.getSensorType())) {
converters.removeAll(SensorDefinition.getDiscoveryConverters());
} else {
JeeLinkReadingConverter<?> c = SensorDefinition.getConverter(h.getSensorType());