public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix/suppress PMD CompareObjectsWithEquals findings (#11476)

Browse Source 
Newer PMD versions discover more CompareObjectsWithEquals findings.

Related to https://github.com/openhab/static-code-analysis/pull/423

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2021-11-02 10:43:53 +01:00
committed by GitHub
parent b67b9fcb25
commit 589400e223
82 changed files with 175 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bundles/org.openhab.binding.plugwise/src/main/java/org/openhab/binding/plugwise/internal/handler/AbstractPlugwiseThingHandler.java
View File

@@ -287,7 +287,7 @@ public abstract class AbstractPlugwiseThingHandler extends BaseThingHandler impl
protected void updateTask(PlugwiseDeviceTask task) {
if (task.shouldBeScheduled()) {
if (!task.isScheduled() || task.getConfiguredInterval() != task.getInterval()) {
if (!task.isScheduled() || !task.getConfiguredInterval().equals(task.getInterval())) {
if (task.isScheduled()) {
task.stop();
}

2
bundles/org.openhab.binding.plugwise/src/main/java/org/openhab/binding/plugwise/internal/handler/PlugwiseStickHandler.java
View File

@@ -262,7 +262,7 @@ public class PlugwiseStickHandler extends BaseBridgeHandler implements PlugwiseM
protected void updateTask(PlugwiseDeviceTask task) {
if (task.shouldBeScheduled()) {
if (!task.isScheduled() || task.getConfiguredInterval() != task.getInterval()) {
if (!task.isScheduled() || !task.getConfiguredInterval().equals(task.getInterval())) {
if (task.isScheduled()) {
task.stop();
}