public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix/suppress PMD CompareObjectsWithEquals findings (#11476)

Browse Source 
Newer PMD versions discover more CompareObjectsWithEquals findings.

Related to https://github.com/openhab/static-code-analysis/pull/423

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2021-11-02 10:43:53 +01:00
committed by GitHub
parent b67b9fcb25
commit 589400e223
82 changed files with 175 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bundles/org.openhab.binding.qbus/src/main/java/org/openhab/binding/qbus/internal/handler/QbusDimmerHandler.java
View File

@@ -244,7 +244,7 @@ public class QbusDimmerHandler extends QbusGlobalHandler {
}
} else if (command instanceof PercentType) {
int percentToInt = ((PercentType) command).intValue();
if (command == PercentType.ZERO) {
if (PercentType.ZERO.equals(command)) {
qDimmer.execute(0, snr);
} else {
qDimmer.execute(percentToInt, snr);

4
bundles/org.openhab.binding.qbus/src/main/java/org/openhab/binding/qbus/internal/handler/QbusRolHandler.java
View File

@@ -218,7 +218,7 @@ public class QbusRolHandler extends QbusGlobalHandler {
} else if (command instanceof PercentType) {
PercentType p = (PercentType) command;
int pp = p.intValue();
if (p == PercentType.ZERO) {
if (PercentType.ZERO.equals(p)) {
qRol.execute(0, snr);
} else {
qRol.execute(pp, snr);
@@ -264,7 +264,7 @@ public class QbusRolHandler extends QbusGlobalHandler {
}
} else if (command instanceof PercentType) {
int percentToInt = ((PercentType) command).intValue();
if (command == PercentType.ZERO) {
if (PercentType.ZERO.equals(command)) {
qRol.executeSlats(0, snr);
} else {
qRol.executeSlats(percentToInt, snr);