public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix/suppress PMD CompareObjectsWithEquals findings (#11476)

Browse Source 
Newer PMD versions discover more CompareObjectsWithEquals findings.

Related to https://github.com/openhab/static-code-analysis/pull/423

Signed-off-by: Wouter Born <github@maindrain.net>
This commit is contained in:
Wouter Born
2021-11-02 10:43:53 +01:00
committed by GitHub
parent b67b9fcb25
commit 589400e223
82 changed files with 175 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
bundles/org.openhab.binding.satel/src/main/java/org/openhab/binding/satel/internal/handler/SatelOutputHandler.java
View File

@@ -61,6 +61,7 @@ public class SatelOutputHandler extends WirelessChannelsHandler {
}
@Override
@SuppressWarnings("PMD.CompareObjectsWithEquals")
protected StateType getStateType(String channelId) {
StateType result = super.getStateType(channelId);
if (result == StateType.NONE) {

2
bundles/org.openhab.binding.satel/src/main/java/org/openhab/binding/satel/internal/handler/SatelStateThingHandler.java
View File

@@ -90,6 +90,7 @@ public abstract class SatelStateThingHandler extends SatelThingHandler {
}
@Override
@SuppressWarnings("PMD.CompareObjectsWithEquals")
public void incomingEvent(IntegraStateEvent event) {
logger.trace("Handling incoming event: {}", event);
// update thing's state unless it should accept commands only
@@ -162,6 +163,7 @@ public abstract class SatelStateThingHandler extends SatelThingHandler {
* @param event list of state changes since last refresh
* @return collection of {@link IntegraStateCommand}
*/
@SuppressWarnings("PMD.CompareObjectsWithEquals")
protected Collection<SatelCommand> getRefreshCommands(NewStatesEvent event) {
final boolean hasExtPayload = getBridgeHandler().getIntegraType().hasExtPayload();
final Collection<SatelCommand> result = new LinkedList<>();

1
bundles/org.openhab.binding.satel/src/main/java/org/openhab/binding/satel/internal/handler/SatelZoneHandler.java
View File

@@ -75,6 +75,7 @@ public class SatelZoneHandler extends WirelessChannelsHandler {
}
@Override
@SuppressWarnings("PMD.CompareObjectsWithEquals")
protected StateType getStateType(String channelId) {
StateType result = super.getStateType(channelId);
if (result == StateType.NONE) {