public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[hdpowerview] Secondary shade position was inverted (#11552)

Browse Source 
* [hdpowerview] get secondary shade position value was inverted

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

* [hdpowerview] remove testing Jar from PR

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
This commit is contained in:
Andrew Fiddian-Green 2021-11-12 00:23:25 +00:00 committed by GitHub
parent e98f7a9591
commit cb13ec6f1a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
bundles/org.openhab.binding.hdpowerview/src/main/java/org/openhab/binding/hdpowerview/internal/api/ShadePosition.java
View File

@ -236,7 +236,7 @@ public class ShadePosition {
* Uses a coordinate system that is NOT inverted in relation to OpenHAB * Uses a coordinate system that is NOT inverted in relation to OpenHAB
*/ */
if (posKind2.intValue() != 3) { if (posKind2.intValue() != 3) {
return new PercentType(100 - (int) Math.round(position2.doubleValue() / MAX_SHADE * 100)); return new PercentType((int) Math.round(position2.doubleValue() / MAX_SHADE * 100));
} }
default: default:
return UnDefType.UNDEF; return UnDefType.UNDEF;

2
bundles/org.openhab.binding.hdpowerview/src/test/java/org/openhab/binding/hdpowerview/HDPowerViewJUnitTests.java
View File

@ -351,7 +351,7 @@ public class HDPowerViewJUnitTests {
pos = shadePos.getState(SECONDARY_ACTUATOR, ZERO_IS_OPEN); pos = shadePos.getState(SECONDARY_ACTUATOR, ZERO_IS_OPEN);
assertEquals(PercentType.class, pos.getClass()); assertEquals(PercentType.class, pos.getClass());
assertEquals(65, ((PercentType) pos).intValue()); assertEquals(35, ((PercentType) pos).intValue());
pos = shadePos.getState(PRIMARY_ACTUATOR, VANE_COORDS); pos = shadePos.getState(PRIMARY_ACTUATOR, VANE_COORDS);
assertEquals(UnDefType.class, pos.getClass()); assertEquals(UnDefType.class, pos.getClass());