public/openhab-addons
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[amazonechocontrol] improve logging (#9241)

Browse Source 
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
This commit is contained in:
J-N-K 2020-12-07 21:05:11 +01:00 committed by GitHub
parent 84703631fc
commit e3a659e8d3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
bundles/org.openhab.binding.amazonechocontrol/src/main/java/org/openhab/binding/amazonechocontrol/internal/Connection.java
View File

@ -50,6 +50,8 @@ import java.util.concurrent.locks.Lock;
import java.util.concurrent.locks.ReentrantLock;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
import java.util.stream.Collectors;
import java.util.stream.StreamSupport;
import java.util.zip.GZIPInputStream;
import javax.net.ssl.HttpsURLConnection;
@ -1191,25 +1193,21 @@ public class Connection {
String requestBody = json.toString();
try {
String resultBody = makeRequestAndReturnString("PUT", url, requestBody, true, null);
logger.debug("{}", resultBody);
logger.trace("Request '{}' resulted in '{}", requestBody, resultBody);
JsonObject result = parseJson(resultBody, JsonObject.class);
if (result != null) {
JsonElement errors = result.get("errors");
if (errors != null && errors.isJsonArray()) {
JsonArray errorList = errors.getAsJsonArray();
if (errorList.size() > 0) {
logger.info("Smart home device command failed.");
logger.info("Request:");
logger.info("{}", requestBody);
logger.info("Answer:");
for (JsonElement error : errorList) {
logger.info("{}", error.toString());
}
logger.warn("Smart home device command failed. The request '{}' resulted in error(s): {}",
requestBody, StreamSupport.stream(errorList.spliterator(), false)
.map(JsonElement::toString).collect(Collectors.joining(" / ")));
}
}
}
} catch (URISyntaxException e) {
logger.info("Wrong url {}", url, e);
logger.warn("URL '{}' has invalid format for request '{}': {}", url, requestBody, e.getMessage());
}
}