Commit Graph
66 Commits
Author SHA1 Message Date
Wouter BornandGitHub ee59803df8 Remove org.jetbrains.annotations.NotNull (#10334)
Only Eclipse JDT annotations should be used, see:

https://www.openhab.org/docs/developer/guidelines.html#null-annotations

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-14 23:22:52 +01:00
Wouter BornandGitHub f3a517e4e1 [lifx] Fix all SAT findings (#10307)
* Remove dependency on commons-lang classes
* Use HexUtils
* Fix/add missing initial contribution author lines
* Add unit test for MACAddress
* Rename protocol package to dto

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-10 09:52:39 +01:00
Wouter BornandGitHub 051c764789 Upgrade Jackson to 2.12.2 (#10288)
* Adds a jackson.version property to simplify managing the version
* Make sure the specified version is used as add-on dependency by excluding Jackson from transitive dependencies
* Use openhab.tp-jackson feature with dynamodb
* Remove jackson-dataformat-cbor dependency from features which is now also provided by the openhab.tp-jackson feature

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-07 10:19:32 +01:00
Wouter BornandGitHub f2eea9ea0f Improve CODEOWNERS (#10289)
* Fix wrong username
* Remove modbus transport

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-06 16:47:12 +01:00
Wouter BornandGitHub 9c112a9a1d Update bnd to 5.3.0 (#10257)
See: https://github.com/bndtools/bnd/wiki/Changes-in-5.3.0

Related to https://github.com/openhab/openhab-core/pull/2217

Signed-off-by: Wouter Born <github@maindrain.net>
2021-02-28 21:33:41 +01:00
Wouter BornandGitHub f926cd8080 Add POM and feature dependencies for commons-net (#9940)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-25 13:45:12 +01:00
Wouter BornandGitHub 05c16b0395 Fix links and NOTICE files (#9860)
* Updates links to target the openhab-addons 'main' branch instead of the 'master' branch
* Updates some NOTICE files to indicate content is maintained by openHAB instead of Eclipse SmartHome

Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-18 21:49:06 +01:00
Wouter BornandGitHub 59dffd03a4 Resolve itests for BOM changes (#9828)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-15 22:09:59 +01:00
Wouter BornandGitHub 0f118c6b7e Update bnd to 5.2.0 (#9785)
See: https://github.com/bndtools/bnd/wiki/Changes-in-5.2.0

Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-12 22:02:35 +01:00
Wouter BornandGitHub 0816045a59 Update Mockito, JUnit and use MockitoExtensions in itests (#9702)
* Updates Mockito to 3.7.0
* Updates JUnit to 5.7.0
* Use MockitoExtensions where possible

Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-06 14:30:40 +01:00
Wouter BornandGitHub 8f84646ed1 [groovyscripting] Update Groovy to 3.0.7 and add more docs (#9708)
Fixes #8951

Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-06 08:46:43 +01:00
Wouter BornandGitHub d6364aceb1 Update license headers to 2021 (#9620)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-02 22:03:14 +01:00
Wouter BornandGitHub d1ef41851c [modbus] Disable unstable ModbusDataHandlerTest#testRefreshOnData itest (#9653)
Related to #9617

Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-02 17:58:21 +01:00
Wouter BornandGitHub 075b7265c0 Resolve itest runbundles for XStream 1.4.15 (#9489)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-24 00:58:48 +01:00
Wouter BornandGitHub 2d1b32fabe Add "Bundles" to automation project names (#9457)
Fixes #9451

Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-22 13:10:16 +01:00
Wouter BornandGitHub 7fa1c8e67f [groovyscripting] Fix build warnings (#9460)
Fixes these warnings:

[WARNING] /openhab-addons/bundles/org.openhab.automation.groovyscripting/pom.xml [10:52]: Invalid property key: `groovy.runtime.metaclass;resolution`: <<      groovy.runtime.metaclass;resolution:=optional,>>
[WARNING] /openhab-addons/bundles/org.openhab.automation.groovyscripting/pom.xml [11:61]: Invalid property key: `groovyjarjarantlr4.stringtemplate;resolution`: <<      groovyjarjarantlr4.stringtemplate;resolution:=optional,>>
[WARNING] /openhab-addons/bundles/org.openhab.automation.groovyscripting/pom.xml [12:50]: Invalid property key: `org.abego.treelayout.*;resolution`: <<      org.abego.treelayout.*;resolution:=optional,>>
[WARNING] /openhab-addons/bundles/org.openhab.automation.groovyscripting/pom.xml [13:44]: Invalid property key: `org.apache.ivy.*;resolution`: <<      org.apache.ivy.*;resolution:=optional,>>
[WARNING] /openhab-addons/bundles/org.openhab.automation.groovyscripting/pom.xml [14:53]: Invalid property key: `org.stringtemplate.v4.*;resolution`: <<      org.stringtemplate.v4.*;resolution:=optional,\\>>

Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-22 13:09:50 +01:00
Wouter BornandGitHub ecac667258 Apply Spotless, update skeleton project version, resolve itest runbundles (#9459)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-22 10:37:44 +01:00
Wouter BornandGitHub e7734449bc Add Jython Scripting (#9404)
* Add Jython Scripting

Also-by: Scott Rushworth <openhab@5iver.com>
Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-17 11:24:43 -08:00
Wouter BornandGitHub 8f53e320dc Fix StateDescription deprecations (#9352)
Related to #1408

Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-13 08:53:16 +01:00
Wouter BornandGitHub 9ee81eae38 [mapdb] Recreate DB when incompatible OH2 DB is used (#9299)
The only way to recover from an incompatible OH2 database is to create a new database.
With these changes the add-on will create a new database automatically and archive the incompatible database files in a backup directory.

Fixes #8794

Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-12 19:11:50 +01:00
Wouter BornandGitHub 3a4d9ec89f Remove Travis CI configuration (#9343)
* Remove all files used with Travis CI only
* Update README.md to display Jenkins build status badge

Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-12 15:39:36 +01:00
Wouter BornandGitHub c755e85281 Fix missing feature configfiles (#9324)
* Update configfile lines for renamed openhab-addons-external artifactId
* Add missing 2.5.x configfiles files which were never merged into the main branch
* Fix configfile lines not aggregated in feature.xml file

Fixes openhab/openhab-distro#1205

Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-11 14:34:44 +01:00
Wouter BornandGitHub d2e5c3e7dd Remove SmartHome leftovers (#9283)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-08 18:03:49 +01:00
Wouter BornandGitHub ac6f08908f Use renamed Units class (#9267)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-07 10:34:02 +01:00
Wouter BornandGitHub ac18da7fc3 Use core unit classes (#9261)
Add-ons should not depend on tec.uom.se classes but use core unit classes instead so they are less impacted when this library is replaced or upgraded.

Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-06 19:57:26 +01:00
Wouter BornandGitHub 90ea8d8106 Fix CODEOWNERS file (#9183)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-11-30 12:44:18 +01:00
Wouter BornandGitHub 57177ccdff [plugwise] Use ThingHandlerService for discovery (#9041)
This simplifies the PlugwiseHandlerFactory code so it no longer needs to register and keep track of a discovery service for each bridge.

Also contains a few other improvements:

* fix lastRequest timestamp not updated when sending messages to discover node properties
* use java.time Duration and Instant
* use List.of, Set.of
* remove redundant null suppression because of EEAs

Signed-off-by: Wouter Born <github@maindrain.net>
2020-11-15 17:29:02 -08:00
Wouter BornandGitHub b423f93b1f Remove Map null annotation workarounds (#8916)
These workarounds to prevent false positives can be removed now the EEAs allow for proper null analysis.

Signed-off-by: Wouter Born <github@maindrain.net>
2020-11-04 13:57:24 +01:00
Wouter BornandGitHub da490ece4e [lifx] Improve selector logic (#8941)
* Properly handle datagrams that are not immediately available so no NPEs are logged on debug
* Properly handle sockets channels that are not connected so no NPEs are logged on debug
* Prevent load/garbage by reusing ByteBuffer and not allocating trace logging strings

Fixes #8932

Signed-off-by: Wouter Born <github@maindrain.net>
2020-11-02 10:15:59 +01:00
Wouter BornandGitHub 603ceedff9 [rrd4j] Improve performance (#8929)
* [rrd4j] Improve performance

* Cache item to improve performance
* Also return DecimalType for QuantityType values

Related to #8928
Reintroduces #8809

Signed-off-by: Wouter Born <github@maindrain.net>
2020-11-01 21:28:25 +01:00
Wouter BornandGitHub 7bff7f1bf3 Fix build (#8911)
Broken by #8893

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-30 17:38:23 -07:00
Wouter BornandGitHub 6398773007 [modbus] Disable failing test (#8884)
Related to #8880

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-27 22:30:27 +01:00
Wouter BornandGitHub 08405233ae Add .gitattributes (#8874)
Without this configuration there are issues with line endings on Windows.

See: openhab/openhab-addons#8712

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-26 21:12:21 +01:00
Wouter BornandGitHub cb5d8711b8 [mapdb] Fixes and improvements (#8852)
* Fix index out of bounds when persisting empty StringType values
* Fix deserialization when strings contain type separator
* Improve debug logging
* Improve test coverage

Fixes #8790

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-24 18:10:46 +02:00
Wouter BornandGitHub 52b7c8e920 [lifx] Fix IAE for unsupported products and update products (#8827)
* Fix IllegalArgumentException when updating properties of unsupported product
* Add missing products

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-21 20:03:23 +02:00
Wouter BornandGitHub 3dbcf37b74 Fix Tradfri itest (#8788)
Related to openhab/openhab-core#1721

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-18 15:40:14 +02:00
Wouter BornandGitHub de6390501b [groovyscripting] Add Groovy scripting support (#8772)
* Add Groovy scripting support

This makes it really easy to start using Groovy 3.x scripts with openHAB!

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-17 23:32:14 +02:00
Wouter BornandGitHub fd1a40aaba Improve "Command line build" section (#8767)
* Add/explain more command line options
* Structure options in a table
* Explain when to use -DwithResolver

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-17 12:56:55 -07:00
Wouter BornandGitHub 978e122e00 Rework ThingActions (#8755)
* Remove duplication by making use of default Java generated exceptions
* Make ThingActions labels/descriptions more consistent

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-15 10:53:53 +02:00
Wouter BornandGitHub bef1046258 Rework ThingActions (#8732)
* Remove proxy workarounds
* Move ThingActions and a few other classes into the internal package
* Use more consistent action labels/descriptions

Related to:

* openhab/openhab-core#1714
* openhab/openhab-core#1639

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-14 19:01:12 +02:00
Wouter BornandGitHub 6243ccb026 [hueemulation] Update feature (#8719)
Related to openhab/openhab-core#1709

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-10 19:09:56 +02:00
Wouter BornandGitHub be7e9c9680 Configure XStream security and resolve itest bundles (#8663)
* Configures XStream security to prevent "Security framework of XStream not initialized, XStream is probably vulnerable" warnings.
* Resolves the itest bundles for the upgrade to XStream 1.4.13

Related to openhab/openhab-core#1688

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-04 22:10:04 +02:00
Wouter BornandGitHub bd4528dcf3 Resolve itest bundles for Xtext upgrade (#8653)
Related to openhab/openhab-core#1685

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-04 18:34:57 +02:00
Wouter BornandGitHub d42efe0b22 Upgrade Maven compiler and fix/upgrade some TP dependencies (#8636)
Upgrades the compiler and its dependencies so the compiler results of Maven builds are more similar to those generated in recent Eclipse versions.

To fix compilation issues in Eclipse for add-ons using classes from javax.xml.stream several dependencies were upgraded/excluded.

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-03 18:23:16 +02:00
Wouter BornandGitHub 1b0876f719 [hue] Improve HueBridgeHandlerOSGiTest stability (#8621)
The ThingStatus is updated asynchronously so the test is unstable when the status is not updated immediately.

Signed-off-by: Wouter Born <github@maindrain.net>
2020-10-01 12:19:51 +02:00
Wouter BornandGitHub fbafc365da Fix parallel MQTT itests execution (#8617)
* Improve exception handling of the embedded MQTT broker so the port can be reconfigured when it is already bound and it properly unlocks files
* Rework MQTT integration tests so they each run the embedded broker on their own reserved port

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-30 19:36:47 +02:00
Wouter BornandGitHub c5f87b44f3 [hueemulation] Replace Jersey dependency with JAX-RS Whiteboard (#8611)
Fixes #7647

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-29 18:53:43 -07:00
Wouter BornandGitHub d72a077ba9 Fix disabled integration tests (#8609)
* Fix disabled integration tests

Fixes and enables:

* org.openhab.binding.mqtt.homeassistant.tests
* org.openhab.binding.mqtt.homie.tests
* org.openhab.io.mqttembeddedbroker.tests

Fixes #8537 
* Address review comment

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-29 14:05:39 -07:00
Wouter BornandGitHub aa3f73d423 [nikohomecontrol] Fix deprecated MQTT transport call (#8577)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-25 12:16:27 +02:00
Wouter BornandGitHub b503dce9fd Fix MQTT transport deprecations (#8570)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-24 13:50:46 -07:00
Wouter BornandGitHub 4b7eba1ab2 Update CODEOWNERS file (#8566)
* Update CODEOWNERS file

* Add missing bundles/itests dirs
* Remove bundles/itests dirs that no longer exist
* Sort list

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-24 19:42:24 +02:00
Wouter BornandGitHub f0ee7ffb2f Remove Jersey ClientBuilder compatibility (#8561)
Fixes #7531

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-24 10:40:12 -07:00
Wouter BornandGitHub cc042dabff Remove deprecated handleUpdate from ThingHandler (#8558)
The handleUpdate method was deprecated when profiles were introduced (see eclipse-archived/smarthome#4108).
Instead the "follow profile" can be used which forwards item updates as commands to handlers.
This profile works with any binding instead of only those that implement the handleUpdate method.

Related to openhab/openhab-core#1669

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-24 17:50:47 +02:00
Wouter BornandGitHub 4d67ef2a6b Apply Spotless on disabled add-ons (#8568)
This should make it easier to fix these broken add-ons and the PRs that fix them will then not contain all these changes which make them easier to review.

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-24 15:02:38 +02:00
Wouter BornandGitHub 6b4839ea7d [avmfritz] Reenable itest (#8567)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-24 14:51:11 +02:00
Wouter BornandGitHub 5594150e54 [ntp] Reenable itest (#8565)
With these changes and working channelLink events (openhab/openhab-core#1634) the ntp itest works again.

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-24 08:42:12 +02:00
Wouter BornandGitHub 5d729d923a [feed] Reenable itest (#8564)
With these changes and working channelLink events (openhab/openhab-core#1634) the feed itest works again.

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-24 08:41:46 +02:00
Wouter BornandGitHub 12bef45ff8 Remove deprecated ConfigOptionProvider.getParameterOptions method (#8556)
Related to openhab/openhab-core#1667

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-23 11:28:23 -07:00
Wouter BornandGitHub f156a80d2f Fix BaseThingHandler.initialize() deprecations (#8553)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-23 13:32:46 +02:00
Wouter BornandGitHub 99461f26b3 Reenable MapTransformationServiceTest (#8533)
Depends on openhab/openhab-core#1661

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-22 14:30:42 +02:00
Wouter BornandGitHub 1f7da6b669 Fix ConfigurableService deprecations (#8526)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-22 08:48:05 +02:00
Wouter BornandGitHub c82f6c4e77 Fix and reenable more integration tests (#8535)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-22 08:19:04 +02:00
Wouter BornandGitHub 5297ac2524 [imperihome] Adapt call to ZDT in Persistence API (#8527)
Fixes #8290

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-21 23:35:31 +02:00
Wouter BornandGitHub 0c11a21d90 Fix ConfigConstants deprecations (#8525)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-21 22:57:04 +02:00
Wouter BornandGitHub 7f39d01a0f Remove/ignore Eclipse project files (#8529)
Fixes #8451

Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-21 22:50:37 +02:00
Wouter BornandGitHub bd82ca82df Migrate tests to JUnit 5 (#8519)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-09-21 18:21:26 +02:00