Commit Graph
100 Commits
Author SHA1 Message Date
Wouter BornandGitHub a490f0626c Upgrade to Karaf 4.3.4 (#11750)
* Syncs the karaf.version so the new Maven plugin is used
* Resolves itest runbundles for the new runtime dependencies

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-18 13:01:38 +01:00
Wouter BornandGitHub ccddf85c2a [jsscripting] Add default translations (#11798)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-16 20:06:50 +01:00
Wouter BornandGitHub 7a319bd0ad [samsungtv] Rename German translations file (#11799)
While uploading the German translations I noticed the file had a different name.
Renaming it prevents us ending up with 2 German translations files once all the texts are translated in German.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-16 20:04:40 +01:00
Wouter BornandGitHub 07a1976c81 Add default translations for binding add-ons (#11760)
* Add default translations for binding add-ons

This makes the texts used by these add-ons translatable with Crowdin.

To keep the PR simple, it only adds default translations for add-ons which do not yet have any default translations properties file.
We can do follow up PRs for adding missing key/values to add-ons that already have these files or to remove duplications.

There are several add-ons in this PR that do have non-English translation files, so I'll upload those to Crowdin when the PR is merged.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-15 18:40:21 +01:00
Wouter BornandGitHub e752b51662 Add default translations for io add-ons (#11753)
* Add default translations for io add-ons

This makes the texts used by these add-ons translatable with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-12 19:32:51 +01:00
Wouter BornandGitHub e7849c0060 Add default translations for persistence add-ons (#11754)
This makes the texts used by these add-ons translatable with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-11 18:02:00 +01:00
Wouter BornandGitHub 1b3818c329 Add default translations for transform add-ons (#11755)
This makes the texts used by these add-ons translatable with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-11 18:01:29 +01:00
Wouter BornandGitHub e4b0d3f7ac [plugwise] Fix 'power' channel not correctly updated with power production (#11746)
This fixes the issue that the 'power' channel would not update with the correct state because the number of pulses in the PowerInformationResponseMessage is signed instead of unsigned.
When the binding detected these strange readings it would normally log: "Circle (...) is in a kind of error state ...".

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-11 10:56:48 +01:00
Wouter BornandGitHub 2726a7ab71 Resolve runbundles for Whiteboard downgrade (#11744)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-11 10:01:40 +01:00
Wouter BornandGitHub fccfae81ee [pollytts] Add default translations properties file (#11728)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-07 17:47:53 +01:00
Wouter BornandGitHub 4ee2b6e1bb [dsmr] Add missing English translations (#11713)
Without these English defaults Crowdin would remove Dutch translations.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-05 22:12:41 +01:00
Wouter BornandGitHub 7c5e252ed7 [mqtt] Add missing English translations (#11714)
Without these English defaults Crowdin would remove German translations.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-05 22:07:39 +01:00
Wouter BornandGitHub b097463d7e Rename English i18n properties to follow Crowdin naming conventions (#11709)
This allows these files to be used for creating translations with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-05 20:14:44 +01:00
Wouter BornandGitHub bb10e342ab Remove unnecessary executable permissions (#11710)
These files are marked as executable for no good reason at all.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-05 19:29:44 +01:00
Wouter BornandGitHub 2f035b53b6 Add i18n-maven-plugin dependency (#11648)
When the plugin dependency is managed you can also use the plugin without adding GAV parameters to commands.

E.g. it allows for using it with:

```
mvn i18n:generate-default-translations
```

Signed-off-by: Wouter Born <github@maindrain.net>
2021-12-01 18:53:01 +01:00
Wouter BornandGitHub a45b40d6c3 Update bnd to 6.1.0 (#11650)
For release notes, see:

https://github.com/bndtools/bnd/wiki/Changes-in-6.1.0

Related to openhab/openhab-core#2583

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-28 21:58:08 +01:00
Wouter BornandGitHub 84de053847 Use Maven 3.8.4 in GHA CI builds (#11649)
This new version fixes a few regressions, see:

https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12350685

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-28 19:32:50 +01:00
Wouter BornandGitHub 1afe90d314 Report SAT Errors with GHA Annotations (#11652)
Let's test the GHA annotations for errors also in this repo!

Similar to openhab/openhab-core#2543

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-28 19:31:53 +01:00
Wouter BornandGitHub 73ed075d4e [lifx] Improve InterruptedException handling (#11653)
When the binding is stopped sleeping threads are interrupted by design.
By throwing the InterruptedException, it should be caught in LifxSelectorUtil.sendPacket (which is waiting for the packet interval to elapse), which will then abort sending a packet.

This prevents:

```
[ERROR] [lifx.internal.util.LifxThrottlingUtil] - An exception occurred while putting the thread to sleep : 'sleep interrupted'
```

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-28 16:37:29 +01:00
Wouter BornandGitHub e223c599c0 Resolve runbundles for JUnit and Mockito dependency upgrades (#11617)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-23 23:05:09 +01:00
Wouter BornandGitHub aff059b9b6 [nest] Fix place holders issue (#11622)
When the docs are generated any {{ }} constructs are substituted with variables.
As a result the docs are less easy to understand.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-21 17:52:32 +01:00
Wouter BornandGitHub d4d13fb74e [googletts] Fix place holders issue (#11623)
When the docs are generated any {{ }} constructs are substituted with variables causing the place holders to get lost.
As a result the docs are less easy to understand.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-21 17:51:43 +01:00
Wouter BornandGitHub 926240770b Resolve runbundles for UoM dependency upgrades (#11610)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-21 12:40:56 +01:00
Wouter BornandGitHub e6fd01d2ab Update Jackson version to 2.12.5 (#11609)
This is the version used in the feature provided by openhab-core.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-21 10:22:28 +01:00
Wouter BornandGitHub 163a34fca4 Add missing bundles to openhab-addons BOM (#11605)
Missing bundles in this BOM can cause issues like:

* Karaf feature projects building before bundle add-on projects completed
* Incremental build issues
* Other projects using the BOM having to manually add dependency management for these bundles

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-19 16:45:59 +01:00
Wouter BornandGitHub 2973f6d890 [jrubyscripting] Fix Maven project name (#11590)
It was missing the "Bundles" parts like used in other projects.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-15 15:39:27 +01:00
Wouter BornandGitHub 585a671e36 Use POM packaging with index BOMs (#11520)
Looks like only the POM dependencies are used by the indexer, so the JAR is unused and useless as this warning correctly indicates when you build them:

```
[WARNING] JAR will be empty - no content was marked for inclusion!
```

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-13 13:44:37 +01:00
Wouter BornandGitHub d4510f3fef Always run OSGi HTTP service on random port in itests (#11523)
It is probably always a good idea to run the OSGi HTTP service on a random available port in itests.
So when this is always done it prevents future issues and removes a bit of duplication.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-06 10:13:40 +01:00
Wouter BornandGitHub 42b6a19d3d Fix wrong build result when single add-on build fails (#11522)
Fixes the issue that single add-on builds that fail are not marked as such in GitHub Actions.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-05 18:42:16 +01:00
Wouter BornandGitHub 0ae2a2b751 Suppress bnd warnings for unused imports/exports (#11513)
Ignores warnings like:

```
Warning:  /home/runner/work/openhab-addons/openhab-addons/bom/runtime-index/pom.xml [0:0]: Unused Export-Package instructions: [org.openhab.*]
Warning:  /home/runner/work/openhab-addons/openhab-addons/bom/runtime-index/pom.xml [0:0]: Unused Import-Package instructions: [io.swagger.v3.oas.annotations.*,
```

These are safe to ignore because the import/export packages are globally defined and not every bundle imports/exports all these packages.

The `skipIfEmpty` configuration furthermore prevents warnings when the bnd-maven-plugin runs on projects that don't have any code like BOMs.

More important compiler/SAT warnings standout more when there are there are fewer useless warnings.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-05 13:56:58 +01:00
Wouter BornandGitHub 49aa537036 GitHub Actions workflow improvements (#11507)
* Checkout merged branches for pull requests
* Add support for incremental add-on builds to speed up PR builds
* Echo the mvn command used for builds

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-04 09:05:39 +01:00
Wouter BornandGitHub e37fabac67 Configure default timeout of 15 minutes for all testable and lifecycle methods (#11505)
This helps to identify what tests cause builds to get stuck and it will more quickly end such builds.
When builds get stuck in tests, they would keep running for hours and then eventually when a timeout occurs, the job is killed without knowing why it got stuck.
Furhermore precious Jenkins executors will not keep being occupied by such jobs.

See: https://junit.org/junit5/docs/current/user-guide/#writing-tests-declarative-timeouts

It helps with identifying the root cause of issues like https://github.com/openhab/openhab-core/pull/2551

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-03 21:15:31 +01:00
Wouter BornandGitHub 93fe919f49 Upgrade SAT to 0.12.0 (#11494)
See the [0.12.0 milestone](https://github.com/openhab/static-code-analysis/milestone/18?closed=1) for all changes in this release.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-02 13:57:00 +01:00
Wouter BornandGitHub 589400e223 Fix/suppress PMD CompareObjectsWithEquals findings (#11476)
Newer PMD versions discover more CompareObjectsWithEquals findings.

Related to https://github.com/openhab/static-code-analysis/pull/423

Signed-off-by: Wouter Born <github@maindrain.net>
2021-11-02 10:43:53 +01:00
Wouter BornandGitHub 1eb4902511 [luxtronikheatpump] Add default translations properties file (#11479)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-10-31 10:11:17 +01:00
Wouter BornandGitHub 03e2303800 Add GitHub Actions CI build (#11454)
This PR adds a CI build using GitHub Actions.
Besides having a backup for Jenkins, it will also make it easy for contributors to use a GitHub Actions build with their fork.

It features the following:

* Uncluttered simple build progress like we used with Travis CI
* Uploads the full build log and SAT summary report so they can be downloaded for further analysis
* Uses a Maven repository cache to speed up builds (first build takes a bit longer)
* Has some maven.wagon configuration options to prevent Maven Central artifact download issues from Azure
* Uses a matrix so we can easily add builds for other OS-es or newer Java LTS versions in the future

Signed-off-by: Wouter Born <github@maindrain.net>
2021-10-27 09:55:00 +02:00
Wouter BornandGitHub b15433d0b7 Resolve runbundles for JAX-RS Whiteboard and CXF upgrades (#11421)
Related to openhab/openhab-core#2532

Signed-off-by: Wouter Born <github@maindrain.net>
2021-10-25 17:47:36 +02:00
Wouter BornandGitHub a9fd3f23c4 Update imports to use JUnit 5 instead of JUnit 4 (#11425)
* Update imports to use JUnit 5 instead of JUnit 4
* Add commonly used JUnit 4 classes to forbidden packages

Related to: https://github.com/openhab/openhab-core/pull/2534

Signed-off-by: Wouter Born <github@maindrain.net>
2021-10-24 10:36:47 +02:00
Wouter BornandGitHub 81e201d163 [lifx] Add missing products (#11405)
Adds the products with IDs 93, 112, 113, 114 so that they can be discovered and the right features are available.

Fixes #11402

Signed-off-by: Wouter Born <github@maindrain.net>
2021-10-18 20:37:46 +02:00
Wouter BornandGitHub d4e15bfbd6 Remove deprecated XStream.setupDefaultSecurity calls (#11365)
The XStream.setupDefaultSecurity method is deprecated since XStream 1.4.18.
It no longer does anything, because this is the default in newer XStream versions.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-10-10 20:30:07 +02:00
Wouter BornandGitHub 3253fbece8 Align translation filenames with Crowdin (#11362)
Crowdin is configured to generate translations for languages without countries.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-10-10 11:02:53 +02:00
Wouter BornandGitHub 82f76b6c96 [ntp] Add default translations properties file (#11363)
This allows for translating the NTP Binding strings with Crowdin.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-10-10 10:52:39 +02:00
Wouter BornandGitHub 2b5431df00 [rrd4j] Upgrade rrd4j, improve exception handling (#11355)
* Upgrades rrd4j to 3.8
* Fixes deprecations
* Updates RRD4jChartServlet for ChartProvider API changes
* Improves RRD4jChartServlet exception handling

For the rrd4j changelog see:

https://raw.githubusercontent.com/rrd4j/rrd4j/master/changelog.txt

Related to openhab/openhab-core#2502

Signed-off-by: Wouter Born <github@maindrain.net>
2021-10-09 21:56:09 +02:00
Wouter BornandGitHub 5132d939c6 Update bnd to 6.0.0 (#11359)
For release notes, see:

https://github.com/bndtools/bnd/wiki/Changes-in-6.0.0

Related to openhab/openhab-core#2514

Signed-off-by: Wouter Born <github@maindrain.net>
2021-10-09 19:57:33 +02:00
Wouter BornandGitHub 798abaa4ca Switch properties files encoding from ISO-8859-1 to UTF-8 (#11349)
* Switch properties files encoding from ISO-8859-1 to UTF-8

Crowdin will generate translations in this encoding, so this prevents a lot of diffs which makes it easier to review future Crowdin PRs.

Related to openhab/openhab-core#2298

Signed-off-by: Wouter Born <github@maindrain.net>
2021-10-09 19:56:49 +02:00
Wouter BornandGitHub 89ef91bad3 [lifx] Add channels for controlling absolute color temperature in Kelvin (#11309)
* [lifx] Add channels for controlling absolute color temperature in Kelvin

Adds an 'abstemperature' channel to all Thing Types for controlling the absolute color temperature in Kelvin.
MultiZone lights also have 'abstemperaturezone' channels that allow for controlling the color temperature of a zone in Kelvin.
These channels make it easier to use the same color temperature with lights that have a different color temperature range.
Furthermore the channel type tags have been updated which simplifies using the generated items with the semantic model.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-09-27 22:00:01 +02:00
Wouter BornandGitHub 2f4a27217f Fix/remove outdated "Default Tags" (#11313)
There used to be the following "Default Tags" which are no longer used in the current semantic model:

* Lighting
* Switchable
* CurrentTemperature
* TargetTemperature
* CurrentHumidity

See:

* https://www.openhab.org/docs/developer/bindings/thing-xml.html#default-tags
* https://www.openhab.org/docs/tutorial/model.html#semantic-model

Signed-off-by: Wouter Born <github@maindrain.net>
2021-09-27 07:33:56 +02:00
Wouter BornandGitHub 1f18dda301 [modbus] Remove helioseasycontrols binding.xml causing binding identification issues (#11281)
There should only be one binding.xml file for each binding.

Fixes #8973

Signed-off-by: Wouter Born <github@maindrain.net>
2021-09-22 08:35:06 +02:00
Wouter BornandGitHub 36b6b5b8c8 [metrics] Fix configuration PID and add file based configuration example (#11280)
Fixes #11279

Signed-off-by: Wouter Born <github@maindrain.net>
2021-09-22 08:34:09 +02:00
Wouter BornandGitHub 20f8a56560 [systeminfo] Upgrade OSHI dependency for latest fixes/improvements (#11274)
Upgrades OSHI from 4.5.2 to 5.8.2.

For all OSHI fixes and improvements, see:

https://github.com/oshi/oshi/blob/master/CHANGELOG.md#580-2021-07-18-581-2021-08-22-582-2021-09-05

Signed-off-by: Wouter Born <github@maindrain.net>
2021-09-20 14:49:32 +02:00
Wouter BornandGitHub 344011c2ad [lifx] Support HEV clean cycle (#11262)
* Implement HEV packets
* Add colorhevlight thing type with a hevcycle channel
* Update documentation

Signed-off-by: Wouter Born <github@maindrain.net>
2021-09-19 11:45:06 +02:00
Wouter BornandGitHub 4aa1f14600 Upgrade to Karaf 4.3.3 (#11261)
* Syncs the karaf.version so the new Maven plugin is used
* Resolves itest runbundles for the new runtime dependencies

Signed-off-by: Wouter Born <github@maindrain.net>
2021-09-18 19:33:18 +02:00
Wouter BornandGitHub 30198e273a [metrics] Add Java Management Extensions (JMX) metrics exporter (#11249)
* Add Java Management Extensions (JMX) metrics exporter
* Use groups in metrics add-on configuration
* Improve null annotations
* Update documentation

Signed-off-by: Wouter Born <github@maindrain.net>
2021-09-16 09:11:12 +02:00
Wouter BornandGitHub ba3a9bb01a [groovyscripting] Update Groovy to 3.0.9 (#11251)
For all bugfixes and improvements, see:

http://groovy-lang.org/changelogs/changelog-3.0.9.html

Signed-off-by: Wouter Born <github@maindrain.net>
2021-09-15 19:02:17 +02:00
Wouter BornandGitHub 088e2f08ab Resolve runbundles for XStream upgrade (#11236)
Related to openhab/openhab-core#2482

Signed-off-by: Wouter Born <github@maindrain.net>
2021-09-12 11:44:58 +02:00
Wouter BornandGitHub 6c3e937f02 [lifx] Add missing color feature to a few products (#11180)
Updates the LIFX Candle (PID 68) and LIFX Clean (PID 90, 99) products to support color features.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-08-31 19:43:38 +02:00
Wouter BornandGitHub 4378e95acc Update OH version in skeleton scripts (#10910)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-06-28 11:00:31 +02:00
Wouter BornandGitHub 39c4cd0a4d Fix build (#10892)
Caused by https://github.com/openhab/openhab-addons/pull/10890

Signed-off-by: Wouter Born <github@maindrain.net>
2021-06-21 11:50:14 +02:00
Wouter BornandGitHub 6296eba14c [nest] Add support for Smart Device Management (SDM) API (#8947)
* [nest] Add support for Smart Device Management (SDM) API

* Reworks WWN implementation so that the thing types have a wwn_ prefix and the classes have a WWN prefix and reside in a 'wwn' package
* Adds an SDM implementation which is also based on: https://github.com/bhigg-code/openhab-addons/tree/2.5.x/bundles/org.openhab.binding.nestdeviceaccess
* Adds unit tests for (de)serialization of the SDM and Pub/Sub API requests and responses
* Updates the binding documentation for the changes and additions

Fixes #8664

Also-by: Brian Higginbotham <brianhigginbothamtx@gmail.com>
Signed-off-by: Wouter Born <github@maindrain.net>

* Fix and improve documentation

Signed-off-by: Wouter Born <github@maindrain.net>

* Always use UTF8 when decoding SDM events

Signed-off-by: Wouter Born <github@maindrain.net>
2021-06-20 19:59:46 +02:00
Wouter BornandGitHub 27d5bb11c7 Resolve itest runbundles for XStream upgrade (#10713)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-21 07:34:47 +02:00
Wouter BornandGitHub 7aab765b5a [groovyscripting] Update Groovy to 3.0.8 (#10721)
For all bugfixes and improvements, see:

http://groovy-lang.org/changelogs/changelog-3.0.8.html

Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-20 20:25:29 +02:00
Wouter BornandGitHub a032118213 Fix build and improve exception handling (#10726)
The PercentType and QuantityType can also throw an IllegalArgumentException.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-20 19:15:23 +02:00
Wouter BornandGitHub 7d2c8755eb Upgrade to Karaf 4.3.2 (#10693)
* Syncs the karaf.version so the new Maven plugin is used
* Resolves itest runbundles for the new runtime dependencies

Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-18 07:37:57 +02:00
Wouter BornandGitHub e1a76505a0 Update Jackson version to 2.12.3 (#10669)
This is the version used in the feature provided by openhab-core.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-13 09:49:08 +02:00
Wouter BornandGitHub 183fb0e390 [modbus] Cleanup workaround leftovers and fix a few SAT findings (#10670)
- Cleanup workaround leftovers and fix a few SAT findings

Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-12 13:15:24 +02:00
Wouter BornandGitHub c3a6aa5814 Upgrade Units of Measurement dependencies (#10583)
* Fix code/tests for upgrade
* Resolve runbundles
* Update Checkstyle ruleset for changed packages

Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-11 08:31:03 +02:00
Wouter BornandGitHub cfea5a2185 Update remaining Paper UI and HABmin references (#10637)
Fixes #8607

Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-06 22:26:05 +02:00
Wouter BornandGitHub f907bf37f9 [jsscripting] Fix build and cleanup (#10654)
Related to #8516

Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-06 22:19:59 +02:00
Wouter BornandGitHub 940e1e53d1 Use activation-api 1.2.1_3 (#10646)
Fixes #10642

Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-05 21:08:09 +02:00
Wouter BornandGitHub f5f922eaf4 Fix or suppress SAT CompareObjectsWithEquals findings (#10631)
* Fix or suppress SAT CompareObjectsWithEquals findings

Signed-off-by: Wouter Born <github@maindrain.net>
2021-05-05 21:06:04 +02:00
Wouter BornandGitHub e6d8dfb7e1 Reduce dependency on commons-io and commons-codec (#10614)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-30 16:53:44 +02:00
Wouter BornandGitHub e74cb82be7 Fix Crowdin URL in issue template configuration (#10616)
The URL is: https://crowdin.com/project/openhab-addons

Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-29 18:57:45 +02:00
Wouter BornandGitHub aaeddc8119 Update Netty dependencies to 4.1.63.Final (#10606)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-28 12:22:11 +02:00
Wouter BornandGitHub 8397f938b3 Resolve runbundles for Aries JAX-RS Whiteboard upgrade (#10575)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-25 15:54:43 +02:00
Wouter BornandGitHub b42101addc Remove unused local variables (#10528)
Fixes 26 SAT UnusedLocalVariable findings

Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-16 22:35:01 +02:00
Wouter BornandGitHub 1633c705a1 Use Collection.isEmpty (#10525)
Fixes 47 SAT UseCollectionIsEmpty findings.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-15 21:00:47 +02:00
Wouter BornandGitHub 0c36650179 Avoid star imports and add missing braces (#10521)
Fixes the following SAT findings:

* AvoidStarImportCheck (125)
* NeedBracesCheck (39)

Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-15 16:12:05 +02:00
Wouter BornandGitHub 5d99a7f524 [dsmr] Use ThingHandlerService for discovery (#9044)
This simplifies the DSMRHandlerFactory code so it no longer needs to register and keep track of a discovery service for each bridge.

Also contains a few other improvements:

* more constructor injection
* add a few missing @NonNullByDefault on test classes

Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-08 22:49:14 +02:00
Wouter BornandGitHub f166220068 Resolve runbundles for Xtext upgrade (#10481)
Related to openhab/openhab-core#2278

Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-08 22:07:46 +02:00
Wouter BornandGitHub 260d6ba083 Upgrade Karaf to 4.3.1 (#10424)
* Upgrades Karaf to 4.3.1
* Uses Pax Logging as runtime dependency instead of Felix Log
  To change the log level in itests, change the value of org.ops4j.pax.logging.DefaultServiceLog.level in itest-include.bndrun
* Adds --add-opens and nashorn.args in itest-include.bndrun to prevent some warnings being logged in itests

Related to openhab/openhab-distro#1167

Signed-off-by: Wouter Born <github@maindrain.net>
2021-04-02 20:00:30 +02:00
Wouter BornandGitHub 1fa1f54272 [picotts] Add null annotations (#10392)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-27 18:34:00 +01:00
Wouter BornandGitHub 6e1119a49a Fix broken configfile GAV with karaf:kar (#10391)
The groupId variable results in the wrong configfile GAV when building a single KAR with karaf:kar for an add-on.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-26 08:50:31 +01:00
Wouter BornandGitHub 1d34872c61 [lifx] Improve firmware version support (#10384)
* [lifx] Improve firmware version support

When the firmware of a light is upgraded the supported features can change.
With these changes the binding uses the features based on the light firmware version.
Also corrects some of the temperature ranges based on the LIFX products description.

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-24 23:39:34 +01:00
Wouter BornandGitHub fe0c35d22f Fix Java and Jetty deprecations (#10349)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-19 10:40:14 +01:00
Wouter BornandGitHub 580f293766 Resolve itest runbundles for Gson and Commons Lang upgrades and fix JsonParser deprecations (#10345)
* Resolve itest runbundles for Gson and Commons Lang upgrades
* Fix JsonParser deprecations too
* Fix feature verification

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-18 12:15:15 +01:00
Wouter BornandGitHub f3503430b4 Rework more commons-lang usages (#10314)
* Reworks many commons-lang usages to use standard Java
* Updates all remaining commons.lang imports to commons.lang3

Related to openhab/openhab-addons#7722

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-16 12:38:16 +01:00
Wouter BornandGitHub ee59803df8 Remove org.jetbrains.annotations.NotNull (#10334)
Only Eclipse JDT annotations should be used, see:

https://www.openhab.org/docs/developer/guidelines.html#null-annotations

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-14 23:22:52 +01:00
Wouter BornandGitHub f3a517e4e1 [lifx] Fix all SAT findings (#10307)
* Remove dependency on commons-lang classes
* Use HexUtils
* Fix/add missing initial contribution author lines
* Add unit test for MACAddress
* Rename protocol package to dto

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-10 09:52:39 +01:00
Wouter BornandGitHub 051c764789 Upgrade Jackson to 2.12.2 (#10288)
* Adds a jackson.version property to simplify managing the version
* Make sure the specified version is used as add-on dependency by excluding Jackson from transitive dependencies
* Use openhab.tp-jackson feature with dynamodb
* Remove jackson-dataformat-cbor dependency from features which is now also provided by the openhab.tp-jackson feature

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-07 10:19:32 +01:00
Wouter BornandGitHub f2eea9ea0f Improve CODEOWNERS (#10289)
* Fix wrong username
* Remove modbus transport

Signed-off-by: Wouter Born <github@maindrain.net>
2021-03-06 16:47:12 +01:00
Wouter BornandGitHub 9c112a9a1d Update bnd to 5.3.0 (#10257)
See: https://github.com/bndtools/bnd/wiki/Changes-in-5.3.0

Related to https://github.com/openhab/openhab-core/pull/2217

Signed-off-by: Wouter Born <github@maindrain.net>
2021-02-28 21:33:41 +01:00
Wouter BornandGitHub f926cd8080 Add POM and feature dependencies for commons-net (#9940)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-25 13:45:12 +01:00
Wouter BornandGitHub 05c16b0395 Fix links and NOTICE files (#9860)
* Updates links to target the openhab-addons 'main' branch instead of the 'master' branch
* Updates some NOTICE files to indicate content is maintained by openHAB instead of Eclipse SmartHome

Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-18 21:49:06 +01:00
Wouter BornandGitHub 59dffd03a4 Resolve itests for BOM changes (#9828)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-15 22:09:59 +01:00
Wouter BornandGitHub 0f118c6b7e Update bnd to 5.2.0 (#9785)
See: https://github.com/bndtools/bnd/wiki/Changes-in-5.2.0

Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-12 22:02:35 +01:00
Wouter BornandGitHub 0816045a59 Update Mockito, JUnit and use MockitoExtensions in itests (#9702)
* Updates Mockito to 3.7.0
* Updates JUnit to 5.7.0
* Use MockitoExtensions where possible

Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-06 14:30:40 +01:00
Wouter BornandGitHub 8f84646ed1 [groovyscripting] Update Groovy to 3.0.7 and add more docs (#9708)
Fixes #8951

Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-06 08:46:43 +01:00
Wouter BornandGitHub d6364aceb1 Update license headers to 2021 (#9620)
Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-02 22:03:14 +01:00
Wouter BornandGitHub d1ef41851c [modbus] Disable unstable ModbusDataHandlerTest#testRefreshOnData itest (#9653)
Related to #9617

Signed-off-by: Wouter Born <github@maindrain.net>
2021-01-02 17:58:21 +01:00
Wouter BornandGitHub 075b7265c0 Resolve itest runbundles for XStream 1.4.15 (#9489)
Signed-off-by: Wouter Born <github@maindrain.net>
2020-12-24 00:58:48 +01:00