Commit Graph

73 Commits

Author SHA1 Message Date
Holger Friedrich edaf17b345
Java 17 features (H-M) (#15520)
- add missing @override
- Java style array syntax
- remove redundant modifiers
- always move String constants to left side in comparisons
- simplify lambda expressions and return statements
- use replace instead of replaceAll w/o regex
- instanceof matching and multiline strings
- remove null check before instanceof

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-09-08 14:36:59 +02:00
Kai Kreuzer 72607d3bee Apply spotless
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2023-07-24 01:20:31 +02:00
openhab-bot 809fceaff3 [unleash-maven-plugin] Preparation for next development cycle. 2023-07-23 19:19:01 +00:00
openhab-bot 37c0e97bff
New Crowdin updates (#15281)
* New translations miele.properties (Danish)
* New translations miele.properties (German)
2023-07-21 12:39:37 +02:00
Jacob Laursen 4fcff61a72
Update default translations (#15280)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2023-07-21 11:34:30 +02:00
Jacob Laursen a5b028d729
[miele] Declare connection (#14683)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2023-03-26 16:26:24 +02:00
openhab-bot a3c621fffc
New Crowdin updates (#14541)
* New translations iCloud.properties (German)
* New translations miele.properties (German)
* New translations jruby.properties (German)
* New translations mqtt.properties (German)
* New translations influxdb.properties (German)
* New translations homekit.properties (German)
* New translations amazonechocontrol.properties (German)
* New translations amazonechocontrol.properties (German)
2023-03-05 20:25:51 +01:00
J-N-K 89d0689e36
fix i18n for bindings (#14235)
Also-By: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-21 12:14:51 +01:00
J-N-K 5f8214f08a
Adapt to core changes (addon.xml) (#13289)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2023-01-15 20:31:42 +01:00
Jacob Laursen f4268c4964
Improve multicast implementation (#14199)
Fixes #14198

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2023-01-14 12:26:38 +01:00
Holger Friedrich 4e44de3894
Fix SAT warnings (#14202)
* Fix SAT warnings

- checkstyle.ModifierOrderCheck
- checkstyle.OneStatementPerLineCheck
- checkstyle.NeedBracesCheck
- PMD.UseStandardCharsets
- PMD.UseCollectionIsEmpty
- PMD.UnusedLocalVariable
- PMD.SimplifyBooleanReturns where reasonable, suppress where
readability is better without change
- PMD.SimplifyBooleanExpressions

* Include StandardCharsets

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2023-01-13 08:11:06 +01:00
Jacob Laursen 4dd6d3a8a2
Update license headers to 2023 (#14154)
* Update copyright year in configuration
* Update license headers

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2023-01-06 09:49:54 +01:00
Jacob Laursen 470ada241a
[miele] Add categories and semantic tags (#14086)
* Add categories and tags

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-31 15:01:11 +01:00
Jacob Laursen 68ecfa724e
Rename handler to fix case and make consistent with corresponding channel selector (#14095)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-29 20:07:31 +01:00
J-N-K 4d6d6443ef
fix spotless after release (#14014)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-12-19 15:22:17 +01:00
openhab-bot 7993786dc9 [unleash-maven-plugin] Preparation for next development cycle. 2022-12-19 00:55:11 +00:00
Jacob Laursen 6753234e32
Fix Zigbee name stylization (#13954)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-17 17:25:38 +01:00
Jacob Laursen bd087f1c1c
Fix examples after migration of time channels (#13933)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-12 22:55:38 +01:00
Jacob Laursen 518272a731
Fix dimension for powerConsumption channel (#13930)
Fixes #13929

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-12 22:10:48 +01:00
Jacob Laursen c09be1bfbe
Migrate time channels from DateTime to Number:Time (#13841)
Fixes #13840

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-10 23:05:59 +01:00
Jerome Luckenbach 0e68936663
[Documentation] Markdown improvements f to m (#13866)
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
2022-12-08 21:36:05 +01:00
openhab-bot 93633a9af9
New Crowdin updates (#13848)
* New translations miele.properties (Danish)
* New translations jruby.properties (Italian)
* New translations ecowatt.properties (Italian)
* New translations webexteams.properties (Italian)
2022-12-05 15:56:34 +01:00
Jacob Laursen af0ac6e474
[miele] Migrate start channel to full DateTime channel and add end channel (#13393)
* Migrate start/finish channels to full DateTime channels
* Unmark start and duration as advanced channels
* Add end channel

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-09-25 11:29:26 +02:00
openhab-bot 572d1ec6f0
New Crowdin updates (#13157)
* New translations miele.properties (Danish)
* New translations miele.properties (German)
2022-07-21 15:53:16 +02:00
Jacob Laursen d2670e40cb
[miele] Allow hostname as gateway network address (#13147)
* Allow hostname as gateway network address
* Document configuration parameters for things
* Add message for bridge communication error

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-07-20 16:13:16 +02:00
Jacob Laursen cc3f9eac91
[miele] Fix auto-update for stop channel and synchronize switch channel with appliance state (#13071)
* Fix auto-update policy for stateless channel
* Reflect appliance state in switch channel state

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-07-05 08:05:21 +02:00
Kai Kreuzer 440f603e88
Apply spotless and resolver (#13027)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2022-06-27 16:00:37 +02:00
openhab-bot ed4858ebbb [unleash-maven-plugin] Preparation for next development cycle. 2022-06-26 18:18:40 +00:00
openhab-bot 6aea2a9444
New Crowdin updates (#12907)
* New translations miele.properties (German)

* New translations remoteopenhab.properties (German)

* New translations mqtt.properties (German)

* New translations metrics.properties (German)

* New translations boschindego.properties (German)

* New translations gpstracker.properties (German)

* New translations onkyo.properties (German)

* New translations tado.properties (German)

* New translations telegram.properties (German)

* New translations jruby.properties (German)

* New translations bluetooth.properties (German)

* New translations bluetooth.properties (German)

* New translations bluetooth.properties (German)

* New translations bluetooth.properties (German)

* New translations bluetooth.properties (German)

* New translations bluetooth.properties (German)

* New translations bluetooth.properties (German)

* New translations bluetooth.properties (German)

* New translations bluetooth.properties (German)

* New translations imperihome.properties (German)
2022-06-09 08:08:51 +02:00
openhab-bot d938341ba7
New Crowdin updates (#12810)
* New translations miele.properties (Danish)
* New translations netatmo.properties (Italian)
2022-05-25 22:16:01 +02:00
Jacob Laursen cc43251b5d
Fix logging for appliances where consumption data is not supported (#12728)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-05-12 23:12:32 +02:00
Jacob Laursen 8c6534300a
[miele] Use framework's HTTP client (#12545)
* Refactor to use framework's Jetty HTTP client
* Do not try to parse HTML as JSON on failed HTTP calls
* Improve handler initialization log messages

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-03-30 07:03:46 +02:00
Jacob Laursen 2d3f0d68c0
[miele] Fix configuration validation and optimize performance (#12510)
* Update bridge status to UNKNOWN before scheduling polling job
* Reduced error log levels to warning
* Validate configuration and leave initialize() with status UNKNOWN
* Extract JSON-RPC handling to separate class
* Use already stored applianceId
* Keep listeners in Set to eliminate duplicates and improve performance
* Reduce access levels for variables exposed to subclasses unneededly
* Initialize translation provider with default language in constructor to avoid nullness
* Divide listener interface into two: discovery and appliance status
* Optimize communication between bridge and handlers
* Fix thing status transitions and support gone appliances
* Do not check/schedule jobs for each listener registration
* Optimize listener registration by using cached appliances
* Optimize state/property updates and reduce logging level for properties
* Fix concurrency issue during handler initialization
* Simplify online/offline transitions
* Use cached appliances for discovery listener callback
* Avoid unneeded call every 15 seconds receiving response with ~5.5 KB payload
* Fix devices being removed after failed RPC calls
* Fix method parameter descriptions

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-03-28 07:14:55 +02:00
Jacob Laursen f21bbc5945
[miele] Add null annotations and improve error handling robustness (#12497)
* Add null annotations and improve error handling robustness
* Fix compliancy with rule ConstantNameCheck

Fixes #12496

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-03-21 16:49:03 +01:00
openhab-bot 5005dc002f
New Crowdin updates (#12392)
* New translations bluetooth.properties (Finnish)
* New translations danfossairunit.properties (Danish)
* New translations hdpowerview.properties (Danish)
* New translations jruby.properties (Italian)
* New translations miele.properties (Danish)
* New translations mqtt.properties (Italian)
* New translations openwebnet.properties (Italian)
2022-03-07 21:25:05 +01:00
Jacob Laursen 56a10af420
Consolidate properties for compliance. (#11997)
Fixes #11996

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-01-08 14:37:00 +01:00
Hilbrand Bouwkamp da59cdd255
Update license headers to 2022 (#11973)
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2022-01-06 18:14:47 +01:00
Jacob Laursen 5e3bddf4ed
[miele] Refactor mDNS discovery (#11873)
* Add nullness annotations.
* Fix error handling.
* Localize discovery result label.
* Reduce log level to warning for error creating discovery result.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-12-28 12:35:52 +01:00
Andrew Fiddian-Green e9060c462b
[miele] Fix mDNS issue where hub repeatedly disappears from, resp. reappears in, the Inbox. (#11834)
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2021-12-28 09:49:05 +01:00
Marcel cc47ef7f3e
pom update from http to https reference (#11833)
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
2021-12-23 19:40:44 +01:00
Kai Kreuzer 48746f5e3f Apply spotless
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2021-12-20 09:07:55 +01:00
openhab-bot 6dc031e6cf [unleash-maven-plugin] Preparation for next development cycle. 2021-12-20 00:30:46 +00:00
jlaur c71e5bd083
Reduce log level to TRACE for full request/response logging. (#11782)
Fixes #11781

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-12-14 17:32:29 +01:00
jlaur 33e751c437
[miele] Localization of state, program and phase (#11603)
* Initial changes for state, program and phase localization.
* Fix bridge configuration reload.
* Extracted DeviceMetaData from MieleBridgeHandler.
* Fix fallback to gateway text.
* Consolidate getMieleEnum in DeviceMetaData.
* Localize thing offline texts and increased accuracy.
* Validate language during bridge initialization.
* Interpret magic value for temperature.
* Add missing i18n channel label/description strings.
* Add missing washing machine phase texts in Dutch.
* Add missing French dishwasher phase texts.

Fixes #11602

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-11-29 08:16:08 +01:00
jlaur 745bf76569
[miele] Clean up properties and improve reliability and performance (#11423)
* Use appliance cache for getting full UID with protocol prefix instead of relying on property.
* Set bare protocol name as property.
* Fix potential null pointer access warnings.
* Remove unused import.
* Renamed property protocol to protocolAdapter for correctness.
* Add connectionType property.
* Add appliance model property.
* Remove useless properties brandId and companyId always having value MI.
* Rename property dc to deviceClass and set it consistently (not only from auto-discovered things).
* Added constants for remaining handlers with hardcoded device classes.
* Fix SCA: AuthorContributionDescriptionCheck
* Fix SCA: ModifierOrderCheck
* Rename ExtendedDeviceStateUtil to be a bit more generic.
* Extract device class string parsing to utility method.
* Fix SCA: ForbiddenPackageUsageCheck
* Fix redundant null check.
* Fix potential null pointer access warnings.
* Fix unsafe null type conversion (type annotations)
* Share same configuration (UID) for all appliance types.
* Refer to gateway instead of ZigBee network in configuration.
* Remove dependency to seriaNumber property for multicast channel updates.
* Simplified filtering of irrelevant device class.
* Remove devices from remoteUid cache also when disappearing from gateway, although this is a quite rare scenario.
* Add default i18n properties file.
* Add partial Danish translation.

Fixes #11422

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-11-01 18:44:19 +01:00
jlaur b893b07329
Fix too strict validation of ExtendedDeviceState number of bytes. (#11417)
Fixes #11416

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-10-21 21:54:40 +02:00
jlaur 406f9c1364
[miele] Document known programs and phases (#11377)
* Document known programs and phases.
* Clarify description for superfreeze.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-10-15 21:45:21 +02:00
jlaur 01c0b199fd
[miele] State/program/phase: Add raw channels and improve text channels (#11341)
* Add raw channels for state, program and phase.
* Provide program/phase texts when missing from XGW 3000 and for multicast.
* Consistent handling of missing program/phase text across all appliance types.
* Fix tumble dryer example configuration.
* Changed tumble dryer Finished phase text for consistency.

Fixes #11335

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-10-10 20:34:55 +02:00
jlaur 8d38276dce
[miele] Temperature channel improvements: UoM, categories and descriptions (#11329)
* Improvements for temperature channels

Fixes #11317

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Added jlaur as miele binding maintainer

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fix spinning speed for washing machines

Fixes #11317

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Added time as category for DateTime-related channels

Fixes #11317

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Elapsed/remaining time channels are no longer marked as advanced.

Fixes #11317

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fixed type for temperature item examples.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Document all states (cross-appliance).

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Improved error handling for getTemperatureState

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Split current/target temperature into two channel types for label reuse

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fix possible NullPointerException

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Distinguish between oven program temperatures

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Mark oven program temperature 1 and 2 as advanced.

Fixes #11317

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-10-02 19:57:22 +02:00
jlaur b28413c6f1
[miele] Fix supercool/superfreeze for fridges/fridge-freezers (#11321)
* Fix typos.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Do not expose getTypeClass through interface.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fix channel supercool for fridges and partially fix supercool/superfreeze for fridge-freezers.

Fixes #11320

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>

* Fix two-way channel synchronization for supercool/superfreeze for fridge-freezer.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2021-09-30 09:00:26 +02:00