Commit Graph

3118 Commits

Author SHA1 Message Date
Holger Friedrich 9318f6f336
[knx] Minor documentation update (#13918)
Slightly change wording of docs related to localSourceAddress to avoid
address conflicts during initial setup.
Add remark about knxd.
Fixes #13602.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2022-12-15 16:22:43 +01:00
Wouter Born 83f0f7aa4c
Prevent Markdown rendering issues in Main UI (#13958)
Some add-ons use `---` separators which causes issues when rendering the documentation in Main UI.

Fixes #13953

Signed-off-by: Wouter Born <github@maindrain.net>
2022-12-15 12:28:32 +01:00
Holger Friedrich 6ab0561382
[rrd4j] Error handling for broken rrd4j files (#13955)
* [rrd4j] Error handling for broken rrd4j files

Catch exceptions thrown by getDB(..) and print the name of the affected
database file. This allows to identify a broken rrd4j file.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2022-12-15 11:31:20 +01:00
Simon Spielmann 04f059c455
[icloud] Rework authentication to reflect changes in iCloud API (#13691)
* Implement Authentication (WIP)
* Validation Code accepted
* Refactor session state
* RefreshClient working
* Implement session persistence in openhab store
* Integration in binding
* Remove persistent cookies, which break authentication
* Bugfixing
* Add code configuration to UI
* Improve documentation, error-handling and cleanup
* Rework auth order
* Rework auth process
* Add 2-FA-auth to documentation
* Set bridge to online if data refresh works
* Case-sensitive rename ICloudAPIResponseException
* Include authentication in refresh flow
* Fix regression for data not being updated
* Fix typo in i18n props
* Fix review and checkstyle.
* More javadoc, new RetryException
* Introduce @NonNullByDefault
* Introduce server for RetryException, add NonNullbyDefault, fix warnings
* Rework for contribution, e.g. null checks, ...
* Fix checkstyle
* Move JsonUtils to utilities package
* Async initialize bridge handler.
* Report Device OFFLINE if Bridge is OFFLINE
* Set bridge thing status to UNKOWN in init
* Move refresh init into async init
* Cancel init task in dispose

Also-by: Leo Siepel <leosiepel@gmail.com>
Signed-off-by: Simon Spielmann <simon.spielmann@gmx.de>
2022-12-15 09:18:11 +01:00
Wouter Born 6e8b35c4c1
[jsscripting] Fix broken event object table (#13952)
The table is not properly rendered when reading the documentation in Main UI.

Signed-off-by: Wouter Born <github@maindrain.net>
2022-12-15 07:51:22 +01:00
Jørgen Austvik 79060f3c8f
[nanoleaf] Bugfix: Handle non-integer panel ids (#13951)
Panel ids are sometimes returned as BigInteger

We haven't been able to understand why this happens somewhere and
somewhere not, but this is an sledgehammer attempt to fix it quickly
to unblock users, and then we will try to understand it later.

Discussions:
https://community.openhab.org/t/java-lang-classcastexception-class-java-math-bigdecimal-cannot-be-cast-to-class-java-lang-integer/142035/16
https://community.openhab.org/t/nanoleaf-binding-oh3-stabilization-update/116300/61

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
2022-12-14 20:15:47 +01:00
Florian Hotze d4ec220925
[jsscripting] Extend synchronization to common ScriptEngine methods (#13924)
* [jsscripting] Extend synchronization to common ScriptEngine methods

This extends the multi-thread synchronization to "eval" and "invokeMethod" and moves synchronization for "invokeFunction" to the DelegatingScriptEngineWithInvocableAndAutocloseableAndSynchronization class. Fixes the multi-thread access requested warnings described in the community (https://community.openhab.org/t/openhab-3-4-milestone-discussion/138093/130) and related to https://github.com/openhab/openhab-core/pull/3180.

* Revert "[jsscripting] Extend synchronization to common ScriptEngine methods"

This reverts commit aadd21e45879c10aad29bf279ddbb0afd789b0aa.

* [jsscripting] Extend synchronization to common ScriptEngine methods & Switch to ReentrantLock

This extends the multi-thread synchronization to "eval" and "invokeMethod" and moves synchronization for "invokeFunction" to the InvocationInterceptingScriptEngineWithInvocableAndAutoCloseable class.
The synchronization mechanism changed from using synchronized to using a ReentrantLock together with catch_finally to avoid having deadlocks when an exception is thrown.
Fixes the multi-thread access requested warnings described in the community (https://community.openhab.org/t/openhab-3-4-milestone-discussion/138093/130) and related to https://github.com/openhab/openhab-core/pull/3180.

* [jsscripting] Reduce compiler warnings
* [jsscripting] Replace finally blocks & Wrap returns in afterInvocation
* [jsscripting] Fix deadlock caused by NoSuchMethodException in Invocable interface methods

During testing my latest changes, I noticed that there is a deadlock when invokeFunction or invokeMethod are called on a non-existing method.
This happens because the NoSuchMethodException keeps afterInvocation from running and therefore the lock never gets released.

* [jsscripting] Also rethrow NPE & Fix PMD warnings/errors
* [jsscripting] Wrap and rethrow other exceptions instead of returning them
* [jsscripting] Address review comment from @jpg0

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2022-12-14 20:12:54 +01:00
Jerome Luckenbach 1ca9baf157
[Documentation] Markdown improvements n to s (#13948)
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
2022-12-14 16:52:43 +01:00
Udo Hartmann d73218d882
[mqtt.generic] Change color example (#13861)
Change color example to fit to the real parameters.
2022-12-14 08:21:34 +01:00
Cody Cutrer 4aca2c6976
[jrubyscripting] remove some development logging that crept in (#13947)
Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-12-13 23:28:55 +01:00
Hilbrand Bouwkamp e9473caebc
[airq] fix table in readme that broke rendering markup (#13937)
Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2022-12-13 08:40:10 +01:00
openhab-bot 9c3ec387e5
New Crowdin updates (#13932)
* New translations boschshc.properties (Italian)

* New translations ecowatt.properties (French)

* New translations nikohomecontrol.properties (Dutch)

* New translations systeminfo.properties (Dutch)

* New translations upnpcontrol.properties (Dutch)
2022-12-13 07:27:26 +01:00
Jacob Laursen bd087f1c1c
Fix examples after migration of time channels (#13933)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-12 22:55:38 +01:00
Wouter Born 286a27db5b
[nest] Add missing enable SDM API configuration step to README.md (#13931)
Fixes #11814

Signed-off-by: Wouter Born <github@maindrain.net>
2022-12-12 22:12:24 +01:00
Jacob Laursen 518272a731
Fix dimension for powerConsumption channel (#13930)
Fixes #13929

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-12 22:10:48 +01:00
lolodomo e027932349
[goecharger] Consider correct channel ID (maxCurrentTemp) (#13927)
Fix #13891

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-12-12 20:28:59 +01:00
Ondrej Pecta 712262fb1e
[somfytahoma] fix the smoke sensor documentation (#13919)
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
2022-12-11 23:17:52 +01:00
Jacob Laursen a3fccc6390
Fix console command 'tables clean' (#13916)
NullPointerException was thrown because index table was not provided

Fixes #13911

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-11 22:47:37 +01:00
Jerome Luckenbach 73b6e886f2
Fix wrong image and website build. (#13917)
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
2022-12-11 21:43:42 +01:00
Kai Kreuzer 260f58904f
[homekit] Simplify start level handling (#13914)
Signed-off-by: Kai Kreuzer <kai@openhab.org>
2022-12-11 17:09:31 +01:00
Andrew Fiddian-Green 3ea004ad35
[siemensrds] Update to documentation (#13913)
* [siemensrds] resolve issue #13906
* [siemensrds] add chapter to readme

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2022-12-11 16:21:25 +01:00
Jørgen Austvik 70cca8fc77
[nanoleaf] More color for less network calls (#13893)
* [nanoleaf] More color for less network calls

This is a refactoring that moves the "get panel color" out of the
panel handler and into a separate class, with callbacks.

This makes us do only one REST call to get colors instead of one per
panel that is a thing. It also lets us retrieve colors for all panels -
 also those that doesn't have a thing in OpenHAB,

While testing this out, I found a bug where solid colors set in the app
wasn't reflected in neither the controller nor panel channels, and that
should also be fixed now.

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
2022-12-11 16:09:53 +01:00
Cody Cutrer 1dbcaf8f0c
[homekit] delay starting until a particular StartLevel (#13877)
* [homekit] delay starting until a particular StartLevel

instead of a blind "delay by seconds", the new default won't even
attempt to start until items are loaded (both file-based and UI-based),
with an additional config to let the user delay it any further (in
case they have items coming from JSR223 scripts that can't run until
at least SL20 anyway).

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-12-11 15:54:10 +01:00
Florian Hotze 438552d485
[jsscripting] Upgrade openhab-js & Remove SharedCache (#13908)
Upgrades the included openhab-js version to 3.1.0, which uses the new
caches from core (introduced in
https://github.com/openhab/openhab-core/pull/2887) and provides many
doc improvements.

Removes the SharedCache from the addon because this functionality is
now provided by core (see
https://github.com/openhab/openhab-core/pull/2887).

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2022-12-11 15:25:39 +01:00
Holger Friedrich 506c7387c5
[knx] Improve handling of serial gateways (#13897)
* [knx] Improve handling of serial gateways

Take over initialization logic from KNX IP gateway for serial gateway.
Properly re-initialize serial gateway after configuration changes done in UI.
Fixes #13892.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
2022-12-11 12:47:55 +01:00
Ondrej Pecta 45052a810c
[somfytahoma] added support for the control over the LAN (local mode) (#13411)
* [somfytahoma] added support for the control over the LAN (local mode)

Signed-off-by: Ondrej Pecta <opecta@gmail.com>
2022-12-11 12:07:25 +01:00
boc-tothefuture 48b471a313
[jrubyscripting] Reverses order of class imports and ScriptEngine puts calls to fix incompatability introduced after M5 (#13904)
Signed-off-by: Brian OConnell <broconne@gmail.com>
2022-12-11 11:00:13 +01:00
lolodomo 015cc847bb
[transform/scale] Make unit tests compatible with Windows (#13910)
Fix #13900

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-12-11 10:57:57 +01:00
Jørgen Austvik 8c0925a63b
Dont set read only temp file (#13905)
Because it breaks windows builds

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
2022-12-11 10:10:37 +01:00
Mark Herwege d0681251cb
[systeminfo] QuantityTypes and state descriptions cleanup (#13804)
* State descriptions cleanup
* Converted channels to QuantityType, adjusted default translations
* Channel definitions and percent to QuanityType
* Changed default state descriptions from MB to MiB

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
2022-12-10 23:32:25 +01:00
Jacob Laursen c09be1bfbe
Migrate time channels from DateTime to Number:Time (#13841)
Fixes #13840

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-10 23:05:59 +01:00
openhab-bot 5e73936aa8
New Crowdin updates (#13901)
* New translations boschshc.properties (Italian)

* New translations ecowatt.properties (French)
2022-12-10 16:54:00 +01:00
Christian Wild 8d28085226
[tapocontrol] add L610, L630 Spot and L930 LightStrip (#13814)
* fix color change bug*

Signed-off-by: Christian Wild <christian@wildclan.de>
2022-12-10 16:53:30 +01:00
openhab-bot ad5facc2e5
New translations boschshc.properties (Italian) (#13899) 2022-12-10 14:51:09 +01:00
lolodomo 4c962191b1
[vitotronic] Fix few thing/channel labels/descriptions (#13898)
Follow-up #13739

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-12-10 14:29:53 +01:00
Matthew Skinner 2a7b6bf1c9
[ipcamera] Add a check to see if FFmpeg is frozen for mjpeg creation (#13896)
* check if ffmpegMjpeg is frozen

Signed-off-by: Matthew Skinner <matt@pcmus.com>
2022-12-10 13:54:22 +01:00
Fejitatete 00d99e1c3f
[vitotronic] Add channel "currentmode" to thing "circuit" (#13739)
* [vitotronic] Add channel "currentmode" to thing "circuit"

Signed-off-by: Fejitatete <fejitatete@msn.com>
2022-12-10 13:08:41 +01:00
Gerd Zanker 584f637126
[boschshc] Support smoke detector (#13760)
* Add smoke detector service and add it to twinguard handler
* Add handler for smoke detector
* Support for smoke detector

added smoke detector device with SmokeDetectorCheckService
added SmokeDetectorCheckService to TwinguardHandler

added tests for smoke detector code
updated smoke detector code to latest boschshc version after cherry-picks of initial code from Christian Oeing

* re-generate i18n file, refactoring of smoke detector code to use abstract base classes
* Fix typos
* Add unit test for PlayPauseType commands
* Add unit test for SmokeDetectorCheckState
* Re-add null annotation
* Fix warning

Signed-off-by: Christian Oeing <christian.oeing@slashgames.org>
Signed-off-by: Gerd Zanker <gerd.zanker@web.de>
Signed-off-by: David Pace <dev@davidpace.de>
2022-12-10 11:18:13 +01:00
lsiepel db86d291da
[bosesoundtouch] Improve SAT errors and remove dependency (#13842)
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
2022-12-10 09:42:09 +01:00
Andrew Fiddian-Green 8e31d8f0ca
[siemensrds] Binding no longer fails if thermostat does not use optional features (#13888)
* [siemensrds] fix charset; ansi => utf-8
* [siemensrds] refactor class so CI build runs tests w/o errors
* [siemensrds] add missing UoM; fix compiler error
* [siemensrds] fix issue #13887

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
2022-12-10 09:02:11 +01:00
lsiepel b9f092fdb2
[TR064] Fix pattern excluding some valid ip-addresses (#13894)
* Improve logging and adjusted timeout
* Fix wanBlockIPs regex

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
2022-12-10 08:48:33 +01:00
lsiepel d85c2532e4
Add channel return temp (#13833)
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
2022-12-09 19:30:08 +01:00
Cody Cutrer 108c48dda5
[homekit] add BasicFan accessory (#13564)
* [homekit] add BasicFan accessory

This is Fan v1. It's a subset of FanV2, except that Home allows you
to customize the icon to show a ceiling fan.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-12-09 19:17:51 +01:00
lsiepel 76c785947b
[plugwiseha] Fix set the scene for a zone (#13832)
* Fix request body

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
2022-12-09 19:08:41 +01:00
mlobstein 7480c63636
Update README (#13868)
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
2022-12-09 12:32:47 +01:00
Hilbrand Bouwkamp a3ad12ba39
[astro] Fix IllegalArgumentException in debug message (#13884)
Formatter should get Date object.

Closes #13871

Signed-off-by: Hilbrand Bouwkamp <hilbrand@h72.nl>
2022-12-09 12:31:49 +01:00
lsiepel 22d5518ff4
[livisismarthome] Fix checkstyle (#13883)
* Minor fixes and refactoring
* Fix checkstyle warnings
* Fix new ConcurrentHashMap

Signed-off-by: Leo Siepel <leosiepel@gmail.com>
2022-12-09 09:57:17 +01:00
Cody Cutrer b56ab10e00
[homekit] implement basic command completion (#13878)
just the sub-commands.

since the show command is already a "search", I didn't feel it's super
important to implement on that

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-12-09 08:56:27 +01:00
lsiepel 3e66cd1b33
[TR064] Fix SAT warnings (#13873)
* Fix SAT warnings
* Fix markdown
* Properly annotate PhonebookProfileTest

Also-by: Wouter Born <github@maindrain.net>
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
2022-12-08 22:44:44 +01:00
Jørgen Austvik 02398b14a3
[Nanoleaf] Support lines (#13881)
Lines is a Nanoleaf shape we haven't been able to test earlier.

Now we have tested them, and added support for painting them as well.

They do unfortunately not support touch gestures.

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
2022-12-08 22:39:45 +01:00
Jerome Luckenbach 0e68936663
[Documentation] Markdown improvements f to m (#13866)
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
2022-12-08 21:36:05 +01:00
Hawkinzw 3c236b3103
[insteon] Binding Documentation: Updated I/O Linc Section (#13811)
* Update I/O Linc Documentation

The I/O Linc has a feature to match or invert the status of the contact with its control messages. The binding was written expecting the messages to be inverted. This is the opposite of how insteon recommends setting up the garage kit, and not described well by the original "Note" at the bottom of the section. Updated the instructions to specify the input is OFF when linking, and changed the note to better describe what happens if you don't. All based off of my own experience with the sensor: https://community.openhab.org/t/insteon-io-linc-garage-door-contact-slow-update/141469
2022-12-08 21:17:45 +01:00
Дилян Палаузов 0ffc5257d5
Typos a/an (#13876) 2022-12-08 21:12:49 +01:00
Jørgen Austvik 177ce2a217
[Nanolaef] Visual State Bugfix (#13880)
* Nanoleaf Visual State fix

Fix the visual state channel name.

Also:
- Better name (from state to visual state) of the (new) channel
- Better logs which has helped us debug the problem
- Some more information on when it will work in the README

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
2022-12-08 21:00:11 +01:00
Cody Cutrer 6a16c889f2
[homekit] persist all known accessories, to prevent loss of homekit information (#13484)
* [homekit] persist all known accessories, to prevent loss of homekit information

See the readme for more details, but basically this keeps track of every
accessory we've ever created, and if it no longer exists, presents a dummy
accessory instead. If the accessory comes back, nothing is lost in the Home
app; if you meant to prune it permanently, you have to run a console command.

there are also several fixes to prevent presenting the device with missing data -
such as when the bundle stops, _don't_ explicitly remove the accessories until
the server has stopped.

we also don't increment the configuration version unless the configuration
has _actually_ changed (so removing and re-adding the exact same thing
won't trigger the device to reconnect). this even works across restarts
of the bundle, because we're persisting all the accessory information
for dummy information anyway.

* [homekit] Address review comments for accessory persistence

* update hap-java to 2.0.4
* remove unused local variable
* [homekit] ensure accessories are replaced in a batch

so that HAP-Java can maintain subscriptions with the new objects

* [homekit] log individual dummy accessories up to 5
* [homekit] Tweak readme for dummy accessories slightly.

 * Be consistent with proper usage of useDummyAccessories.
 * Make the sentence more clear about the effects of having dummy accessories.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-12-08 13:52:30 +01:00
Wouter Born 3c936dbda9
Upgrade commons-net to 3.9.0 (#13869)
Related to openhab-core#3200

Signed-off-by: Wouter Born <github@maindrain.net>

Signed-off-by: Wouter Born <github@maindrain.net>
2022-12-08 07:09:46 +01:00
mlobstein 0c53ce998c
[atlona] Update README (#13867)
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
2022-12-07 21:33:00 +01:00
Jerome Luckenbach caf71f72e6
[Documentation] Markdown improvements for bindings a to e (#13859)
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
2022-12-07 21:09:32 +01:00
Sönke Küper 72efc1cfed
[ahawastecollection] Fixed unstable test (#13864)
* Added Constructor parameter to pass custom ScheduledExecutorService, that allows deterministic execution in test cases.
* Fixed some codestyles.

Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
2022-12-07 10:22:51 +01:00
stefan-hoehn 4c93125723
[nanoleaf] add LONG_PRESSED tap detection (#13865)
* [nanoleaf] add LONG_PRESSED tap detection

Signed-off-by: Stefan Höhn <stefan.hoehn@nfon.com>
2022-12-07 05:49:04 +01:00
openhab-bot 35f416da9a
New Crowdin updates (#13863)
* New translations openwebnet.properties (Italian)
* New translations bluetooth.properties (Italian)
* New translations vesync.properties (Italian)
2022-12-06 16:10:01 +01:00
mlobstein fc529777e4
[vizio] Vizio TV binding - Initial contribution (#13309)
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
2022-12-06 15:37:54 +01:00
Florian Hotze a9d4244fd8
[jsscripting] Fix "Error removing engine" context already closed (#13855)
In recent PR #13824, I added closing the context when the engine is closed, but core seems to have problems with that.

It logs: "[ERROR] [ipt.internal.ScriptEngineManagerImpl] - Error removing ScriptEngine
java.lang.IllegalStateException: The Context is already closed."

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2022-12-06 13:15:47 +01:00
Sami Salonen 923c0f1db2
[mqtt] Avoid parallel streams with common thread pool to avoid deadlocks (#13621)
To mitigate issue https://github.com/openhab/openhab-core/issues/3125
(common thread pool exhaustion when combining parallel streams with
synchronization or locks)

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
2022-12-06 13:02:45 +01:00
Jacob Laursen be6bfb0f9b
Use message for HTTP error code when response payload is not valid JSON (#13854)
Fixes #13853

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-06 08:45:31 +01:00
Florian Hotze bf48eccf8c
[jsscripting] Refactor log formatting & Respect toString polyfills (#13844)
* [jsscripting] Refactor log formatting & Respect toString polyfills
* [jsscripting] Catch errors in log formatting & Improve handling of Java obj
* [jsscripting] Update log format failure message

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2022-12-05 20:46:17 +01:00
Simon Spielmann d0b1458e89
Correct item type for state item in readme.md (#13845)
Signed-off-by: Simon Spielmann <simon@MacBook-Pro.fritz.box>
2022-12-05 19:11:52 +01:00
Дилян Палаузов 2a5d6beb64
Typos a/an (#13846) 2022-12-05 18:47:43 +01:00
Florian Hotze 54b2772df4
[jsscripting] Add an alternative MIME type/alias (#13851)
The alternative MIME type text/javascript is also used by Nashorn, therefore we add the same extension as for the main MIME type.
The alias is introduced to simplify the usage in SCRIPT transformation profiles.

* Fix syntax problems in the bndtools file
* Add null check to avoid potential NPE
  In some cases during testing, a NPE occured, this should solve it.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2022-12-05 18:40:15 +01:00
Cody Cutrer 52b7b7981f
[bondhome] Initial contribution (#13459)
* First commit on newly created branch, taking code from c8b8e210dfd23f98526763782eadbca49509baf9
* [bondhome] update snapshot version, and some typos
* [bondhome] Address (most) comments from prior review from #7260
* [bondhome] simplify channels

 * lastUpdate is unnecessary; turn on persistence or add a rule on update if
   you care to keep track of it
 * use a single string command channel for all shoot-and-forget commands, instead
   of multiple switch channels
 * use a rollershutter channel for shades (accepting UP, DOWN, STOP, 0%, and 100%)
 * on all dimmer channels, accept ON and OFF, as well as 0% to imply OFF, instead
   of having to write rules to control ON/OFF state separately.
 * if the dimmer channel exists, prune the corresponding power channel, since
   the dimmer channel is now a pure superset of its functionality
 * overload fan#speed to be ceiling fan or a fireplace's fan, depending on the
   device type
* [bondhome] add bundle to the BOM pom
* [bondhome] clean up BondDeviceHandler a bit

 * there's no need to delay initialization; ThingManager won't
   even attempt to initialize a child thing until its bridge is online
 * Remove some extra initialization checks that can never be false
 * slightly refactor some methods to return early, rather than
   nest a giant `else`
 * remove some info logging that will get triggered in normal usage
* [bondhome] fix bridge discovery

 * Bridge property and config serial number need to be the same name
 * Don't arbitrarily delay the BPUPListener
 * Automatically update the IP if the BPUPListener finds it
 * Provide the new bridge with its discovered IP to avoid an additional
   DNS query
 * Don't get the bridge version after every keep-alive response
* [bondhome] trigger end-device discovery as soon as the bridge comes online
* [bondhome] remove internal binding version
* [bondhome] change addr property to string

Certain values seen in the wild when interpreted as a long are too big for that
storage. Also, the Bond API documentation describes the addr property on a
device to be a string.

OpenHAB already has infrastructure to have things update their
channel definitions when a binding is updated.

* [bondhome] ignore any device that starts with _

In v3 of their API, Bond added a new special entry of __. Because no valid
device id would start with an underscore, ignore everything that starts with an
underscore to fix v3 and maybe futureproof.

* address review comments

mostly adding i18n to error states, and cleaning up error handling of
HTTP requests.

* use builtin translation services

instead of plumbing our own provider through

* use System.nanoTime instead of currentTimeMillis

so that it will be a monotonic clock, not (as) susceptible to the clock
changing

* [bondhome] ignore BPUP messasges that aren't state

In recent firmware, bond is now sending action messages via BPUP as well as state.
This change ignores all messages that aren't state.

* [bondhome] Improve error handling, and remove dummy constants

Just use a single BondException class to communicate any sort of
error from within bond, and avoid throwing, catching, and re-throwing
the same (or slightly modified) exception.

Also remove dummy constants that might give the wrong impression
of the details of your Bond device. Then implement proper null checks,
especially setting a configuration error if key config properties
aren't set on the thing.

* [bondhome] avoid setting device status when bridge just went offline

* address static analysis tool problems

Also-by: Sara Damiano <sdamiano@stroudcenter.org>
Also-by: Keith T. Garner <kgarner@kgarner.com>
Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-12-05 17:19:35 +01:00
Jacob Laursen dd8b7c8b65
[jdbc] Fix date filter to be inclusive (Derby) (#13850)
Fixes #9906

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-05 17:09:13 +01:00
openhab-bot 93633a9af9
New Crowdin updates (#13848)
* New translations miele.properties (Danish)
* New translations jruby.properties (Italian)
* New translations ecowatt.properties (Italian)
* New translations webexteams.properties (Italian)
2022-12-05 15:56:34 +01:00
M Valla 7ce99b365a
[openwebnet] Add support for Alarm (WHO=5) (#13694)
* [openwebnet] first changes for Alarm support
* [openwebnet] added first version Alarm handler
* [openwebnet] added ownIdTest for Alarm
* [openwebnet] added things def for Alarm and discovery for alarm zone
* [openwebnet] refreshDevice
* [openwebnet] fix text formatting
* [openwebnet] fixes
* [openwebnet] added other alarm channels
* [openwebnet] Alarm: codestyle and null checks
* [openwebnet] updated Alarm examples in README and some cleanup
* [openwebnet] changed zone channel from armed to state, cleaned README

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
2022-12-05 12:57:25 +01:00
pali 590b2cb4f7
[lifx] Set tagged flag accordingly for unicast and broadcast messages (#13744)
* Set tagged flag accordingly
* Update packets

Also-by: Wouter Born <github@maindrain.net>
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
2022-12-05 10:00:10 +01:00
Markus Michels 8f972362c3
[shelly] Plus 1/1PM Add-On support; fix roller pos on open/close state (#13520)
* Added #13493 Plus 1/1PM addon support; Fixed #13515 pos for roller in
open/close state; various null warnings removed; README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* digitalInput, analogInput and voltage added for Add-On; README updated

Signed-off-by: Markus Michels <markus7017@gmail.com>

* shelly2-roller re-added (wrong assumption that Shelly 2 doesn't support
roller mode, because it has no power meter)

Signed-off-by: markus7017 <markus7017@gmail.com>
Signed-off-by: Markus Michels <markus7017@gmail.com>

* Initialization for Californium 2.7.3 fixed (no multicast packets where
received)

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Analogous input support for Plus Addon changed; Allterco made a format
change in the beta firmware

Signed-off-by: Markus Michels <markus7017@gmail.com>

* changes applied

Signed-off-by: Markus Michels <markus7017@gmail.com>

* README updated; Shelly Plus addon handling adjusted to latest firmware
(before was beta)

Signed-off-by: Markus Michels <markus7017@gmail.com>

* Update bundles/org.openhab.binding.shelly/README.md

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

* fix JSON for Shelly1 - ext_switch_enable is a boolean, not an int

Signed-off-by: Markus Michels <markus7017@gmail.com>

Signed-off-by: Markus Michels <markus7017@gmail.com>
Signed-off-by: markus7017 <markus7017@gmail.com>
Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
2022-12-05 08:51:31 +01:00
Cody Cutrer 2382fadaaa
[jrubyscripting] Implement dependency tracking (#13810)
* [jrubyscripting] implement dependency tracking

watchers had to be refactored similar to jsscripting.
it supports watching any directory referenced from RUBYLIB,
as well as the gem home. it properly excludes lib and gem home
(as well as other gem homes if you have multiple jruby versions
installed) from loading as regular scripts.

this is a breaking change if you don't have RUBYLIB explicitly
configured, and you are using the old default directory.

it's expected that the detection of what files and gems any
given script uses will be self-identified by the script, presumably
by the helper library.

JRubyScriptEngineConfiguration was largely refactored as part of this.
 * CONFIGURATION_PARAMETERS was renamed, and is no longer static, since
   it's modified every time the configuration is changed
 * OptionalConfigurationElement was simplified since default values
   are always provided now. this also simplified lots of other code
   that accesses the current settings.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-12-05 08:19:51 +01:00
Jacob Laursen a0ac57cfd9
Fix date filter to be inclusive (PostgreSQL) (#13843)
Fixes #9906

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-05 00:27:54 +01:00
Tom Deckers 45a3054c76
Fix person reauth (#13839)
* add null checks
* fix/improve account.html

Signed-off-by: Tom Deckers <tom@ducbase.com>
2022-12-04 19:16:07 +01:00
openhab-bot af8d984cd3
New Crowdin updates (#13836)
* New translations smsmodem.properties (French)

* New translations webexteams.properties (French)

* New translations smsmodem.properties (Italian)
2022-12-04 17:13:46 +01:00
lolodomo 7cbae110a0
[ecowatt] Add channels for D+2 and D+3 (#13823)
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
2022-12-04 16:32:26 +01:00
Jacob Laursen 312b4e2faf
Fix console command 'tables' for SQLite (#13837)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-04 14:54:12 +01:00
lsiepel 3b3d18cef4
[tibber] Fix SAT warnings (#13835)
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
2022-12-04 12:18:20 +01:00
Tom Deckers b696aebb36
[webexteams] Initial contribution (#13492)
* [webexteams] Initial contribution

Signed-off-by: Tom Deckers <tom@ducbase.com>
2022-12-04 12:15:42 +01:00
mschlenstedt e7fcd03d59
[nibeheatpump] Readme for NibeGW for Arduino with Hardware and compilation hints (#13787)
* Hints for compiling and connecting hardware
2022-12-04 11:52:47 +01:00
openhab-bot c7bd1747f1
New Crowdin updates (#13830)
* New translations avmfritz.properties (German)
* New translations androiddebugbridge.properties (Italian)
2022-12-04 00:41:16 +01:00
Daniel Demus 193b54107c
[wundergroundupdatereceiver] Use html entities where in normal body (#13831)
Fix spelling

Signed-off-by: Daniel Demus <daniel-github@demus.dk>
2022-12-04 00:39:14 +01:00
Gwendal Roulleau 56728b6091
[smsmodem] Initial contribution (#12250)
* [smsmodem] Initial contribution

This binding connects to a USB serial GSM modem (or a network exposed one, a.k.a ser2net) and allows openHAB to send and receive SMS through it.

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] README fix

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] build/spotless fix

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] compliance with 3rd party license

And long running thread naming convention
And treated some code warning 

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] i18n

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] Small fixes

update channel
rename action to avoid colision with other binding and a too generic name

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] Use of standard Thing properties

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] Fix sender identifier error with special character

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] Add encoding parameter

For non latin character in SMS

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] Apply review

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] Split local and remote modem in two thing-types

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] Apply review

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] Apply review

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

* [smsmodem] Apply code review (removing unnecessary method)

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>

Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
Co-authored-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
2022-12-03 21:35:30 +01:00
GiviMAD 3e068ed431
[androiddebugbridge] Fix volume channel for android 11/12 (#13828)
* [androiddebugbridge] Fix volume channel for android 11/12
* [androiddebugbridge] Try get max volume level from device properties
* [androiddebugbridge] Fixes reported code analysis
* [androiddebugbridge] Fix comparison

Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
2022-12-03 17:40:29 +01:00
Raphael Mack d777aa46c9
[resol] Fix handling of WeekTime fields on vbus (#13753)
* correct handling of WeekTime fields from and update vbus library, fixes #13447

Signed-off-by: Raphael Mack <ramack@raphael-mack.de>
2022-12-03 14:59:26 +01:00
maniac103 86e3b65816
[homematic] Fix min/max values for rollershutters (#13821)
* [homematic] Fix min/max values for rollershutters

For dimmers, the 1.0 max value sent by CCU was already converted to
percent values in the item state description. Do the same thing also for
roller shutters.

Signed-off-by: Danny Baumann <dannybaumann@web.de>
2022-12-03 13:29:52 +01:00
Jacob Laursen 3bd34b3256
Migrate uptime channels to support UoM (#13827)
Fixes #13826

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-03 12:36:28 +01:00
Matthew Skinner 2a78b306d8
[ipcamera] Instar API updates for new 2k+ range (#13805)
* Instar updates
* Detect which API to use from reply.
* Add handling of REFRESH to instar.

Signed-off-by: Matthew Skinner <matt@pcmus.com>
2022-12-03 10:20:11 +01:00
openhab-bot 75b639e9b3
New Crowdin updates (#13825)
* New translations openwebnet.properties (Italian)
* New translations unifi.properties (Dutch)
2022-12-03 00:47:36 +01:00
Florian Hotze 42b8505bef
[jsscripting] Fix memory leak that crashes openHAB (#13824)
* [jsscripting] Fix memory-leak caused by com.oracle.truffle.host.HostObject

Fixes this memory leak by making the HostAccess for the GraalJSScriptEngine available in a static final variable instead of creating it for each new engine.
Solution proposed in https://github.com/oracle/graaljs/issues/121#issuecomment-690179954.

Sharing a single engine across all Contexts (as proposed in https://github.com/oracle/graaljs/issues/121#issuecomment-880056648) is not possible, because core expects a ScriptEngine.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

* [jsscripting] Update JavaDoc

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>

* [jsscripting] Close `GraalJSScriptEngine` when `OpenhabGraalJSScriptEngine` is closed

My breakpoint inside the close method of GraalJSScriptEngine did not trigger until this change was made.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2022-12-03 00:17:39 +01:00
Marcel 224d86e88a
[miio] add support Xiaomi Smart Air Purifier 4 Compact (#13806)
* [miio] add support zhimi.airp.cpa4 WIP
* [miio] add support Xiaomi Smart Air Purifier 4 Compact

Adding support for the following models:
* Xiaomi Smart Air Purifier 4 Compact (modelId: zhimi.airp.cpa4)

Minor typo fixing (note: no breaking channel changes)

close: #13763

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
2022-12-02 21:44:33 +01:00
Wouter Born ce3067339d
[groovyscripting] Update Groovy to 3.0.13 (#13822)
Updates Groovy from 3.0.9 to 3.0.13.

For all bugfixes and improvements, see:

* https://groovy-lang.org/changelogs/changelog-3.0.10.html
* https://groovy-lang.org/changelogs/changelog-3.0.11.html
* https://groovy-lang.org/changelogs/changelog-3.0.12.html
* https://groovy-lang.org/changelogs/changelog-3.0.13.html

Signed-off-by: Wouter Born <github@maindrain.net>
2022-12-02 21:17:25 +01:00
Jørgen Austvik cad69c8de5
[Nanoleaf] New Channel: State (#13746)
* [Nanoleaf] New Channel: State

Shows an image of the state of the panels with color.

Also makes the layout slightly prettier. This is less functional than the layout, and more eyecandy.

Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
2022-12-02 21:14:53 +01:00
batje 45cbf52cf3
fix typos in plugwise plugin examples (#13820) 2022-12-02 13:09:04 +01:00
Дилян Палаузов 6c1373f7c2
Typos a/an (#13819) 2022-12-02 13:07:31 +01:00
Jacob Laursen e979be4911
Fix Derby/H2/HSQLDB/SQLite queries for storing timestamps (#13817)
Fixes #13816

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-02 08:14:23 +01:00
pali 383b5137e4
[nibeheatpump] Support 16-bit addressing (#13752)
* [nibeheatpump] Support for 16-bit addressing

Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
2022-12-01 23:15:34 +01:00
Øystein Bedin 8d39875219
[tplinksmarthome] Add support for TP-Link KP401 Smart WiFi Outdoor Plug (#13818)
* [tplinksmarthome] Adding support for tp-link KP401 Smart WiFi Outdoor Plug

Signed-off-by: Øystein Bedin <oybed78@gmail.com>
2022-12-01 22:50:28 +01:00
Daniel Demus 43d01ad49c
[wundergroundupdatereceiver] Bugfixes: Regenerate trigger channel with proper type and more metadata. Normalize channel names. It might be easiest to delete and allow recreation of channels. (#13327)
* [wundergroundupdatereceiver] LAST_QUERY parameter should not be mapped automatically
* [wundergroundupdatereceiver] All channeltype props need to be applied
Especially the channel kind
* [wundergroundupdatereceiver] Remove illegal characters from channel name

Additionally expand the channel naming test to assert the generated channelUID and test that _ in names isn't inadvertently replaced

* [wundergroundupdatereceiver] Don't default AutoUpdatePolicy on creation
* [wundergroundupdatereceiver] Migrate changed channel to trigger type

Signed-off-by: Daniel Demus <daniel-github@demus.dk>
2022-12-01 22:47:11 +01:00
dependabot[bot] 9cc3cd0cf9
[jdbc] Update PostgreSQL JDBC driver to 42.4.3 (#13770)
* Bump postgresql in /bundles/org.openhab.persistence.jdbc

Bumps [postgresql](https://github.com/pgjdbc/pgjdbc) from 42.4.1 to 42.4.3.
- [Release notes](https://github.com/pgjdbc/pgjdbc/releases)
- [Changelog](https://github.com/pgjdbc/pgjdbc/blob/master/CHANGELOG.md)
- [Commits](https://github.com/pgjdbc/pgjdbc/compare/REL42.4.1...REL42.4.3)

---
updated-dependencies:
- dependency-name: org.postgresql:postgresql
  dependency-type: direct:production
...

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-12-01 22:32:55 +01:00
Дилян Палаузов 78534e8106
Typos a/an (#13812) 2022-12-01 14:30:50 +01:00
Zhivka Dimova 622654ff1d
[enocean] Handle messages with MSC RORG (#13786) (#13792)
Setting senderId for MSC RORG and set rorg to Unknown when there is no
mach with the supported(handled) RORG types.
Fixes #13786

Signed-off-by: Zhivka Dimova <zhivka.dimova@myforest.net>
2022-11-30 20:55:36 +01:00
J-N-K ae677dcd9d
[jsscripting] Refactor dependency tracking (#13756)
Signed-off-by: Jan N. Klug <github@klug.nrw>
2022-11-29 21:59:58 +01:00
openhab-bot 4163775e0b
New translations mqtt.properties (Italian) (#13809) 2022-11-29 19:35:06 +01:00
Marcel ac546dee0f
[miio] cloud login issues improvement (#13715)
* [miio] cloud login issues improvement

* Small change in debug loggin is login issues are expected
* Additional trouble shooting steps in readme
* Fix duplicate name in device list preventing readme maker running
* Catch a json exception in readme maker

close #13611
close #7459

* [miio] fix strange/foreign characters in readme

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
2022-11-29 12:26:38 +01:00
M Valla 740d1a7f85
[openwebnet] Thermo: zone/CU address set correctly during discovery (#13803)
Fixes #13761

Signed-off-by: Massimo Valla <mvcode00@gmail.com>
2022-11-29 12:08:22 +01:00
Cody Cutrer 6bdcd15d99
[mqtt.espmilight] Automatically convert color values to color temp (#13578)
* [mqtt.espmilight] Automatically convert color values to color temp for RGB+CCT bulbs

Yes, it's lots of math, but references are provided. This supplants
whiteThreshold for RGB+CCT bulbs since it is far more flexible and
accurate.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-11-29 00:33:49 +01:00
jimtng 735089a7c7
[jrubyscripting] Allow multiple version specifiers for gems (#13779)
Signed-off-by: Jimmy Tanagra <jcode@tanagra.id.au>
2022-11-28 23:51:19 +01:00
Jacob Laursen 3912487305
[jdbc] Add safety valve for suspicious migrations (#13797)
* Abort migration from real names when most tables have table name prefix
* Add missing checks for database connection from console commands
* Add additional documentation for check/fix schema

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-28 23:38:55 +01:00
Cody Cutrer 826fc9e8d7
[homekit] make sure to convert step values to Celsius (#13796)
otherwise if your step is 1.0 in fahrenheit, then your
values will get rounded to 1.0 celsius, and you might not
even notice you've lost precision in the Home app.

Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-11-28 23:11:40 +01:00
Florian Hotze 446be35ac5
[evcc] Extend accepted types for commands & Handle quantity types of commands (#13795)
* [evcc] Extend accepted command types
* [evcc] Convert QuantityType commands to required units
* [evcc] Allow evcc URL to end with a slash

Should fix an issue on the forum, where a user sent a command of DecimalType, but the binding expected a QuantityType.
See https://community.openhab.org/t/evcc-binding-electric-vehicle-charging-control/135209/15.
The accepted command types are extended for all channels if possible.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2022-11-28 22:17:26 +01:00
Dan Cunningham d3ecba9e79
[qolsysiq] Fixes ENUM Typo (#13790)
Signed-off-by: Dan Cunningham <dan@digitaldan.com>

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
2022-11-28 01:07:57 +01:00
eugen 5c5b3c29c9
[homekit] support stop for blinds (#13788)
* implement new blinds logic
* fix NPE, improve emulated state

Signed-off-by: Eugen <eugen@relotrust.com>
2022-11-27 23:39:50 +01:00
Dan Cunningham 1d9bf63d5e
[qolsysiq] Initial contribution of the Qolsys IQ Binding (#13699)
* [qolsysiq] Initial contribution of the Qolsys IQ Binding

Signed-off-by: Dan Cunningham <dan@digitaldan.com>
2022-11-27 19:25:31 +01:00
Jacob Laursen 22ea587d20
[jdbc] Add console command for checking/repairing schema integrity (#13765)
* Add console command for checking schema integrity
* Remove unneeded logging
* Add console command for fixing schema integrity
* Provide documentation
* Try to add support for Derby and PostgreSQL
* Sort alphabetically by item name

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-27 19:02:43 +01:00
Jerome Luckenbach 8681544e3b
Fix log and website build (#13781)
Signed-off-by: Jerome Luckenbach <github@luckenba.ch>

Signed-off-by: Jerome Luckenbach <github@luckenba.ch>
2022-11-26 15:05:14 +01:00
Thomas Traude 66d7496d7b
[knx] Remove obsolete public modifier in tests (#13776)
Since JUnit Jupiter test classes and methods do not need to be `public`.

It is recommended to omit the `public` modifier.
See https://junit.org/junit5/docs/current/user-guide/#writing-tests-classes-and-methods

"Class and method visibility
Test classes, test methods, and lifecycle methods are not required to be
`public`, but they must not be `private`.

It is generally recommended to omit the `public` modifier for test
classes, test methods, and lifecycle methods unless there is a technical
reason for doing so (...)"

Signed-off-by: Thomas Traude <t-riggs@gmx.net>
2022-11-26 12:19:43 +01:00
Cody Cutrer 4739f126a2
[jrubyscripting] log Ruby stacktrace on exception from JRuby (#13778)
Signed-off-by: Cody Cutrer <cody@cutrer.us>
2022-11-26 08:19:22 +01:00
Matthew Skinner ea134d8215
[ipcamera] Improve support for newer 2k+ Instar cameras (#13773)
* Fix never ending WARN when HIK camera does not support alarm inputs.
* Streamline code.
* Update Instar support for 2k+ Generation.
* Fix alarm codes.
* Add CHANNEL_LAST_EVENT_DATA

Signed-off-by: Matthew Skinner <matt@pcmus.com>
2022-11-26 08:15:29 +01:00
Marcel 698bee7c3e
[miio] add support Xiaomi Smart Air Purifier 4 (modelId: zhimi.airp.mb5) (#13717)
* [miio] add support Xiaomi Smart Air Purifier 4 (modelId: zhimi.airp.mb5)

Adding support for the following models:
* Xiaomi Smart Air Purifier 4 (modelId: zhimi.airp.mb5)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
2022-11-26 06:59:34 +01:00
mlobstein b4a5afd6a6
[nuvo] update rules examples in README (#13771)
* update rules examples

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
2022-11-25 08:08:59 +01:00
Florian Hotze 29d2578981
[jsscripting] Fix add-on name in feature/pom (#13764)
* Update pom.xml
* Update feature.xml
* [jsscripting] Rename from JSScripting to JavaScript Scripting

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2022-11-24 23:23:19 +01:00
openhab-bot ac3feabf1a
New translations sensebox.properties (German) (#13774) 2022-11-24 13:03:33 +01:00
openhab-bot ce4843f020
New translations sensebox.properties (German) (#13762) 2022-11-22 08:15:31 +01:00
Jacob Laursen f9aa20e488
[jdbc] Fix date filter to be inclusive (#13734)
Fixes #9906

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-22 07:13:45 +01:00
Gaël L'hopital 1d23c32de1
Solves issue #11691 (#13758)
Signed-off-by: clinique <gael@lhopital.org>
2022-11-21 20:38:37 +01:00
openhab-bot 6c170db1bd
New translations boschshc.properties (Italian) (#13757) 2022-11-21 11:08:49 +01:00
David Pace 1251873843
[boschshc] Support smart light bulbs (#13725)
* [boschshc] Support smart light bulbs (#13707)

* add thing type definition for smart bulbs using system channels
* add constants for thing type and channels
* implement and register handler
* implement binary switch service (to switch on/off)
* implement multi-level switch service (allows to get/set brightness
from 0-100%)
* implement service to get and set colors
* add unit tests for handler and state classes
- update documentation

Signed-off-by: David Pace <dev@davidpace.de>
2022-11-20 22:12:49 +01:00
Florian Hotze bfff07bb01
[jsscripting] Reimplement timer creation method of `ScriptExecution` (#13695)
* [jsscripting] Refactor ThreadsafeTimers to create futures inline instead of in an extra methods
* [jsscripting] Introduce utility class for providing easy access to script services
* [jsscripting] Reimplement timer creation methods from ScriptExecution for thread-safety
* [jsscripting] Add missing JavaDoc for reimplement timer creation methods
* [jsscripting] Remove the future from the map when setTimeout expires
* [jsscripting] Rename `GraalJSScriptServiceUtil` to `JSScriptServiceUtil`
* [jsscripting] Remove the `createTimerWithArgument` method
* [jsscripting] Replace the OSGi workaround of `JSScriptServiceUtil` with an injection mechanism
* [jsscripting] Use constructor to inject `JSScriptServiceUtil` into `GraalJSScriptEngineFactory`
* [jsscripting] Minor improvements by @J-N-K (#1)
* [jsscripting] Minor changes related to last commit to keep flexibility of `JSRuntimeFeatures`
* [jsscripting] Upgrade openhab-js to v2.1.1
* [jsscripting] Remove unused code

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Co-authored-by: Jan N. Klug <github@klug.nrw>
2022-11-20 22:08:19 +01:00
Fabian Wolter d0736bdea9
[pwm] Fix NPE when disabling and improve logging (#13755)
* [pwm] Fix exception when disabling the module
* Improve logging

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
2022-11-20 20:38:00 +01:00
Florian Hotze 103619741d
[jsscripting] Fix the `console.trace` polyfill to log a stack trace & Stringify JS `Error` (#13749)
* [jsscripting] Fix the `console.trace` polyfill to log a stack trace & Stringify JS `Error`
* [jsscripting] Add myself to the codeowners

Fixes #12646

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2022-11-20 20:30:42 +01:00
eugen 54e934be3d
[homekit] simplify settings page, resize doc images (#13741)
* simplify config, resize images

Signed-off-by: Eugen <eugen@relotrust.com>
2022-11-20 20:07:45 +01:00
openhab-bot 34b2cead83
New translations sensebox.properties (German) (#13748) 2022-11-20 17:35:58 +01:00
Florian Hotze 4dde19203a
[jsscripting] Fix maven build (#13747)
This fixed the maven build, that fails because webpack-cli version 5.0.0 doesn’t properly process the given entrypoint.
Instead, webpack tries to use the entrypoint from openhab-js‘ webpack config file.

Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
2022-11-20 17:30:23 +01:00
Jacob Laursen d3348327a9
Fix PostgreSQL query for storing timestamps (#13745)
Fixes #13121

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-19 20:57:51 +01:00
Matthew Skinner c9b9002b8e
Fix wrong textual format. (#13742)
Signed-off-by: Matthew Skinner <matt@pcmus.com>
2022-11-19 09:22:58 +01:00
mlobstein ed96a39b99
[dscalarm] Fix broken link in README (#13743)
* Update README

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
2022-11-19 09:18:32 +01:00
Jacob Laursen d075f141d7
Make itemsManageTable configurable (#13737)
Fixes #9637

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-18 17:34:10 +01:00
openhab-bot 63ecbc264a
New translations juicenet.properties (Italian) (#13736) 2022-11-17 22:56:36 +01:00
Jacob Laursen ea49488b86
[harmonyhub] Fix reliability issues (#13702)
* Fix compiler info

Unsafe interpretation of method return type as '@NonNull' based on the receiver type 'java.util.Enumeration<java.net.@NonNull NetworkInterface>'. Type 'java.util.Enumeration<E>' doesn't seem to be designed with null type annotations in mind

* Improve robustness of job rescheduling and handler disposal

Handler tried updating thing although the handler was already disposed

Fixes #13701

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-17 20:48:28 +01:00
Jacob Laursen b6f9f6339e
[jdbc] Add warning about using tableCaseSensitiveItemNames without dedicated schema (#13732)
* Add warning about using tableCaseSensitiveItemNames without dedicated schema
* Move warning to extended description
* Rephrase explanation
* Fix commands

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-17 20:05:10 +01:00
Jacob Laursen dbf2358280
Do not modify index or create tables when uninitialized (#13728)
Fixes #13727

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-17 20:00:31 +01:00
Jacob Laursen 2f786b87b4
Add console command for reloading index/schema (#13733)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-17 19:52:54 +01:00
Doug Culnane cc3ac23ae0
[awattar] Fix that allows bridge to be added via UI. (#13730)
Signed-off-by: Doug Culnane <doug@culnane.net>
2022-11-17 19:46:57 +01:00
Jacob Laursen 3ef974df17
Fix NoSuchElementException when there are no tables (#13731)
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
2022-11-17 00:58:14 +01:00
Marcel cf241f8b4f
[miio] Fix dimming channels for several yeelights (#13724)
The majority of brightness channels were already converted to dimmer.
This PR applies same to the 'other'brightness channels like nightlight
and/or ambient

close: #9936

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
2022-11-16 13:26:26 +01:00